View source for Gaia/SMS/Scrum/3/Planning

=== SMS issues handled by the SMS subteam (blocks the sprint {{bug|1022706}}) ===
[https://bugzilla.mozilla.org/buglist.cgi?f1=blocked&o1=substring&query_format=advanced&v1=1022706 Bugzilla link]

<bugzilla>
{
  "component": "Gaia::Sms",
  "blocks": " 1022706",
  "include_fields": "id, assigned_to, summary, cf_blocking_b2g, cf_feature_b2g, whiteboard, resolution"
}
</bugzilla>

== Minutes ==
* Date: 10th June 2014, 07:30 UTC
* Location: irc.mozilla.org/#gaia-messaging
* Attending: Steve, Oleg, Julien

* arnau est parti (Quit: Leaving.)
* arnau (Arnau@7779189C.6416DC44.F2D53343.IP) a rejoint #gaia-messaging
{{Line|julienw|I think we should first take whatever is not finished yet}}
{{Line|julienw|that's bug 1008127, bug 1015867, bug 990537}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1008127 nor, --, 2.0 S3 (6june), pivanov, ASSI, [Messages][Refresh] Subject handling in the Composer}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1015867 nor, --, 2.0 S3 (6june), felash, ASSI, [Messages] The editable composer should take more space}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}990537 nor, --, 2.0 S3 (6june), felash, ASSI, [DSDS] Messaging. Apply Visual Refresh to DSDS scenarios.}}
{{Line|julienw|and bug 1013296 ?}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1013296 nor, --, 2.0 S4 (20june), arnau, ASSI, Compose. Change send button to an paper plane icon}}
{{Line|azasypkin|I'd say and this one too 925404}}
{{Line|azasypkin|bug 925404}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}925404 nor, --, ---, azasypkin, ASSI, [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known}}
{{Line|azasypkin|in fact it also VR}}
{{Line|julienw|oki}}
{{Line|julienw|and bug 1012663  for security team}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1012663 nor, --, ---, nobody, NEW, [SMS] Remove inline style for CSP compliance}}
{{Line|julienw|oh bt w}}
{{Line|julienw|any holiday for you ?}}
{{Line|julienw|next sprint finish June 24th}}
{{Line|julienw|I will be in holiday the monday 23 and tuesday 24}}
{{Line|azasypkin| let me check, it's only 5 month since I have totally different holiday calendar :)}}
{{Line|julienw|so you'll do the planning yourself :) (I'll try to prepare stuff still)}}
{{Line|azasypkin|ok, I have only one June 19th}}
{{Line|julienw|yeah, I remember when I was in Stuttgart :D}}
{{Line|azasypkin|oh :)}}
{{Line|julienw|(I'll cut this in the minutes :p)}}
{{Line|julienw|so, I think we should lower the veloity}}
{{Line|julienw|like 9 instead of 10}}
{{Line|julienw|unless schung has also holidays :)}}
{{Line|julienw|schung, are you still there ? :p}}
{{Line|schung|julienw: sorry  I was interrupt by others...}}
{{Line|julienw|no problem}}
{{Line|schung|julienw:  I have no holiday before 6/24 (Only one day for health examination), so 9 or 10 both fine for me}}
{{Line|julienw|oki}}
{{Line|julienw|let's do 9}}
{{Line|azasypkin|ok}}
{{Line|julienw|(as always, I take note and I'll write the result on the bugs + wiki after)}}
{{Line|julienw|let's estimate these 6 bugs already ?}}
{{Line|julienw|do you need time to look at them ?}}
{{Line|azasypkin|yeah, I don't know much about 1015867 and 990537}}
{{Line|julienw|ok}}
{{Line|julienw|let's take 5 minutes to look at the bug}}
{{Line|julienw|s}}
{{Line|schung|for 1015867, maybe we should create a follow up to keep everything moving?}}
{{Line|julienw|I want to look at the issue first, didn't have the time yesterday}}
{{Line|julienw|but otherwise yeah, maybe}}
{{Line|julienw|azasypkin, 1015867:  the issue is that the composer had a fixed max height since we landed the flexible layout composer}}
{{Line|julienw|azasypkin, it turned out that a lot of things were not really made properly (for example, the send button used position: fixed)}}
{{Line|julienw|azasypkin, so the patch changes many things here (more than I expected at the start actually)}}
{{Line|julienw|schung, not being able to click on the subject is a no-go for me, that's why I want to look at it first :)}}
{{Line|julienw|bug 990537: there is a patch but probably will need to be redone once the "send button" change is done}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}990537 nor, --, 2.0 S3 (6june), felash, ASSI, [DSDS] Messaging. Apply Visual Refresh to DSDS scenarios.}}
{{Line|julienw|fortunately, the "sms simulator" branch helps a lot to do this}}
{{Line|azasypkin|julienw, ok, thanks, I see that patch for bug 1015867 in review (and ui-review) already, that's good}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1015867 nor, --, 2.0 S3 (6june), felash, ASSI, [Messages] The editable composer should take more space}}
{{Line|julienw|yep}}
{{Line|schung|julienw: I think landing 1008127 (subject) ->  1013296   ->  990537(DSDS) is reasonable}}
{{Line|julienw|you forget the "editable space" at first :)}}
{{Line|schung|oh ya}}
{{Line|julienw|1015867 (max height) ->  1008127 (subject) ->  1013296  (send button) ->  990537(DSDS)}}
{{Line|azasypkin|so, will all these prerequisite bugs be resolve in this sprint? Just wondering if can include the last one in this sprint}}
{{Line|julienw|yep maybe not}}
{{Line|julienw|let's keep DSDS out of the sprint}}
{{Line|azasypkin|ok, then the rest is clear for me, ready to estimate}}
{{Line|julienw|(btw, I notice we have no demo for the thread refresh)}}
{{Line|julienw|schung, good for you, keeping DSDS out of this sprint?}}
{{Line|azasypkin|yeah, my fault, doing it right now}}
{{Line|julienw|I should add a part for the simulator too}}
{{Line|schung|julienw: ok for me without DSDS in the sprint}}
{{Line|julienw|oki}}
{{Line|julienw|let's estimate the bugs then}}
{{Line|julienw|bug  1015867 (max height for composer) ?}}
{{Line|azasypkin|since we have patch already, maybe 1 is enough?}}
{{Line|julienw|p{{=}}1 for me, because patch is ready, only one issue is remaining, and we can file follow up for the smaller issue if Victoria wants it}}
{{Line|azasypkin|agree}}
{{Line|schung|+1}}
{{Line|julienw|ok}}
{{Line|julienw|subject patch: bug 1008127}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1008127 nor, --, 2.0 S3 (6june), pivanov, ASSI, [Messages][Refresh] Subject handling in the Composer}}
{{Line|julienw|azasypkin, what's the status of this ?}}
{{Line|azasypkin|Pavel updated patch once again, but as per his last comment looks like we need to talk one more time}}
{{Line|azasypkin|bug is easy, and I'd say 1, but as Pavel is outside the team 2 will be safer}}
{{Line|julienw|yep}}
{{Line|julienw|p{{=}}2 for me too}}
{{Line|schung|2 for communication efforts}}
{{Line|julienw|oki}}
{{Line|julienw|bug 1013296: send button}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1013296 nor, --, 2.0 S4 (20june), arnau, ASSI, Compose. Change send button to an paper plane icon}}
{{Line|azasypkin|p{{=}}1}}
{{Line|julienw|same for me}}
{{Line|schung|2 because it will need some adjustment when 1013296  landed...}}
{{Line|schung|sorry 1008127}}
{{Line|julienw|yeah but would the adjustments be more than 1 point ?}}
{{Line|julienw|especially that it's making it flexible, so no need to adjust the margin anymore}}
{{Line|schung|Another reason is Arnau outside the team for same reason}}
{{Line|schung|But arnau is here right now :p Maybe let him estimates?}}
{{Line|julienw|he he}}
{{Line|julienw|p{{=}}2 seems a lot to me but if there is uncertainty then maybe we should}}
{{Line|julienw|arnau, ping ?}}
{{Line|julienw|ok}}
{{Line|julienw|arnau is not here}}
{{Line|julienw|:)}}
{{Line|julienw|so}}
{{Line|julienw|let me try otherwise}}
{{Line|julienw|should bug 1013296 be the same than bug 1008127 ?}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1008127 nor, --, 2.0 S3 (6june), pivanov, ASSI, [Messages][Refresh] Subject handling in the Composer}}
{{Line|julienw|to me it's really not the same complexity}}
{{Line|schung|hmm I agree, just not sure how long it will take after landing 1008127 and avoid the DSDS regression}}
{{Line|julienw|we don't really care about DSDS that's already regressed}}
{{Line|julienw|:p}}
{{Line|julienw|so}}
{{Line|julienw|p{{=}}1 or p{{=}}2 ? :)}}
{{Line|azasypkin|I still would go with 1}}
{{Line|julienw|me too}}
{{Line|julienw|but if steve thinks p{{=}}2 is better, then we should be cautious and use it}}
{{Line|schung|If we don't care about the regression, that would be 1}}
{{Line|julienw|yay}}
{{Line|julienw|:o)}}
{{Line|julienw|yeah, in my head, the dsds bug would do what's needed}}
{{Line|julienw|ok then}}
{{Line|julienw|next is}}
{{Line|julienw|bug 1012663 for security team}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1012663 nor, --, ---, nobody, NEW, [SMS] Remove inline style for CSP compliance}}
{{Line|julienw|there are 2 options}}
{{Line|julienw|1) do a quick&dirty patch to unblock the security team + follow up to change background image to <img>}}
{{Line|julienw|2) do the background to <img> change now}}
{{Line|julienw|I'd do 1) because the <img> change is not really important now}}
{{Line|julienw|(unless it's really simpler)}}
{{Line|julienw|what do you think ?}}
{{Line|schung|julienw: I think we have a distort issue with img tag before?}}
{{Line|julienw|schung, the idea is to load the image out of the DOM, set width/height, and only then append it to the dom}}
{{Line|julienw|or something like this}}
{{Line|julienw|since we need to load the image anyway}}
{{Line|schung|julienw: so you prefer to set css styling from js directly?}}
{{Line|julienw|we need to :(}}
{{Line|julienw|you mean, instead of using the template ?}}
{{Line|schung|julienw: no, we still use template, and set styling after element create from template}}
{{Line|julienw|yes that's what we need to do for CSP}}
{{Line|julienw|super ugly}}
{{Line|julienw|si}}
{{Line|julienw|so}}
{{Line|julienw|which option do you think ?}}
{{Line|azasypkin|ok, in case of images maybe we'll use img instead in the follow-up, but for last case we'll need js anyway, right ? https://github.com/mozilla-b2g/gaia/blob/83e6c16dceec422f254c9c966ce6948e849759e6/apps/sms/index.html#L523-L525}}
{{Line|azasypkin|or separate stylesheet}}
{{Line|julienw|I was thinking oa separate styleheet}}
{{Line|julienw|I was thinking of a separate stylesheet}}
{{Line|arnau|hey guys, I'm here, sorry I was late}}
{{Line|julienw|no pb, we found an agreement :)}}
{{Line|julienw|azasypkin, schung : so, option 1 ?}}
{{Line|julienw|(need to move forward ;) )}}
{{Line|azasypkin|julienw, ok for CSP, I don't mind to use js to set background-url as temp solution, it's p{{=}}1 I think}}
{{Line|schung|p{{=}}1 for just set styling in js and create follow up}}
{{Line|julienw|oki}}
{{Line|julienw|bug 925404 then}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}925404 nor, --, ---, azasypkin, ASSI, [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known}}
{{Line|julienw|azasypkin, maybe you can give a quick status ?}}
{{Line|azasypkin|I was working on it previous week, so I'd go with p{{=}}1}}
{{Line|azasypkin|I have patch, it needs some adjustments + go through all not mentioned cases}}
{{Line|julienw|is the spec clear ?}}
{{Line|azasypkin|spec is not :) But I've confirmed all mentioned cases with Vicky at WW}}
{{Line|julienw|oki}}
{{Line|julienw|I'd still go with p{{=}}2}}
{{Line|julienw|counting review, etc}}
{{Line|schung|hmm p{{=}}2 for me}}
{{Line|azasypkin|ok, since you're guys will review that I don't mind to give it p{{=}}2 :p}}
{{Line|julienw|oki}}
{{Line|julienw|we have 2 points left}}
{{Line|julienw|blockers !}}
{{Line|schung|all the blockers or 2.0+ only?}}
{{Line|julienw|nope}}
{{Line|julienw|bug 1016897 is 1.4+}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1016897 nor, --, ---, schung, NEW, [Flame][v1.4][Message]Tap new message icon, it will automatically return SMS  which is just saved as}}
{{Line|julienw|to me it's p{{=}}1}}
{{Line|schung|p{{=}}1}}
{{Line|azasypkin|p{{=}}1}}
{{Line|julienw|oki}}
{{Line|julienw|next most important is bug 994553 IMO}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}994553 nor, P1, ---, nobody, NEW, [Sora][Message][Contacts]Contacts's head portrait do not display  in Message}}
{{Line|julienw|issue is that we revoke the blob url too soon}}
{{Line|julienw|there are 2 possibilities:}}
{{Line|julienw|* revoke it after eg 60 seconds, but we might have the issue again for threads that are down the list, if the CSS guys optimize the rendering}}
{{Line|julienw|* revoke it when the thread is deleted only (should not be a big deal if the blob comes from a indexeddb, because it takes not much memory)}}
{{Line|julienw|* switch to images instead of background images (sound familiar ? ;) )}}
{{Line|julienw|(ok, 3 possibilities)}}
{{Line|julienw|my preference is 2) here}}
{{Line|schung|2 for me too}}
{{Line|azasypkin|is img tag that bad that we don't want to use it?}}
{{Line|julienw|my idea was to put the blob url in a dataset, so that it's easy to get when we delete the node; or keep it in an internal array ?}}
{{Line|julienw|(for when we clear the whole thing)}}
{{Line|julienw|azasypkin, in that case, the contact image is more a style than content}}
{{Line|julienw|(to me)}}
{{Line|julienw|but we can argue otherwise}}
{{Line|julienw|tell me what you think}}
{{Line|azasypkin|mmmm don't have strong opinion on that, img tag looks fine for me in this case, but above schung mentioned possible issue with img tag, is it still the case?}}
{{Line|julienw|in this case it would be}}
{{Line|julienw|the problem with img is that it doesn't respect ratio}}
{{Line|julienw|you need to set the width/height yourself}}
{{Line|julienw|maybe we can take another bug though, this one is maybe too big for this sprint}}
{{Line|azasypkin|yes I think in any case it can take more than p{{=}}1}}
{{Line|julienw|yep}}
{{Line|julienw|I'm also wonderint about bug 925404}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}925404 nor, --, ---, azasypkin, ASSI, [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known}}
{{Line|julienw|is it more importnat the blockers ?}}
{{Line|julienw|maybe bug 1021788 for this sprint instead ?}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1021788 nor, --, ---, schung, NEW, [Messages] Can't click on the suggestion list when there are a lot of recipients in the recipients p}}
{{Line|julienw|will be a blocker for sure}}
{{Line|azasypkin|mm no I think, it's more minor VR vs blocker}}
{{Line|schung|both 1 or 2 is fine for me (bug 972245) maybe 2 is safer}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}972245 nor, --, ---, schung, VERI FIXED, Photos can appear distorted in the call log and in the SMS app}}
{{Line|julienw|bug 1022644 too}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}1022644 nor, --, ---, nobody, NEW, [Messages] Can't open the recipient panel if there are only 2 lines of recipients}}
{{Line|julienw|schung, you mean for bug 994553 ?}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}994553 nor, P1, ---, nobody, NEW, [Sora][Message][Contacts]Contacts's head portrait do not display  in Message}}
{{Line|schung|sorry wrong paste again bug 994553}}
{{Line|schung|just found the img issue we mentioned}}
{{Line|julienw|I'd even say p{{=}}3 for this one}}
{{Line|azasypkin|so we can take this one instead of 925404}}
{{Line|julienw|if we remove bug 925404, we have enough for bug 994553}}
{{Line|julienw|yep}}
{{Line|julienw|is it good for you schung ?}}
* Rik|afk s'appelle maintenant Rik_
{{Line|schung|julienw: hmm, if we just store url in dataset and revoke while deletion, is that need more than 2?}}
{{Line|julienw|is there a case where we delete everything ?}}
{{Line|julienw|or maybe not anymore ?}}
{{Line|julienw|I'm only afraid of the cases we forget :)}}
{{Line|julienw|but maybe p{{=}}2 is enough for this}}
{{Line|julienw|ok, let's do p{{=}}2}}
{{Line|julienw|and remove bug 925404}}
{{Line|julienw|and would bug 1022644 work for p{{=}}1?}}
{{Line|julienw|schung, azasypkin  :)}}
{{Line|azasypkin|I think so, I can take it, as 925404 is out of sprint now :)}}
{{Line|schung|I can not reproduce it if we create new multi-recipient first}}
{{Line|julienw|maybe it's the issue with draft that you said?}}
{{Line|julienw|ok it's probably more p{{=}}2 if we need to investigate ,right ?}}
{{Line|schung|yes, so we might need some time to investigate}}
{{Line|azasypkin|mm, if it's not clear then it's not p{{=}}1 :)}}
{{Line|julienw|yeah}}
{{Line|julienw|we can also stop at velocity {{=}} 8}}
{{Line|julienw|and if there are some spaces at the end, you'll know where to take bugs anyway}}
{{Line|julienw|I can put p{{=}}2 on the bug but we don't take it}}
{{Line|azasypkin|sounds good}}
{{Line|schung|I think  1021788 is also a block in the end should we estimate it?}}
{{Line|julienw|since it's not in the sprint, we don't need to estimate}}
{{Line|julienw|:)}}
{{Line|schung|ok}}
{{Line|julienw|we'll estimate next time}}
{{Line|julienw|sprint: https://bugzilla.mozilla.org/showdependencytree.cgi?id{{=}}1022706&hide_resolved{{=}}1}}
{{Line|julienw|feels good ?}}
{{Line|azasypkin|is that dependency bug 817674 non-blocking for us?}}
{{Line|firebot|Bug https://bugzilla.mozilla.org/show_bug.cgi?id{{=}}817674 nor, --, ---, lissyx+mozillians, ASSI, Add new Makefile target (checkcsp) to verify CSP compliance}}
{{Line|julienw|no, I don't think so}}
{{Line|azasypkin|ok}}
{{Line|azasypkin|then why it's dependency and not just related for example :) }}
{{Line|julienw|yeah I'll check this, I think it's been added by mistake}}