View source for Firefox/Meeting/23-May-2017

= Actions from last meeting =
* Select a new meeting leader for June 6th meeting.
* Today’s meeting leader is: '''mconley'''
* Next meeting leader is: '''kitcambridge'''

= General Topics / Roundtable =
(tips/tricks/FYI, productivity improvements, industry news)
* [MattN] [https://bugzilla.mozilla.org/show_bug.cgi?id=1348031 Startup profiling now supports sub-millisecond intervals] thanks to :kmag!
* [MattN] [https://bugzilla.mozilla.org/show_bug.cgi?id=1364157 Non-e10s talos is no longer run]
* [mconley] Element.focus() causes layout flushes, and should be used sparingly. We should definitely avoid calling it multiple times in the same tick of the event loop.

= Friends of the Firefox team =
(Give a shoutout/thanks to people for helping fix and test bugs. Introductions)
* Resolved bugs (excluding employees):
** More than one bug fixed: [https://mzl.la/2rwO12P https://mzl.la/2rwO12P]
*** Dan Banner
*** Kevin Jones
*** Milind L (:milindl)
*** Swapnesh Kumar Sahoo [:swapneshks]
*** tfe
** New contributors (🌟 = First Patch!)
*** 🌟 jomer14 got rid of some leftover l10n files that Firefox Accounts didn’t need anymore!
*** 🌟 Pauline got rid of PlacesUtils.asyncGetBookmarkIds (which isn’t needed anymore thanks to Bookmarks.jsm), which also [https://bugzilla.mozilla.org/show_bug.cgi?id=1157709#c29 reduced our memory footprint]!
*** 🌟 Shashwat Jolly cleaned up some of our strings in about:license!

= Project Updates =

== Add-ons ==
* No updates this week.

== Activity Stream ==
* ‘Graduation’ team is getting close to preffing on Activity Stream in Nightly and working on Search Suggestions, about:home, cleaning up tests, and perf telemetry
** Aiming for more regular / weekly landings from github to mozilla-central
** Replaced custom React search suggestions from Test Pilot with  [https://github.com/mozilla/activity-stream/pull/2611 existing contentSearchUI] used for about:home/about:newtab simplifying tests
* Test Pilot team is finishing up customization (drag’n’drop, [https://github.com/mozilla/activity-stream/pull/2595 add/edit topsite]), as well as beginning work on Sections
* Activity Stream, when enabled on m-c [https://bugzilla.mozilla.org/show_bug.cgi?id=1365643 runs in the content process]!
* Removed most of Content Services / Suggested Tiles code from about:newtab resulting in [https://bugzilla.mozilla.org/show_bug.cgi?id=1241390#c19 perf improvements] and [https://bugzilla.mozilla.org/showdependencytree.cgi?id=1241390&maxdepth=1&hide_resolved=0 removed] / [https://bugzilla.mozilla.org/show_bug.cgi?id=1338848#c28 ~8x fewer] intermittent test failures

== Electrolysis (e10s) ==
* The e10s-multi team is still looking over the data being gathered from the Beta population against [https://wiki.mozilla.org/Electrolysis/Multi_Release_Criteria the release criteria] to determine whether or not e10s-multi will ship in Firefox 54, or will have to wait until Firefox 55
* e10s-a11y support in Firefox 55 has been marked “at risk” due to stability issues. A go/no-go will be happen no later than June 3rd
* erahm [http://www.erahm.org/2017/05/15/firefox-memory-usage-with-multiple-content-processes/ has a blog post] about how memory usage with 4 content processes continues to be the sweet spot

== [https://wiki.mozilla.org/Firefox_Core_Engineering Firefox Core Engineering] ==
* We’re [https://bugzilla.mozilla.org/show_bug.cgi?id=1365998 officially shipping the streamlined stub installer] in 55 (this is Windows only). You can see it as of tomorrow’s Nightly.
* Reminder: 55 is also installing 64bit by default on 64bit OS; updates come later.
* Resolved [https://bugzilla.mozilla.org/show_bug.cgi?id=1358151 race condition in Rust runtime]. This may have been bugging some tests (no pun intended).
* We have preliminary top crashers lists from crash stacks sent via crash pings. Expanding that analysis is pending review of the data &amp; correlation with crash reports.
* Just started week 3 of the Flash Shield Study. Preliminary results: Flash usage is reduced by 75%
* Flash is CTP by default on [https://bugzilla.mozilla.org/show_bug.cgi?id=1317856 Nightly], and on track to [https://bugzilla.mozilla.org/show_bug.cgi?id=1365714 Release 55].

== [https://wiki.mozilla.org/Firefox/Features/Form_Autofill Form Autofill] ==
* [https://blog.nightly.mozilla.org/2017/05/23/preview-form-autofill-in-firefox-nightly/ Form Autofill is enabled-by-default in Nightly]! Give it a try by manually creating an address profile in preferences. ([https://twitter.com/mnoorenberghe/status/867026565720408064 tweet]) 💰
* Lots of focus was on a linux64 Talos startup regression which is now resolved by making various pieces of autofill initialization lazier. This slowed down other landings in order to not add other noise.
* Resolved
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1361560 Enable Form Autofill by default on Nightly]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1364334 Rename formautofill preference prefix and address pref suffix]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1340488 Add a chrome-only API to preview the option to be auto-selected in a select]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1362937 [Form Autofill] autofill's autocomplete popup filtering is broken]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1340477 Support feature detection on autocomplete attribute]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1359978 [Form Autofill] Implement the credit-card storage]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1365150 profileStorage.get should return null instead of throwing, and .add should return the newly created guid.]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1365143 Add SchemaVersion for each record in ProfileStorage]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1359355 [Form Autofill] Dismiss preview highlight if the filled &gt; fields is being changed]
* In Progress
** [https://bugzilla.mozilla.org/show_bug.cgi?id=990219 [Form Autofill] Auto-create new profiles based off submitted form data]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1300996 Show a preview of what would be filled when a form autofill autocomplete result is highlighted]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1303510 [Form Autofill] Prompt a door hanger to notify users that &gt; profile has been saved when users submit a new form for the first time]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1349490 Implement the first version of heuristic algorithm.]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1360370 Field Prediction Heuristics for select &gt; element.]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1361242 Implement &quot;Prefer&quot; operation for Sync engine.]
** …and more

== Lint ==
* The [https://blog.mozilla.org/standard8/2017/05/04/running-eslint-on-commit-for-mozilla-central-git-mercurial/ previously mentioned hooks for ESLint] will now automatically update ESLint’s setup if needed.
* The mozilla/recommended configuration is now default for the whole tree. Directories which don’t use all the rules are whitelisted. We’ll work towards reducing those.
* There’s been more improvements for using eslint-plugin-mozilla outside of mozilla-central, and it is now being used by various github based repositories including screenshots, activity stream, pdfjs

== Photon ==
[https://dolske.wordpress.com/2017/05/18/photon-engineering-newsletter-1/ Photon Engineering Newsletter #1] out last week, #2 coming later today.

=== Performance ===
* [mconley] More rigorous reflow tests have landed for window opening, tab opening and tab closing.
** More tests coming up for [https://bugzilla.mozilla.org/show_bug.cgi?id=1363505 windows and tabs], and the [https://bugzilla.mozilla.org/show_bug.cgi?id=1363507 AwesomeBar]
* [mconley] Kudos to the Structure / Menus team for making the subview animations [http://imgur.com/HB8HmAn smooth as silk]! (Notice that Oh no! Reflow! is detecting no synchronous reflows in that video)
* [mconley] [https://air.mozilla.org/the-joy-of-profiling-episode-1-20170519/ The Joy of Profiling - Episode 1]. [https://docs.google.com/a/mozilla.com/forms/d/e/1FAIpQLSePiq1ifvrY6EzDowEdqKdb-tGGm-AvgG86ivU9ipv7FsggKQ/viewform Submit Gecko Profiler profiles here.]
** Also see [https://air.mozilla.org/gecko-and-native-profiler/ ehsan’s recording for “Gecko And Native Profiler” talk]
* Task.jsm and Promise.defer() removal big patches landed as pre-announced during the last meeting. This covered the browser/ and toolkit/ folders, more patches coming soon for other folders.

=== Structure ===
* The page action menu has started taking shape and now has items to copy/email links, and will soon have a ‘send to device’ submenu;
* Tomorrow’s nightly will have Firefox Account and cut/copy/paste items in the main hamburger panel;
* Main work on the permanent overflow panel (as a replacement for the customizable bits of the existing hamburger panel) is done, working on polish and bugfixes;
* Work will start on the new library button this week;
* We’ll be working to flip the photon pref by default on Nightly in the next week or two;

=== Animation ===
* Patches going through review for [https://bugzilla.mozilla.org/show_bug.cgi?id=1352065 download animation] and [https://bugzilla.mozilla.org/show_bug.cgi?id=1355925 refresh/stop] animations.
* Working on getting [https://bugzilla.mozilla.org/show_bug.cgi?id=1352127 toolbarbutton icons to scale up on press]
* A patch to [https://bugzilla.mozilla.org/show_bug.cgi?id=1364221 run more of our animations on the compositor] bounced but should get landed again today.

=== Visuals ===
* Dao [https://bugzilla.mozilla.org/show_bug.cgi?id=1363840 detached the back, forward and reload/stop buttons from the urlbar].
* Dale implemented the [https://bugzilla.mozilla.org/show_bug.cgi?id=1352366 new location and search bar design]
* Nihanth implemented the [https://bugzilla.mozilla.org/show_bug.cgi?id=1363842 new toolbar button hover and active background styles]
* Nihanth also[https://bugzilla.mozilla.org/show_bug.cgi?id=1363869 increased the vertical padding of the toolbar buttons]
* Nihanth further [https://bugzilla.mozilla.org/show_bug.cgi?id=1365195 implemented the new back button design].
* Johann[https://bugzilla.mozilla.org/show_bug.cgi?id=1352358 is working on compact and touch modes.]
* And lots of small regression fixes.

=== Onboarding ===
* The Automation workflow-correct scerencast[http://g.recordit.co/DdA6RDBlrF.gif][http://g.recordit.co/DdA6RDBlrF.gif http://g.recordit.co/DdA6RDBlrF.gif] [http://bugzil.la/1361286 http://bugzil.la/1361286]
** [http://g.recordit.co/DdA6RDBlrF.gif UX spec for Activity Stream is in progress]
** The UI part will be done separately in Activity Stream
* Skeleton of onboarding overlay system add-on is under review with Mossop. [http://bugzil.la/1357005 http://bugzil.la/1357005]
** This is a skeleton without tours. Tours will be landed in follow-up bugs.
** Workflow-correct screencast : [http://g.recordit.co/hzMSeS5EoE.gif http://g.recordit.co/hzMSeS5EoE.gif]
* Under discussion about onboarding tour’s update between different versions.

=== Preferences ===
* Search is taking shape on Nightly! It now comes with [https://bugzilla.mozilla.org/show_bug.cgi?id=1360500 the right highlight color], tooltips for [https://bugzilla.mozilla.org/show_bug.cgi?id=1352481 sub-dialog search results]. With the help from QA engineers, we are closing the gap between implementation &amp; spec.
* UX team asked us to [https://bugzilla.mozilla.org/show_bug.cgi?id=1365133 revise re-org]. The change will likely postpone re-org shipping by one release (to 56); the good news is the release population will be presented with the new search &amp; re-org at the same time, if that happens.

== Platform Audibles ==
* No updates this week.

== Privacy/Security ==
* Mostly Containers work, see Test Pilot update.

== Project Mortar (PDFium) ==
* :peterv made some progress of the [https://bugzilla.mozilla.org/show_bug.cgi?id=558184 JSPlugin architecture] - the last few pieces of work are reviewing. Hopefully this is the final round of review, and we will land all of them (8 patches!) soon.

== [https://wiki.mozilla.org/Firefox/Search Search] ==
* One-off buttons in the location bar [https://bugzilla.mozilla.org/show_bug.cgi?id=1303781 are] [https://bugzilla.mozilla.org/show_bug.cgi?id=1344929 ready] to ride the trains in 55.
* Search suggestions [https://bugzilla.mozilla.org/show_bug.cgi?id=1280441 are] [https://bugzilla.mozilla.org/show_bug.cgi?id=1344924 now] [https://bugzilla.mozilla.org/show_bug.cgi?id=1344928 enabled] by default. Users who had explicitly opted out of search suggestions in the past, will not see them.
* Hi-res favicon improvements: the default globe favicon is [https://bugzilla.mozilla.org/show_bug.cgi?id=1360891 now] hi-res (SVG) everywhere in the UI and some ugly icon rescaling was [https://bugzilla.mozilla.org/show_bug.cgi?id=1362394 fixed].

== Sync / Firefox Accounts ==
* Form autofill sync engine in progress. Sync team working with :MattN, :seanlee, and :lchang on profile reconciliation: [https://bugzilla.mozilla.org/show_bug.cgi?id=1361242 https://bugzilla.mozilla.org/show_bug.cgi?id=1361242], [https://bugzilla.mozilla.org/show_bug.cgi?id=1363995 https://bugzilla.mozilla.org/show_bug.cgi?id=1363995]
* New sync engine checkboxes for autofill profiles and CC data: [https://bugzilla.mozilla.org/show_bug.cgi?id=1361285 https://bugzilla.mozilla.org/show_bug.cgi?id=1361285] :juwei working on opt-in UX: [https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/185446463 https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/185446463]
* Removing nested event loops from Sync: [https://bugzilla.mozilla.org/show_bug.cgi?id=1210296 https://bugzilla.mozilla.org/show_bug.cgi?id=1210296]

== [https://wiki.mozilla.org/Test_Pilot Test Pilot] ==
* [https://testpilot.firefox.com/experiments/containers Containers experiment] release 2.3.0 coming this week
** adds a “site assignment” on-boarding panel to increase site assignments
** removes SDK code
* Screenshots: aiming for 55
** Hoping WebExtensions will be performant enough by 55
** Backup plan: move UI (toolbar button, context menu item) into bootstrap code, lazy-load WebExtension on click.
*** Currently in progress
* We’re [https://discourse.mozilla-community.org/t/test-pilot-blog/15707/2 planning] to start a Test Pilot blog (with help from Marketing)
* Test Pilot and experiments are moving away from the SDK
** Looking into replacing Test Pilot addon functionality with a &gt; WebExtension API Experiment ([https://discourse.mozilla-community.org/t/discussion-notes-migrating-away-from-the-sdk/15670 learn &gt; more])

= This week I learned =
* async/await &amp; promise can still jank. Use requestIdleTimeout instead(?)<br />
[https://groups.google.com/forum/#!topic/mozilla.dev.platform/A6aRmSgExb0 https://groups.google.com/forum/#!topic/mozilla.dev.platform/A6aRmSgExb0] (thread by Mark Hammond)