View source for Firefox/Meeting/27-Feb-2018

Today’s meeting leader is: '''mconley'''

= General Topics / Roundtable =

* [mconley] Introducing [https://developer.mozilla.org/en-US/Firefox/Performance_best_practices_for_Firefox_fe_engineers ''window.promiseDocumentFlushed!''] This is a more reliable way of having JS run just after the refresh driver tick when we know that style and layout information is cheap to get. See [https://developer.mozilla.org/en-US/Firefox/Performance_best_practices_for_Firefox_fe_engineers ''this document for examples''] on how to use it, [https://hg.mozilla.org/mozilla-central/file/fccbba9cb959/dom/base/test/browser_promiseDocumentFlushed.js ''or check out the tests.'']
* [bgrins] Incoming &lt;tabbrowser&gt; changes. In [https://bugzilla.mozilla.org/show_bug.cgi?id=1392352 ''Bug 1392352''] we will rewrite the tabbrowser implementation out of XBL and into a JS class. Once this lands:
** You shouldn’t have to change (almost) any code that accesses `gBrowser`.
** There will still be a XBL binding, but just for &lt;content&gt; and to initialize this class in the &lt;constructor&gt;.
** Any in-flight patches touching the tabbrowser binding will need to be rebased away from tabbrowser.xml and to tabbrowser.js (sorry).
** `gBrowser` will no longer be a reference to a DOM node, but a plain JS object. If you need access to the &lt;tabbrowser&gt; node, you can still get to it via `gBrowser.container`. For some examples, [https://reviewboard.mozilla.org/r/220686/diff/5#index_header ''see the patch''] that migrates away from the XBL binding.
* [mconley] Don’t forget about --try-test-paths and test-verify-e10s
** Example
*** try: -b do -p linux64 -u mochitest-e10s-bc,test-verify-e10s -t none<br />
--try-test-paths browser-chrome:browser/base/content/test/performance<br />
--artifact<br />


= Friends of the Firefox team =

(Give a shoutout/thanks to people for helping fix and test bugs. Introductions)

* Introductions
** Anthony Liddle - owner of Pocket Extension (anthony on Slack)
* Resolved bugs (excluding employees): [https://mzl.la/2F5TXXk ''https://mzl.la/2F5TXXk''] 
** More than one bug fixed: 
*** :prathiksha
*** Arthur Edelstein [:arthuredelstein]
*** Oriol Brufau [:Oriol]
*** Richard Marti (:Paenglab)
*** Tim Nguyen :ntim
** New contributors (🌟 = First Patch!) 
*** 🌟 Apoorv Goel [https://bugzilla.mozilla.org/show_bug.cgi?id=1436717 ''made it so that about:telemetry uses the new Symbol Server'']
*** 🌟 Connor Masini [https://bugzilla.mozilla.org/show_bug.cgi?id=1417880 ''made it so that WebExtensions can theme arrow panels''] 🚀
**** [https://mail.mozilla.org/pipermail/firefox-dev/2018-February/006132.html ''Dark Theme Darkening 🌘 update #3''] was sent to firefox-dev

= Project Updates =

== Add-ons ==

(ddurst has no voice: read-only)

* [https://bugzilla.mozilla.org/show_bug.cgi?id=1429590 ''Only one homepage can be set by extensions''], in 60
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1436165 ''Clearer messages''] for when an extension is controlling New Tab and Home pages, in 60
* Buncha [https://bugzilla.mozilla.org/show_bug.cgi?id=1393940 ''test fixes''], notably chasing down [https://bugzilla.mozilla.org/show_bug.cgi?id=1435100 ''NS_ERROR_FILE_ACCESS_DENIED''], fixed in 59
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1311171 ''devtools.network.onRequestFinished implemented''], mostly useful for DevTools extensions, in 60
* removed [https://bugzilla.mozilla.org/show_bug.cgi?id=1431242 ''some innerHTML''] (and fixed some bolding broken by sanitization in [https://bugzilla.mozilla.org/show_bug.cgi?id=1432966 ''1432966'']), in 59
* ...and [https://bugzilla.mozilla.org/show_bug.cgi?id=1434976 ''some more''] (in dynamic install prompt messages), in 60
* Fixed [https://bugzilla.mozilla.org/show_bug.cgi?id=1436100 ''a regression on WebExtension themes''] in Thunderbird, in 60
* Helped out with reducing FOUC by [https://bugzilla.mozilla.org/show_bug.cgi?id=1437921 ''running document_idle after DOMContentLoaded and after layout has had a chance to start''], in 60
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1417880 ''Theming of arrow panels'']! in 60
* Fixed browser and page actions [https://bugzilla.mozilla.org/show_bug.cgi?id=1438274 ''cleared when navigating''], in 59
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1437178 ''Fixed pageAction visibility error''] (conflict between show_matches and hide_matches), in 59
* Opening a popup now [https://bugzilla.mozilla.org/show_bug.cgi?id=1324255 ''gets focus''], in 60
* Hidden tabs [https://bugzilla.mozilla.org/show_bug.cgi?id=1436720 ''are restored when the extension that hid them is removed''], in 60 -- didn’t make 59, though :(
* (sorry)

== Activity Stream ==
* Added [https://github.com/mozilla/activity-stream/pull/3987 ''section context menus''] allowing for more in-page customizations: [https://bugzilla.mozilla.org/show_bug.cgi?id=1433212 ''reordering'']
** [[File:Pictures/10000201000008400000018E9E86D0B2.png|602x113px]]
* Highlights include “[https://github.com/mozilla/activity-stream/pull/3975 ''Saved to Pocket'']” cards with more caching heuristics incoming
* Reevaluating approach for about:preferences move to incorporate Fluent

== [https://mozilla.github.io/firefox-browser-architecture/ ''Browser Architecture''] ==

* Investigating [https://docs.google.com/document/d/1z0l9ZY-4GTX69qyNJ5Y9VeVuYrxFS6AoHQ1IXsbnB0c/edit ''XULStore alternatives''].
* Proposing [https://docs.google.com/document/d/1eK6OMXqFx8JHUfvpUOi0EhyHbUSwLcUEe9Uz_NlmgNU/edit ''using Node as part of the Firefox build''].
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1392352 ''Migrating &lt;tabbrowser&gt; to a JS class''].
* Sync and Storage folks are holding weekly show and tells for their cross-platform syncing code, ping Emily Toop if you’re interested.
* Continued progress on removing XBL bindings and XUL overlays.
** [https://bgrins.github.io/xbl-analysis/graph/ ''https://bgrins.github.io/xbl-analysis/graph/'']

== [https://firefox-source-docs.mozilla.org/tools/lint/index.html ''Lint''] ==
* Working on rolling out more Cc/Ci/Cr/Cu [https://bugzilla.mozilla.org/show_bug.cgi?id=1440379 ''fixes to the rules''] &amp; [https://bugzilla.mozilla.org/show_bug.cgi?id=1433175 ''spread the coverage''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1436303 ''of the rules''] out further.
* Rolling out [https://bugzilla.mozilla.org/show_bug.cgi?id=1440761 ''no-unused-vars''] for the global scope (as well as the existing local checks) in *.jsm files ([https://bugzilla.mozilla.org/show_bug.cgi?id=1434446 ''meta'']).
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1439949 ''ESlint bumped to 4.18.1''], includes support for “ecmaVersion: 2018”, especially [https://github.com/tc39/proposal-async-iteration ''async iteration''] (for-await-of)

== Policy Engine ==
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1433136 ''Bug 1433136''] - GPO support landed!
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1438243 ''Bug 1438243''] - UI improvements to blocked page
* Policies
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1428924 ''Bug 1428924''] - Bookmarks
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1429185 ''Bug 1429185''] - Block Devtools
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1432355 ''Bug 1432355''] - Block Private Browsing - Will land today
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1429148 ''Bug 1429148''] - Don’t Remember passwords, Disable Master Password
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1429186 ''Bug 1429186''] - Homepage setting and locking

== Performance ==
* [mconley]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1432509 ''Tab warming short-spinner bug has been fixed'']
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1423220 ''Will enable by default on Nightly starting early in next cycle'']
* [florian]
** The address bar is now [https://bugzilla.mozilla.org/show_bug.cgi?id=1403648 ''focused before first paint''], to avoid flicker
** There are Talos profiles generated automatically for each nightly build, look for [https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=T-P-e10S ''T-P-e10s job on treeherder''].
* Doug Thayer fixed [https://bugzilla.mozilla.org/show_bug.cgi?id=1398845 ''a 1-frame, eye-straining flash''] that was occurring on macOS when clicking on a link in Activity Stream
* Gijs has been reducing blocklist sizes, and is working on making accessing the blocklist lazier
* paolo has been refactoring PanelMultiView to make it less buggy, removes an XBL binding, and in preparation for removing a sync layout flush

== Platform Audibles ==
* None today!

== Privacy/Security ==
* Heads up: We are currently testing [https://bugzilla.mozilla.org/show_bug.cgi?id=1435733 ''upgrading mixed passive content''] on Nightly. This will probably break images on some sites. [https://groups.google.com/forum/#!topic/mozilla.dev.platform/xjZQq0kEauM ''See the dev-platform post for more info.'']
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1422160 ''Some''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1431029 ''larger''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1432743 ''UI changes''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1432745 ''to about:preferences''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1421737 ''landed''] last week, combining cookies, site data and cache into a single section. [https://docs.google.com/presentation/d/13b3cz4_R-zWAk2EpbSZefs8wHm1xMSdPjrx4QYYoo5w/edit#slide=id.p ''User Study''] [Mozilla Confidential]
* Related to that, the tiny “Clear Recent History” link in about:preferences [https://bugzilla.mozilla.org/show_bug.cgi?id=1436568 ''is now a nice regular button''].
* We’re no longer showing the (admittedly quite annoying) canvas permission prompt [https://bugzilla.mozilla.org/show_bug.cgi?id=1376865 ''unless the canvas data was accessed from a user interaction''].
* We are looking to [https://bugzilla.mozilla.org/show_bug.cgi?id=1429732 ''deprecate navigator.registerProtocolHandler over insecure HTTP''] in the ~62 timeframe. It’s already disabled on Nightly. Please file bugs in the DOM Security component.
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1333468 ''There are new identity UI pieces for showing disabled (“paused”) WebRTC streams''] (which will be available to sites starting with Firefox 60 to avoid showing another permission prompt when temporarily turning off devices).
* The [https://bugzilla.mozilla.org/show_bug.cgi?id=1409257 ''Symantec CA distrust policy action''] is underway in Nightly. This policy is being [https://security.googleblog.com/2017/09/chromes-plan-to-distrust-symantec.html ''implemented by Chrome in M66''], which will [https://www.chromestatus.com/features/schedule ''release ahead of''] Firefox 60.
** Please direct questions and concerns to [mailto:jc@mozilla.com ''jc@mozilla.com''] [:jcj] @jcj
** Note that filing bugs for particular websites is not useful; we’ve been duping them on [https://bugzilla.mozilla.org/show_bug.cgi?id=1436062 ''Bug 1436062''].
** TLS Canary shows ~300 high-ranking sites broken: [https://tlscanary.mozilla.org/runs/2018-02-23-11-56-37/index.htm ''https://tlscanary.mozilla.org/runs/2018-02-23-11-56-37/index.htm'']

== [https://wiki.mozilla.org/Firefox/Search ''Search and Navigation''] ==

=== Address Bar &amp; Search ===
* It’s now easier to find open tabs in the Address Bar. [https://bugzilla.mozilla.org/show_bug.cgi?id=1433938 ''Remote Tabs got a weight bump, and switch-to-tab matches can now replace identical matches''].
* Fixed a [https://bugzilla.mozilla.org/show_bug.cgi?id=1438329 ''problem with delayed key handling in the Address Bar''], causing Enter to be ineffective in some cases.
* The [https://bugzilla.mozilla.org/show_bug.cgi?id=1438130 ''top preloaded sites feature in the Address Bar''], has been disabled globally, to reduce Nightly users confusion about foreign domains used for testing.
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1239708 ''Enhanced autofill''] will likely land in 61, to have longer Nightly testing.
* Work in progress to add [https://bugzilla.mozilla.org/show_bug.cgi?id=1221539 ''Search engines discovery to the Address Bar''].

=== Places ===
* It’s [https://bugzilla.mozilla.org/show_bug.cgi?id=1313188 ''no more possible to have multiple keywords for the same url, unless POST data differs'']. May cause minor dataloss of duplicate keywords (rel-noted).
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1439313 ''treeview.js is no more loaded on every window opening''].
* Bookmark roots localized titles are not stored anymore in the database but [https://bugzilla.mozilla.org/show_bug.cgi?id=1432614 ''handled by the frontend code'']
* Fixed various [https://bugzilla.mozilla.org/show_bug.cgi?id=1437250 ''regressions''] in [https://bugzilla.mozilla.org/show_bug.cgi?id=1437310 ''bookmarks''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1439697 ''features'']
* Removed more synchronous Bookmarks APIs: [https://bugzilla.mozilla.org/show_bug.cgi?id=656936 ''GetRemoveFolderTransaction''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1432426 ''moveItem''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1432427 ''insertSeparator''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1433307 ''GetKeywordForBookmark''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1434607 ''SetKeywordForBookmark''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1432425 ''RemoveFolderChildren''].

=== More ===
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1435711 ''Removed tree autocomplete support from the autocomplete controller''].
* A [https://bugzilla.mozilla.org/show_bug.cgi?id=1434414 ''Sanitize on Shutdown forced through autoconfig or policies won’t sanitize anymore at every browser startup''].

== Sync / Firefox Accounts ==
* Mark refactored how [https://bugzilla.mozilla.org/show_bug.cgi?id=1435929 ''Sync authenticates''] with FxA 🔑, removing a lot of technical debt.
* Thom is working on [https://bugzilla.mozilla.org/show_bug.cgi?id=1343103 ''persisting synced bookmark deletions''], which should avoid resurrecting deleted bookmarks in certain cases ⛔️, refactored the [https://bugzilla.mozilla.org/show_bug.cgi?id=1438445 ''bookmark validator''] ✅, and modularized and [https://github.com/mhammond/aboutsync/pull/45 ''rewrote the About Sync add-on''] ✏️.
* Thom and Ed [https://bugzilla.mozilla.org/show_bug.cgi?id=1435588 ''significantly''] [https://bugzilla.mozilla.org/show_bug.cgi?id=1408092 ''improved''] new bookmark mirror performance 🏃‍♀️.
* Kit is working on [https://bugzilla.mozilla.org/show_bug.cgi?id=1199077 ''storing more Sync metadata in Places''] 🗺, which improves how we handle bookmark restores and corrupt database recovery.
* We have a plan to fix the [https://bugzilla.mozilla.org/show_bug.cgi?id=1435446 ''storage thread hang''] ⛄️ that blocks dogfooding of [https://bugzilla.mozilla.org/show_bug.cgi?id=1433177 ''new bookmarks''] 📚.

== [https://wiki.mozilla.org/Test_Pilot ''Test Pilot''] ==
* Incoming: [https://github.com/mozilla/ThemesRFun ''theme creator experiment''] shipping soon; [https://github.com/mozilla/tab-split ''tab split experiment''] exploring a [https://github.com/mozilla/tab-split-2 ''rewrite'']. Both experiments set to launch in Q2
* Outgoing: [https://testpilot.firefox.com/experiments/cliqz ''Cliqz''], [https://testpilot.firefox.com/experiments/voice-fill ''Voice Fill''], [https://testpilot.firefox.com/experiments/snooze-tabs ''Snooze Tabs''], [https://testpilot.firefox.com/experiments/min-vid ''Min Vid''] graduating Q1
* Min Vid shield study launching soon
* Screenshots:
** Usage steady at [https://datastudio.google.com/u/0/org/Ra9O2QIYT8We-1pOmnS_6w/reporting/0B0YGcIge2EkrOE5OLVl2T2NobFE/page/FZH ''2.8M''] MAU, [https://datastudio.google.com/u/0/org/Ra9O2QIYT8We-1pOmnS_6w/reporting/0ByaR4oZsXEGSVFRzVVA4MEpwR0U/page/AAfF ''62M+''] shots as of today
** Lots of bug fixes exported into the tree recently (bug [https://bugzilla.mozilla.org/show_bug.cgi?id=1436218 ''1436218'']); another release landing in 60 today-ish, pending QA (bug [https://bugzilla.mozilla.org/show_bug.cgi?id=1440524 ''1440524''])
** ICYMI: rad [https://blog.mozilla.org/firefox/share-exactly-see-screen-firefox-screenshots/ ''Screenshots article''] on Firefox blog last week ([https://github.com/mozilla-services/screenshots/issues/4131 ''bug filed''] to put that youtube video on the screenshots homepage :-)
** Lo-fi user research happening this week on discoverability &amp; onboarding
** Annotations shipping soon: edit, highlight, &amp; draw on uploaded shots
** Here’s a usage graph, now with all the shot types:[[File:Pictures/10000201000005F80000025C30C7B2BB.png|602x237px]]

== [https://wiki.mozilla.org/Firefox/Features/Web_Payments ''Web Payments''] ==
* Team meetings in Vancouver last week
* On track to finish M1 by the end of the quarter
** M1: End-to-end test with valid user data and merchant update/change events, no Firefox validation, generic merchant error string, only already stored cards/addresses
* Fixed:
** Shipping address/option pickers
*** [https://bugzilla.mozilla.org/show_bug.cgi?id=1437879 The shipping-option-picker doesn't show the selected option when the popup is closed]'' ''
*** [https://bugzilla.mozilla.org/show_bug.cgi?id=1427947 Dispatch `shippingoptionchange` when the shipping option is changed]'' ''
*** [https://bugzilla.mozilla.org/show_bug.cgi?id=1435101 Only show shipping (option &amp; address) pickers in the payment request dialog when requestShipping is true]'' ''
*** [https://bugzilla.mozilla.org/show_bug.cgi?id=1435105 Vary the payment request address label according to the `shippingType`]'' ''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1429205 Implement the &quot;processing&quot; screen for when the pay button is clicked]'' ''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1429189 Show shipping address errors on the summary screen]'' ''
** Cleanup
*** [https://bugzilla.mozilla.org/show_bug.cgi?id=1440530 Clean up some duplication in the webpayments mochitest-browser tests for setting up dialogs]'' ''
*** [https://bugzilla.mozilla.org/show_bug.cgi?id=1434415 Moved hard-coded PaymentRequest strings to ]''entities ''
* In Progress
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1429211 Implement the &quot;success&quot; screen for when the merchant accepts the payment]'' ''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1440499 Implement the payerName/payerEmail/payerPhone contact picker]'' ''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1427939 Show additional list items (`additionalDisplayItems`) tied to payment methods in the UI]'' ''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=1440843 Don't dispatch shipping*change events if requestShipping is false]'' ''