Firefox3.1/SMIL Security Review: Difference between revisions

Firefox3.1/SMIL Security Review (view source)

1,243 bytes added , 3 September 2008

canmove, Confirmed users

637

edits

@@ Line 122: / Line 122: @@
 == Review comments ==
+* need a SMIL-enabled pref, separate from image animation.
+** is it worth checking both before doing animation? For security and stability reasons we may want to be able to kill SMIL, but users who just want to stop animated ads may expect the old pref to stop all kinds of animation.
+* only support length values for animation
+** spec supports any CSS property
+* only times relative to the beginning of the document (spec has a richer set): begin, end, dur(ation).
+* times are stored as PRInt64
+* need to test negative durations and end times prior to begin times
+* can specify lists of begin and end times
+** what if they don't have the same number of elements?
+** what if they are misordered? Do they match by index in the given lists or do the begins run until the next specified end?
+* integer overflows if images get too big? translated way offscreen?
+** SVG keeps things in floating point, cairo's interface is floating point
+** cairo does the conversion into actual images
+* calcModes: discrete, spline, paced, linear
+* spec says there should be animation events, but we don't fire them. Should we ever do that we would need to be careful.
+* animation nodes can be moved from element to element -- test
+* "fill" values: freeze, remove