Gaia/New-Architecture-Program/Contacts/FxOS-S8(02 Oct): Difference between revisions

← Older edit

Gaia/New-Architecture-Program/Contacts/FxOS-S8(02 Oct) (view source)

Revision as of 14:40, 1 October 2015

854 bytes removed , 1 October 2015

→‎Issues found when landing our work but other FxOS teams have to fix

Oteo

Confirmed users

1,225

edits

@@ Line 14: / Line 14: @@
 *In last sprint we reverted the changes that gave us separated views (we keep the separation of fronted-bankend) so the all views separation commits have been rolled back in master build.
 *The reason for doing this is that we won't have the expected quality in master if we leave it as it is:
-**some rebuilds were detected.
 **Our navigation was not the perfect one, as we were missing some important pieces like support for pre-rendering and navigation transition.
+**Some regressions were detected in master that provokes rebuilds in the contact list when Contacts is in background (see this video to check it https://www.youtube.com/watch?v=FuMfUrelkLE&feature=youtu.be )
+***This is due to the use of BFCache that is going to save a lot of memory when the app is going to the background, as it will evict the cached views that we are not using anymore.
+***To fix this we could use the virtual list with the DOM scheduler from Etienne but there is not enough time to do it in 2.5.
 *We have created a branch called NGA where we have some separate views (#new and #open), and where we will experiment and develop until we reach the quality expected.
 *'''In this sprint we are focused on landing all the pending NGA work in this new branch.'''
@@ Line 21: / Line 23: @@
 *In order to keep the quality that we will need for 2.5 release, we have leave master with the single page navigation. We won't land in master anything else, just blockers..So post 2.5 release of contacts app could come from that development branch.
-== Steps for the Roll Back of the separated views ==
-*Confirm if the NGA work that affects to Dialer is also part of the backout
-**Gabrile has confirmed that we can maintain it so the commits to revert are the ones included [https://wiki.mozilla.org/Gaia/New-Architecture-Program/Contacts/FxOS-S7%2818_Sep%29#Analyzing_the_candidates_commits_for_the_possible_backout above]
-*Check Francisco's branch (https://github.com/arcturus/gaia/tree/contacts-revert) to test the Contact branch with the roll back already done
-**It seems to be ok and no important regressions have been found but we need to align with QA team to have a look at it.
-*Communicate the decision in the mailing list so everybody is aware of it.
-*Do the revert of the chosen commits in master [Francisco]
-*Create a new branch in /mozilla-b2g ("NGA Contacts" or "Develoment Contacts) with all the commits in master before the revert
-*In the new branch land all the NGA pending work
-**Land 'overlay' [Manu - R+]
-**Land 'list' [Manu - r? Borja]
-**Land 'settings' [FCampo - r? Borja]
-*Choose and inform of the whiteboards that we are to use in bugzilla to differentiate what patches affect to each branch or both two (specially important that QA team are aware of it and agree)
-*Analyze the bugs we have in Contacts, starting with the 2.5+, to see which affects to master or the new branch or both.
 === Bugs for this sprint ===
@@ Line 57: / Line 46: @@
 *[https://bugzilla.mozilla.org/show_bug.cgi?id=1203063 Bug 1203063] - [Contacts]custom label of address is displayed as '#TYPE#'('''Borja''') '''It needs the fix ONLY in NGA branch'''
 *[https://bugzilla.mozilla.org/show_bug.cgi?id=1196830 Bug 1196830] - test_import_edit_export_contact.py: "AssertionError: 9 != 8"
-*[https://bugzilla.mozilla.org/show_bug.cgi?id=1203885 Bug 1203885] - [Contacts]It always prompts "Imported X contacts. contactsMerged" from a vcard so user don't know how many contacts are merged after importing. '''2.5+''' '''It needs the fix in master and NGA branches'''
+*[https://bugzilla.mozilla.org/show_bug.cgi?id=1203885 Bug 1203885] - [Contacts]It always prompts "Imported X contacts. contactsMerged" from a vcard so user don't know how many contacts are merged after importing. '''2.5+''' '''It needs the fix in master and NGA branches. RESOLVED'''
 == Other bugs to pay attention ==
@@ Line 72: / Line 61: @@
 *[https://bugzilla.mozilla.org/show_bug.cgi?id=1184953 Bug 1184953] - [Web Components] Document's element registry is not persisted in the BF Cache
 **Bug ssue detected when working in [https://bugzilla.mozilla.org/show_bug.cgi?id=1183727 Bug 1183727] - [Contacts][NGA] Create #update view and connect it to #open within Contacts App
-*[https://bugzilla.mozilla.org/show_bug.cgi?id=1198522 Bug 1198522] - Long pressing on an image in edit mode will bring up a menu that does not function.
+*[https://bugzilla.mozilla.org/show_bug.cgi?id=1198522 Bug 1198522] - Long pressing on an image in edit mode will bring up a menu that does not function. '''RESOLVED'''
 *[https://bugzilla.mozilla.org/show_bug.cgi?id=1202359 Bug 1202359][Contacts]Tap the check box(small rectangular box) in "Duplicates Found" view for once, actually it performed double taps.
 **It seems similar to the already resolved by Etienne [https://bugzilla.mozilla.org/show_bug.cgi?id=1190775 Bug 1190775] - [System] If an activity perform a window.open, the popup will be unresponsive. NI to Etienne for more info.