TPE-Layout/2017-09-12

Weekly Announcement

• Firefox 57 milestones
  • https://docs.google.com/document/d/1jeypuqBqEyIh-4qxXT0UnE2aVjetN7uVD8W7L7TbWKg/edit
• 2017 December All hands relocated
  • 2017 December 11-16 - Austin, Texas, USA (JW Marriott Austin & Fairmont Austin)
• Sheriff in Asia update
  • Softvision contractor
• Team building proposals
  • https://goo.gl/8mFVZm

Weekly Sharing

• TY
  • 懶人也會的 Firefox 中文翻譯
    • https://transvision.mozfr.org/
    • https://pontoon.mozilla.org/zh-TW/
• Louis
  • debug FF with rr
    • rr record -M ./mach run, rr reply -g <nnnn>
    • rr record ./mach run, rr ps, rr replay -p <pid>
    • ./mach run --debugger=rr

Weekly Status

Astley Chen

• bug 752790 NEW:: Input padding covers text when the padding is greater than (TextHeight - InputHeight)/2
  • Bug 752790 - long standing webcompat issue needs some love.

Boris Chiou

• bug 1397146 NEW:: The length part of calc() should not be rounded to nscoord (integer) for computed transform
  • Filed bug 1397146 - The length part of calc() should not be rounded to nscoord (integer) for computed transform
• bug 1396692 RESOLVED::FIXED stylo: unit of absolute length needs to be preserved in calc()
  • Landed Bug 1396692 - stylo: unit of absolute length needs to be preserved in calc()
  • Wrote patches for bug 1396692 - stylo: unit of absolute length needs to be preserved in calc()
• bug 1392161 ASSIGNED:: stylo: Length values should not be rounded to Au for computed transform
  • Wrote patches to replace computed::Length with CSSPixelLength for bug 1392161 - stylo: Length values should not be rounded to Au for computed transform

Cameron McCormack

• Reviewed https://github.com/servo/servo/pull/18400
• Reviewed https://github.com/servo/servo/pull/18404
• bug 1393861 RESOLVED::FIXED stylo: switching Slack channels sometimes requires multiple clicks
  • Reviewed bug 1393861
• bug 1395227 RESOLVED::FIXED stylo: stop the cascade if only reset properties change but no children explicitly inherited
  • Reviewed bug 1395227
• bug 1342951 NEW:: Expensive sync reflows when holding the down key on google presentations
  • Reviewed rest of bug 1342951
• bug 1397238 ASSIGNED:: Crash in InvalidArrayIndex_CRASH | gfxFontFamily::FindAllFontsForStyle
  • Reviewed bug 1397238
• bug 1367635 NEW:: stylo: consider caching style structs in the rule tree
  • Refining bug 1367635 patch to use less memory
• bug 1387958 RESOLVED::FIXED stylo: Measure the entire stylist during memory reporting
  • Reviewed bug 1387958
• bug 1387410 RESOLVED::FIXED make grid-row-gap and grid-column-gap no longer be reset by the grid shorthand
  • Reviewed bug 1387410
• bug 1397579 RESOLVED::FIXED Report stylesheet memory usage under "layout/style-sheets"
  • Reviewed bug 1397579

CJ Ku

• bug 1396025 RESOLVED::FIXED Write a comment to explain the difference between eBBoxIncludeFill and eBBoxIncludeFillGeometry
  • Bug 1396025 land
• bug 1396776 RESOLVED::FIXED Move mCanvasTM from the derived class of nsSVGViewportFrame to nsSVGViewportFrame
  • Bug 1396776 land
• bug 1381153 ASSIGNED:: Calling GetEffectSet during display list building is not very cache friendly
  • Bug 1381153 upload patch
• bug 1396489 RESOLVED::FIXED Let gfxContext::GetClipExtents be able to return clipped rect in either user space or device space
  • Bug 1396489 landed
• bug 1294966 RESOLVED::WONTFIX SVG getBBox should provide useful information for zero-width/height shapes
  • Bug 1294966 upload a patch

Eric Tsai

• WebCompat workweek, migrate issue status from github label to milestone. Ready to merge.
• Deploy alexa webhook on webcompat.com

Jeremy Chen

• Filed a issue about the perma failures on a specific mac build slave [servo #18374]
• bug 1391341 NEW:: stylo: Font size inherits differently than in Gecko
  • Triaged and un-assigned myself [Bug 1391341]
• bug 1296577 RESOLVED::DUPLICATE Give nscoord_MAX a better definition to avoid potential integer overflowing
  • Replied ni and resolved the bug [Bug 1296577]
• bug 1398011 NEW:: [META] Implement CSS Transform Module Level 2
  • Filed Bug 1398011
• bug 1394284 ASSIGNED:: stylo: animate singular matrix as discrete
  • Investigated a bit, NI for more context [Bug 1394284]
  • Investigated, came up with a rough plan, NI Brian for feedback [Bug 1394284]
  • Reported implementation progress, need to further refine the design plan [Bug 1394284]
  • Uploaded a patch and asked for 1st round of review [Bug 1394284]
  • Uploaded a wip [Bug 1394284]
• bug 1394994 RESOLVED::FIXED Stylo: Keyframe rules missing line / column info
  • Landed [Bug 1394994]

Louis Chang

• bug 1290782 - SVG border-image without viewport size and viewBox is broken when changing the opacity.
  • study bug | study rr
• bug 1352238 - Implement a native theme for checkbox/radio form controls on Android
  • land

Ting-Yu Lin

• Translate "Duplicate Tab" as "複製分頁" for zh_TW in https://pontoon.mozilla.org/zh-TW/firefox/browser/chrome/browser/browser.dtd/?string=171582
• bug 1396700 RESOLVED::FIXED stylo: Minor clean up for ServoStyleSet
  • Filed and landed bug 1396700.
• bug 1340966 NEW:: Add assertion to nsReflowStatus::SetNextInFlowNeedsReflow()
  • Uploaded a patch for bug 1340966.

Tommy Kuo

• bug 1229979 ASSIGNED:: Multi-color shadow shouldn't be allowed when the color of text is different to the color of decoration line.
  • Debug for the failure of windows and android (bug 1229979)
  • Landed (bug 1229979)
  • Read the spec resolution and update the issue (bug 1229979)
  • Upload patches and ask to review (bug 1229979)
  • WIP and ran a try (bug 1229979)
• bug 1380590 RESOLVED::FIXED stylo: the fill color should be transparent when `svg.context-properties.content.enabled=false` and no fallback color given
  • Got r+ and wait to land (bug 1380590)
  • Landed (bug 1380590)

Ya-Chieh Wu

• Bug895096 patch uploaded
• Debug Bug1381153
• bug 1397119 NEW:: Move GetBStartBCBorderWidth, GetBEndBCBorderWidth and any similar methods' return type to BCPixelSize rather than nscoord
  • File Bug 1397119

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics