canmove, Confirmed users
1,567
edits
Firefox/Code Review: Difference between revisions
Remove requirement for level 3 access
No edit summary |
(Remove requirement for level 3 access) |
||
| (7 intermediate revisions by 3 users not shown) | |||
| Line 13: | Line 13: | ||
* look for opportunities to improve Firefox as software, a product, and a community. | * look for opportunities to improve Firefox as software, a product, and a community. | ||
== Reviewers Emeritus == | |||
Many past contributors to Firefox have moved on to other projects and priorities. They are no longer active reviewers, but their contributions to Firefox have been significant, and we'd love to welcome them back to the project if they choose to become involved again. | |||
The list of reviewers emeritus can be found on the [[Modules/Firefox|Firefox module page]]. | |||
== What does r+ mean? == | == What does r+ mean? == | ||
| Line 24: | Line 27: | ||
** security concerns, especially where content and chrome touch each other; | ** security concerns, especially where content and chrome touch each other; | ||
** significant performance issues, especially on key paths like startup and page load; | ** significant performance issues, especially on key paths like startup and page load; | ||
** localization and accessibility issues. | ** [https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices localization] and accessibility issues. | ||
* If it does cause problems, I will help make it right. | * If it does cause problems, I will help make it right. | ||
* The patch has test coverage appropriate to the change. | * The patch has test coverage appropriate to the change. | ||
| Line 49: | Line 52: | ||
The reviewer list might look long, but these are busy people and there can be a lot of patches to review. Sometimes patches fall through the cracks, for which we are all quite sorry. | The reviewer list might look long, but these are busy people and there can be a lot of patches to review. Sometimes patches fall through the cracks, for which we are all quite sorry. | ||
A poke in the bug can help, or direct email to the designated reviewer. If that doesn't work, please [mailto: | A poke in the bug can help, or direct email to the designated reviewer. If that doesn't work, please [mailto:dtownsend@mozilla.com mail Mossop] for assistance. | ||
Are you looking for UI review or feedback but not getting it? Make sure to flag ux-review@mozilla.com for your UI-review/feedback request and [https://developer.mozilla.org/En/Developer_Guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes it should be answered within 48 hours]. | Are you looking for UI review or feedback but not getting it? Make sure to flag ux-review@mozilla.com for your UI-review/feedback request and [https://developer.mozilla.org/En/Developer_Guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes it should be answered within 48 hours]. | ||