TPE-Layout/2017-10-11

Weekly Announcement

• Q4 Goals on Wiki & WD - Due:10/13
  • Wiki - https://wiki.mozilla.org/TPE-Layout/2017-Q4-Goals
  • Workday - https://sso.mozilla.com/workday
  • Resolved: TBU until WD is open.
• Q4 Workshop event planning
  • When & Where & What
  • Resolved: Middle of Nov.

Weekly Status

Astley Chen

• bug 1305966 RESOLVED::WORKSFORME Repaint issue when using CSS variables (custom properties) with background-image
  • Bug 1305966 - WFM now. Might be a render pipeline fix resolved that.
• bug 1406727 NEW:: Crash in nsDisplayWrapList::Destroy
  • Bug 1406727: low volume crash when flushing displaylist during frame painting.
• bug 1375720 NEW:: svg icons on GitHub are blurry (and unevenly so)
  • Bug 1375720 - need investigation.

Boris Chiou

• bug 1303235 ASSIGNED:: stylo: Implement KeyframeEffectReadOnly::CalculateCumulativeChangeHint
  • Investigated bug 1303235 - stylo: Implement KeyframeEffectReadOnly::CalculateCumulativeChangeHint
• bug 1340005 ASSIGNED:: stylo: Switch to Servo style backend for compositor animations
  • cleaned up code in bug 1340005 - stylo: Switch to Servo style backend for compositor animations

Cameron McCormack

• bug 1406108 RESOLVED::FIXED Avoid RefPtr copy during iteration in nsPresContext::MediaFeatureValuesChanged
  • Reviewed bug 1406108
• bug 1404897 RESOLVED::FIXED stylo: Use stylo for Element::Matches.
  • Reviewed bug 1404897
• bug 1406284 RESOLVED::FIXED stylo: Remove unused parent context argument in ServoStyleSet
  • Reviewed bug 1406284
• bug 1403077 RESOLVED::FIXED stylo-blocklist: add support for a list of domains that should use the old Gecko style system instead of Stylo
  • Reviewed bug 1403077
• bug 1406222 RESOLVED::FIXED stylo: thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value' in [@ style::stylist::Stylist::compute_style_with_inputs]
  • Reviewed bug 1406222
• bug 1406109 RESOLVED::FIXED stylo: Assertion failure: !IsDOMException() (Don't overwrite DOM exceptions) in [@ nsINode::ParseSelectorList]
  • Uploaded patch for bug 1406109
• bug 1406275 RESOLVED::FIXED stylo: Assertion failure: !element->HasAnyOfFlags(Element::kAllServoDescendantBits) in [@ AssertNoBitsPropagatedFrom]
  • Uploaded patch for bug 1406275

CJ Ku

• bug 1399787 NEW:: Create a new sandboxed process to run pdfium
  • Bug 1399787 WIP
• bug 1403057 RESOLVED::FIXED Assertion failure: invertible, at layout/svg/nsFilterInstance.cpp:80
  • Bug 1403057 landed
• bug 1343147 RESOLVED::FIXED Assertion failure: mList.GetChildren()->GetTop()->GetType() == TYPE_TRANSFORM
  • Bug 1343147 land
  • Bug 1343147 upload patches

Eric Tsai

• Issue triage
• Submit webcompat-to-bugzilla extension to AMO

Jeremy Chen

• bug 1407098 NEW:: stylo-blocklist: consider put a nightly only domain in stylo blocklist
  • Filed Bug 1407098, Bug 1407096
• bug 1407096 NEW:: stylo-blocklist: measure the performance impact for enabling the blocklist mechanism
  • Filed Bug 1407098, Bug 1407096
• bug 1403077 RESOLVED::FIXED stylo-blocklist: add support for a list of domains that should use the old Gecko style system instead of Stylo
  • Finished testcase, but keep crashing while calling IsInStyloBlocklist() from nsDocument, digging [Bug 1403077]
  • Fixed crash issue, figuring out why test pref does not work whereas the all.js does [Bug 1403077]
  • Fixed xpcshell test failures on try, updated patchset accordingly, wait for a positive try run before landing [bug 1403077]
  • Landed Bug 1403077
  • Updated implementation plans and wrote WIPs accordingly [Bug 1403077]
  • Updated patchset and requested fo refiew [Bug 1403077]

Louis Chang

• bug 1404770 - Minimum widget size of checkbox/radio on Android is wrong
  • land
• bug 1405986 - The checkbox/radio is not aligned vertically after clamping on Android
  • land

Ting-Yu Lin

• bug 1406875 NEW:: stylo: Figure out how quirks mode and XBL stylesets should interact
  • Discuss stylo video controls issues in bug 1405543 and bug 1406875.
• bug 1405543 RESOLVED::FIXED stylo: media element controls are sometimes displayed unstyled
  • Discuss stylo video controls issues in bug 1405543 and bug 1406875.
• bug 1404854 ASSIGNED:: Cannot scroll page by dragging text selection handles to the edge of the screen
  • Uploaded patches for bug 1404854.
• bug 1405830 RESOLVED::FIXED Assertion failure: aStatus.IsEmpty() (Caller should pass a fresh reflow status!) in [@ nsHTMLScrollFrame::Reflow]
  • Requested beta uplift for bug 1405830.
  • Upload a patch for bug 1405830.

Tommy Kuo

• bug 1399310 NEW:: Decorations get drawn multiple times with selections
  • Debug for the wrong clip region (bug 1399310)
  • Debug for the wrong clip region for RTL text (bug 1399310)
  • Fixed the clip region when the text is not drawn from beginning (bug 1399310)

Ya-Chieh Wu

• bug 332740 NEW:: [BC] rowspan and border-collapse: collapse breaks border rendering
  • Debug Bug 332740
• bug 1405929 NEW:: [BC] rowspan on border-collapse is wrong.
  • File Bug 1405929
• bug 1406265 RESOLVED::FIXED [BC] SetIStartStart(), IsIStartStart(), IsBStartStart() and SetBStartStart() are not well used
  • Bug 1406265 r+
  • File Bug 1406265
  • R? Bug 1406265

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics