Confirmed users
796
edits
Compatibility/System Addon/Override Policies and Workflows: Difference between revisions
Compatibility/System Addon/Override Policies and Workflows (view source)
Revision as of 15:31, 16 March 2018
, 16 March 2018→Generic Process of adding an override: Add note about needing more process.
Twisniewski (talk | contribs) (updated to suggest window.eval instead of window.wrappedJSObject.eval) |
m (→Generic Process of adding an override: Add note about needing more process.) |
||
| Line 25: | Line 25: | ||
# At the same time, a test case for validating the need of this override should be written. ['''Note''': this is an ongoing project and there will be more details on that in the future.] That way, we will get notified if the site got fixed and the user agent is no longer needed. ['''ToDo''': will our testing framework also include a time based notification so we don't forget that we need to remove old overrides?] | # At the same time, a test case for validating the need of this override should be written. ['''Note''': this is an ongoing project and there will be more details on that in the future.] That way, we will get notified if the site got fixed and the user agent is no longer needed. ['''ToDo''': will our testing framework also include a time based notification so we don't forget that we need to remove old overrides?] | ||
# If both the override and the test are validated, the PR should get merged. | # If both the override and the test are validated, the PR should get merged. | ||
# If the PR is merged, a new version of the Go Faster addon should be released and rolled out to the users. ['''ToDo''': clarify how.] | # If the PR is merged, a new version of the Go Faster addon should be released and rolled out to the users. | ||
'''Note''': A peer/module review will be required to land in m-c. And there will need to be some signoff process from relman or PI before we roll this out. To be clarified. | |||
['''ToDo''': clarify how.] | |||
== Types of Overrides == | == Types of Overrides == | ||