MozillaWiki

Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions

Page Discussion

Auto-tools/Projects/Stockwell/disable-recommended (view source)

Revision as of 09:11, 12 December 2019

458 bytes removed ,  12 December 2019
m
updated the post disable steps and reviewers
(Removed deprecated info about making a patch with mq and added info about moz-phab patches.)
m (updated the post disable steps and reviewers)
 
(3 intermediate revisions by 2 users not shown)
Line 155: Line 155:
   +    if (os == "linux"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526
   +    if (os == "linux"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526
   +    if debug and (os == "win") and (version == "10.0.15063"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526
   +    if debug and (os == "win") and (version == "10.0.15063"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526
* If the test has expectations set, make sure to leave a blank line between the disabling conditions and the expectation. e.g.: https://hg.mozilla.org/integration/autoland/rev/b07579851b6f#l1.7


== Making a patch ==
== Making a patch ==
Line 164: Line 166:
  nano/gedit file_path                                                                    //edit the file you want to disable
  nano/gedit file_path                                                                    //edit the file you want to disable
  hg commit                                                                              //add commit message
  hg commit                                                                              //add commit message
  <inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r=gbrown/jmaher| and save>
  <inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r=#intermittent-reviewers| and save>
  hg diff -c .                                                                          //see the changes you made to the files and self review
  hg diff -c .                                                                          //see the changes you made to the files and self review
  moz-phab                                                                              //will submit the changes in phabricator
  moz-phab                                                                              //will submit the changes in phabricator
Line 170: Line 172:
If you want to update an existing phabricator patch, you need to be the owner of the revision or to [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html?highlight=commandeer#other-revision-actions commandeer] it. Then do the following steps:
If you want to update an existing phabricator patch, you need to be the owner of the revision or to [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html?highlight=commandeer#other-revision-actions commandeer] it. Then do the following steps:


  moz-phab patch patch_id --apply-to .                        //applies the patch locally to the active repo
  moz-phab patch patch_id --apply-to .                        //applies the patch locally to the active repo (recommended mozilla-central)
  nano/gedit file_path                                        //edit the file you need to change
  nano/gedit file_path                                        //edit the file you need to change
  hg commit --amend                                          //update or change the commit
  hg commit --amend                                          //update or change the commit
Line 176: Line 178:
  moz-phab                                                    //upload the changes to phabricator
  moz-phab                                                    //upload the changes to phabricator


NOTE:
* The comment for the commit needs to follow the general pattern above: "Bug xxx - <patch description>. r=yyy"
* Phabricator automatically detects the reviewer from the commit message and asks for a review to the specified person.
* In most cases, for disable patches use r=gbrown or r=jmaher, except if you are disabling for webrender only, then use r=kats.


NOTE: the self review is a great time to make sure:
NOTE: the self review is a great time to make sure:
Line 181: Line 187:
* you are only editing one line in a file, not multiple lines on accident
* you are only editing one line in a file, not multiple lines on accident
* a chance to review your syntax and any comments
* a chance to review your syntax and any comments
NOTE: the comment for the commit needs to follow the general pattern above: "Bug xxx - <patch description>. r=yyy"
See also https://developer.mozilla.org/en-US/docs/Mozilla/Mercurial .
== Requesting review ==
In bugzilla, in the bug with [stockwell disable-recommended], use "Attach File" to attach your patch. Browse to find the patch in <your repo directory>/.hg/patches. Make sure you select "patch" for the Content Type. Then request review, "r?", and select a reviewer. In most cases, ask :gbrown or :jmaher for review.
'''One exception is if you are disabling a test that is webrender only, please make sure to ask :kats for review.'''
In the above section it was suggested to copy your patch to ~/ via
cp .hg/patches/bug1234567.patch ~/
In doing this, you could easily find your patch when in bugzilla and looking to attach a file since it will be ~/bug1234567.patch.
A few extra notes here:
* when uploading a patch the checkbox for "assign this bug to myself" is checked by default, uncheck this as you are just disabling a test
* use a description, not the patch name.  Something like: |disable test on <platforms>|


There are additional, generic instructions for getting Mozilla reviews at:
There are additional, generic instructions for getting Mozilla reviews at:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch


== After the test is disabled ==
== After the test is disabled ==
* Add leave-open to keyword and in Whiteboard change to [stockwell:disabled]
* "Watch" your patch landing to see if the patch was effective:
* "Watch" your patch landing to see if the patch was effective:
** Are there any new failures on your push, or on the next few pushes, of the disabled test?
** Are there any new failures on your push, or on the next few pushes, of the disabled test?
Aciure
Confirmed users
2

edits

Retrieved from "https://wiki.allizom.org/Special:MobileDiff/1215101...1221233"