Confirmed users
2
edits
Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions
Auto-tools/Projects/Stockwell/disable-recommended (view source)
Revision as of 09:11, 12 December 2019
, 12 December 2019updated the post disable steps and reviewers
m (Added a small change about the active repo) |
m (updated the post disable steps and reviewers) |
||
| (One intermediate revision by one other user not shown) | |||
| Line 155: | Line 155: | ||
+ if (os == "linux"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526 | + if (os == "linux"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526 | ||
+ if debug and (os == "win") and (version == "10.0.15063"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526 | + if debug and (os == "win") and (version == "10.0.15063"): https://bugzilla.mozilla.org/show_bug.cgi?id=1435526 | ||
* If the test has expectations set, make sure to leave a blank line between the disabling conditions and the expectation. e.g.: https://hg.mozilla.org/integration/autoland/rev/b07579851b6f#l1.7 | |||
== Making a patch == | == Making a patch == | ||
| Line 164: | Line 166: | ||
nano/gedit file_path //edit the file you want to disable | nano/gedit file_path //edit the file you want to disable | ||
hg commit //add commit message | hg commit //add commit message | ||
<inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r= | <inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r=#intermittent-reviewers| and save> | ||
hg diff -c . //see the changes you made to the files and self review | hg diff -c . //see the changes you made to the files and self review | ||
moz-phab //will submit the changes in phabricator | moz-phab //will submit the changes in phabricator | ||
| Line 190: | Line 192: | ||
== After the test is disabled == | == After the test is disabled == | ||
* Add leave-open to keyword and in Whiteboard change to [stockwell:disabled] | |||
* "Watch" your patch landing to see if the patch was effective: | * "Watch" your patch landing to see if the patch was effective: | ||
** Are there any new failures on your push, or on the next few pushes, of the disabled test? | ** Are there any new failures on your push, or on the next few pushes, of the disabled test? | ||