45
edits
Firefox/Meeting/23-Mar-2021: Difference between revisions
Update Password Manager notes
(Add section for "Lint") |
(Update Password Manager notes) |
||
| (16 intermediate revisions by the same user not shown) | |||
| Line 107: | Line 107: | ||
==[https://firefox-source-docs.mozilla.org/tools/lint/index.html ''Lint'']== | ==[https://firefox-source-docs.mozilla.org/tools/lint/index.html ''Lint'']== | ||
<li>If you run `./mach lint` in the top-level directory of a repository, with no paths specified, [https://bugzilla.mozilla.org/show_bug.cgi?id=1369784 it will now default] to `--outgoing --workdir`, rather than doing a full lint.</li> | <li>If you run `./mach lint` in the top-level directory of a repository, with no paths specified, [https://bugzilla.mozilla.org/show_bug.cgi?id=1369784 it will now default] to `--outgoing --workdir`, rather than doing a full lint.</li> | ||
==Messaging System== | |||
<ul> | |||
<li>[https://bugzilla.mozilla.org/show_bug.cgi?id=1694257 Support showing different about:welcome default experiences] based on some targeting, e.g., Windows build version, that can still be remotely configured</li> | |||
<li>Various fixes in preparation for rapid turnaround from 87 release “Pin” experiment during 88 beta: [https://bugzilla.mozilla.org/show_bug.cgi?id=1698962 landing strings], [https://bugzilla.mozilla.org/show_bug.cgi?id=1694578 mac size regression], [https://bugzilla.mozilla.org/show_bug.cgi?id=1696444 icon disappearing]</li> | |||
</ul> | |||
==Mobile== | ==Mobile== | ||
| Line 119: | Line 125: | ||
==[https://wiki.mozilla.org/Toolkit:Password_Manager ''Password Manager'']== | ==[https://wiki.mozilla.org/Toolkit:Password_Manager ''Password Manager'']== | ||
<ul> | |||
<li> | |||
[https://bugzilla.mozilla.org/show_bug.cgi?id=1688213 Bug 1688213] Enable "signon.management.page.fileImport.enabled" for all channels fixed and in 88. | |||
<ul> | |||
<li>Import logins from CSV is in beta! Congrats to :petcuandrei for taking this feature from a UX spec and aspirational bugs to implementing and now shipping a feature that rounds out our whole story around login management. </li> | |||
<li>We now import and export logins, allowing you to round-trip from other browsers, other password managers, backed-up profiles or any other exotic scenario for which you can prepare a comma-separated values sheet, with at least password and URL columns for successful import into Firefox. </li> | |||
<li>We also have the ability to delete all, so the cost is low to play around with it and file bugs. </li> | |||
</ul> | |||
</li> | |||
<li>:dimi landed [https://bugzilla.mozilla.org/show_bug.cgi?id=1166995 Bug 1166995] - Run login capture code when a form or a formless password field is removed from the document tree. This fixed some long standing issues with prompting to save passwords on sites e.g bigcommerce.com, and no doubt many many others we were never notified about</li> | |||
</ul> | |||
[[File:Screenshot of the Import Complete dialog.png|thumb|center|Screenshot of the Import Complete dialog]] | |||
[[File:Import Summary Page.png|thumb|center|Screenshot of the Import Summary page]] | |||
==PDFs & Printing== | ==PDFs & Printing== | ||
<ul> | |||
<li>[https://bugzilla.mozilla.org/show_bug.cgi?id=1682162 Bug 1682162] - Print margin unit should be localized. [sfoster] landed this in 88, so now margin units are displayed according to the unit indicated by your printer. Mms rule. </li> | |||
</ul> | |||
[[File:Print Settings Screenshot.png|thumb|center|Print Settings Screenshot]] | |||
==Performance== | ==Performance== | ||
<ul> | |||
<li>dthayer improved the [https://bugzilla.mozilla.org/show_bug.cgi?id=1678411 UX of slow script notifications] in Fission</li> | |||
<li>dthayer is also working on various [https://bugzilla.mozilla.org/show_bug.cgi?id=1695674 improvements] and [https://bugzilla.mozilla.org/show_bug.cgi?id=1697091 bug-fixes] for the Pre-XUL Skeleton UI</li> | |||
<li>florian added some very handy profiler markers for CSS animations and transitions. [https://share.firefox.dev/2QaUjTK Here’s an example profile].</li> | |||
<li>The Pre-XUL Skeleton UI experiment will be wrapping up next week, and we hope to have some data on how it impacts new and existing user behaviour</li> | |||
<li>The Process Priority Manager was originally going to be disabled for Fission, but it turns out that for weaker hardware, it seems to really help with pageload time. The Fission team is looking into how to adapt the Process Priority Manager to work for subframes.</li> | |||
<li>mconley spoke with k88hudson about using Nimbus / ExperimentsAPI to run an about:home startup cache experiment | |||
<ul> | |||
<li>Originally, we had a Normandy experiment set up for about:home startup cache, but it turns out Normandy sets its prefs too late. Nimbus seems to do it earlier, which is good for us.</li> | |||
</ul> | |||
</li> | |||
<li>barret [https://bugzilla.mozilla.org/show_bug.cgi?id=1672431 fixed an AsyncShutdown bug for IOUtils], which should be the final blocker to remove the remainder of the OSFile uses in the tree! \o/</li> | |||
</ul> | |||
==Performance Tools== | ==Performance Tools== | ||
<ul> | |||
<li> | |||
Visualization of the CPU utilization is now landed and enabled by default on Firefox Nightly. Example profiles: | |||
<ul> | |||
<li>[https://share.firefox.dev/3lrhuVa Windows 10 - Fast Reference Laptop - Warm Startup]</li> | |||
<li>[https://share.firefox.dev/3qPml3O Windows 10 - Fast Reference Laptop - Cold Startup]</li> | |||
</ul> | |||
</li> | |||
</ul> | |||
[[File:Performance Tools .png|thumb|center|Before and after the CPU utilization changes in the graph.]] | |||
==Picture-in-Picture== | ==Picture-in-Picture== | ||
<ul> | |||
<li>Molly [mhowell] and Micah [mtigley] are working on setting up a foundation for site-specific video wrappers ([https://bugzilla.mozilla.org/show_bug.cgi?id=1670108 Bug 1670108])</li> | |||
<li>Oliver [popeoliv] | |||
<ul> | |||
<li>Landed some documentation for the Picture-in-Picture addon ([https://bugzilla.mozilla.org/show_bug.cgi?id=1695266 Bug 1695266])</li> | |||
<li>Started investigating how we can allow the Picture-in-Picture player window to continue playing even after the parent tab closes ([https://bugzilla.mozilla.org/show_bug.cgi?id=1561301 Bug 1561301])</li> | |||
</ul> | |||
</li> | |||
<li>Swapnik [katkoor2] submitted a patch where we prevent showing the PiP toggle button for videos with an invalid duration ([https://bugzilla.mozilla.org/show_bug.cgi?id=1697616 Bug 1697616])</li> | |||
</ul> | |||
==Pocket== | ==Pocket== | ||
| Line 135: | Line 195: | ||
==Search and Navigation== | ==Search and Navigation== | ||
<ul> | |||
<li>If a search engine that is set as default is removed, [https://bugzilla.mozilla.org/show_bug.cgi?id=1695262 we will now revert] to the region/locale default if it is not hidden, or we will try revert to a general search engine.</li> | |||
<li>[https://bugzilla.mozilla.org/show_bug.cgi?id=1690114 Fixed an issue] where updating an add-on which defined a search engine, and changing the search engine name could cause issues.</li> | |||
<li>`nsISearchService.addEngineWithDetails` has [https://bugzilla.mozilla.org/show_bug.cgi?id=1696027 now been removed]. This had become a test-only function, but conflicted with future work. Please prefer `SearchTestUtils.installSearchExtension` instead.</li> | |||
<li>Cleaned up the Search Telemetry in tree documentation - [https://bugzilla.mozilla.org/show_bug.cgi?id=1698847 Bug 1698847] </li> | |||
<li>Improved Address Bar handling of pasted strings containing white spaces - [https://bugzilla.mozilla.org/show_bug.cgi?id=1327589 Bug 1327589] </li> | |||
<li>Fixed a problem with editing the case of the url ref fragment - [https://bugzilla.mozilla.org/show_bug.cgi?id=1693320 Bug 1693320] </li> | |||
<li>Fixed a problem causing Tab to Search results to appear at the wrong index - [https://bugzilla.mozilla.org/show_bug.cgi?id=1697517 Bug 1697517] </li> | |||
</ul> | |||
== | ==Screenshots== | ||
<ul> | |||
== | <li>Reordered the “take a screenshot” [https://bugzilla.mozilla.org/show_bug.cgi?id=1690585 context menu item]</li> | ||
<li>[https://bugzilla.mozilla.org/show_bug.cgi?id=1691464 Removed screenshots from the page action panel] and moved to a dedicated toolbarbutton</li> | |||
<li>Working on a patch [https://bugzilla.mozilla.org/show_bug.cgi?id=1699410 to take into account the zoom factor] into when taking a screenshot</li> | |||
</ul> | |||
=This week I learned= | =This week I learned= | ||
<ul> | |||
<li>[agashlin] Windows [https://devblogs.microsoft.com/oldnewthing/20160108-00/?p=92821 FILE_FLAG_DELETE_ON_CLOSE] starts deleting when the first handle closes, but doesn't actually delete it until the last handle closes; it is inaccessible in between ([https://bugzilla.mozilla.org/show_bug.cgi?id=1696772 Bug 1696772])</li> | |||
<li>[florian] `TestUtils.waitForCondition` waits first 100ms (or the specified interval) before checking the condition for the first time. This implicit timer is a cause of several intermittent test failures when the condition isn’t exactly what the test needs, and the test relies on something happening during the initial timer. Attempting to change this behavior made 20+ intermittent failures become perma-fails. I’m [https://bugzilla.mozilla.org/show_bug.cgi?id=1596165 fixing] this.</li> | |||
<li>[florian] `BrowserTestUtils.openNewForegroundTab` awaits `BrowserTestUtils.switchTab` which also has an implicit [https://searchfox.org/mozilla-central/rev/4e87b5392eafe1f1d49017e76f7317b06ec0b1d8/browser/modules/AsyncTabSwitcher.jsm#88 300ms timer]</li> | |||
<li> | |||
[florian] EventUtils.synthesizeKey can sometimes trigger 2 “keypress” events instead of one, when the event is transmitted to remote content. | |||
<ul> | |||
<li>The Event object has [https://searchfox.org/mozilla-central/rev/be906232eedb22c064b78f3806b38964c04f1fbc/dom/webidl/Event.webidl#88-100 isWaitingReplyFromRemoteContent and isReplyEventFromRemoteContent attributes] that I didn’t know existed.</li> | |||
<li>Some intermittent failures are caused by a test waiting for a synthesized keypress event, and the next test receiving it too!</li> | |||
<li>Event.preventDefault() stops the event from being sent to the content process after having been handled by a listener in the parent.</li> | |||
</ul> | |||
</li> | |||
</ul> | |||