Confirmed users
975
edits
Performance/Fenix/Performance reviews: Difference between revisions
Performance/Fenix/Performance reviews (view source)
Revision as of 18:06, 14 October 2021
, 14 October 2021→Testing Start Up code: clarify location of measure_start_up.py
(nits) |
(→Testing Start Up code: clarify location of measure_start_up.py) |
||
| Line 5: | Line 5: | ||
To test start up code, the approach is usually simple: | To test start up code, the approach is usually simple: | ||
# | # From [https://github.com/mozilla-mobile/perf-tools the <code>mozilla-mobile/perf-tools</code> repository], use <code>measure_start_up.py</code>.<br>The arguments for start-up should include your target (<code>Fenix</code> or <code>Focus</code>). | ||
The arguments for start-up should include your target (<code>Fenix</code> or <code>Focus</code>). | |||
# Determine the start-up path that your code affects this could be: | # Determine the start-up path that your code affects this could be: | ||
## <code> Cold main first frame (cold_main_first_frame in the script) </code>. This is the first frame drawn by the application. This path is taken by all "type" of start-ups | ## <code> Cold main first frame (cold_main_first_frame in the script) </code>. This is the first frame drawn by the application. This path is taken by all "type" of start-ups | ||
| Line 27: | Line 26: | ||
'''NOTE''':For testing before and after to compare changes made to Fenix: repeat these steps, but this time for the code before the changes. Therefore, you could checkout the parent comment (I.e: using <code>git rev-parse ${SHA}^</code> where <code>${SHA}</code> is the first commit on the branch where the changes are) | '''NOTE''':For testing before and after to compare changes made to Fenix: repeat these steps, but this time for the code before the changes. Therefore, you could checkout the parent comment (I.e: using <code>git rev-parse ${SHA}^</code> where <code>${SHA}</code> is the first commit on the branch where the changes are) | ||
An example of using these steps to review a PR can be found ([https://github.com/mozilla-mobile/fenix/pull/20642#pullrequestreview-748204153 here]). | An example of using these steps to review a PR can be found ([https://github.com/mozilla-mobile/fenix/pull/20642#pullrequestreview-748204153 here]). | ||
== Testing non start-up changes == | == Testing non start-up changes == | ||