24
edits
(Broke out separate "Backing out" section) |
(Broke out a separate "Review" section) |
||
Line 91: | Line 91: | ||
* It may not always be <code>tip::tip</code> depending on what was necessary to fix the issue (say a BUILD.gn change, followed by moz.build generation, and those moz.build files committed in a separate commit). | * It may not always be <code>tip::tip</code> depending on what was necessary to fix the issue (say a BUILD.gn change, followed by moz.build generation, and those moz.build files committed in a separate commit). | ||
=== Backing out === | === Backing out === | ||
Line 100: | Line 99: | ||
hg revert third_party/libwebrtc && hg purge third_party/libwebrtc | hg revert third_party/libwebrtc && hg purge third_party/libwebrtc | ||
./mach python dom/media/webrtc/third_party_build/restore_patch_stack.py --repo-path .moz-fast-forward/moz-libwebrtc | ./mach python dom/media/webrtc/third_party_build/restore_patch_stack.py --repo-path .moz-fast-forward/moz-libwebrtc | ||
=== Review === | |||
* Simple changes don't require individual review, but if you'd feel better about getting reviewed, push the commit prior to elm (which will break all the builds). Then put the patch up for review. After r+, land it using Lando to elm. |
edits