Media/WebRTC/libwebrtc Update Process: Difference between revisions

Media/WebRTC/libwebrtc Update Process (view source)

11 bytes added , 30 June 2023

reword third category to: failure to regenerate build files

24

edits

@@ Line 64: / Line 64: @@
 === Operational notes ===
 * Running <code>prep-repo.sh</code> with a fresh github clone of moz-libwebrtc will likely display instructions on how to add recent moz-central changes made in <code>third_party/libwebrtc</code> to the top of the patch stack in github.  This is expected and necessary for successfully vendoring changes into <code>third_party/libwebrtc</code>.
-* Three main types of errors will cause <code>loop-ff.sh</code> to exit: the first is a git rebase conflict, the second is a build error due to changes in build (gn) scripts, the third is a build error due to API changes in upstream code.
+* Three main types of errors will cause <code>loop-ff.sh</code> to exit: the first is a git rebase conflict, the second is a failure to regenerate build files (due to BUILD.gn changes), the third is a build error due to API changes in upstream code.
 * When making changes to fix build issues in moz-libwebrtc (any changes under third_party/libwebrtc), mercurial commit messages follow the pattern:
   Bug {current-fast-forward-bug-number} - (fix-{upstream-sha}) {description}