139
edits
Media/WebRTC/Up-streaming Changes: Difference between revisions
Added RTC_CHECK
(Add Change-Id instructions) |
(Added RTC_CHECK) |
||
| Line 9: | Line 9: | ||
* To install the commit hook follow the instructions [https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html here]. | * To install the commit hook follow the instructions [https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html here]. | ||
* The Change-Id Docs can be found [https://gerrit-review.googlesource.com/Documentation/user-changeid.html here]. | * The Change-Id Docs can be found [https://gerrit-review.googlesource.com/Documentation/user-changeid.html here]. | ||
===Checking Out The Source=== | ===Checking Out The Source=== | ||
* Use the instructions [https://webrtc.github.io/webrtc-org/native-code/development/#getting-the-code here] to checkout the upstream repo if you have not already. | * Use the instructions [https://webrtc.github.io/webrtc-org/native-code/development/#getting-the-code here] to checkout the upstream repo if you have not already. | ||
==Running Tests== | ==Running Tests== | ||
* While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. | * While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. Inserting an RTC_CHECK(false), can be useful for verifying that one is testing using the correct binary. | ||
==Submitting Code== | ==Submitting Code== | ||
==Opening An up-stream Bug=== | ==Opening An up-stream Bug=== | ||