139
edits
Media/WebRTC/Up-streaming Changes: Difference between revisions
Media/WebRTC/Up-streaming Changes (view source)
Revision as of 19:22, 10 August 2023
, 10 August 2023Adding After The Code Is Landed Up-stream section
(Add pulling all heads info) |
(Adding After The Code Is Landed Up-stream section) |
||
| Line 13: | Line 13: | ||
==Running Tests== | ==Running Tests== | ||
* While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. Inserting an RTC_CHECK(false), can be useful for verifying that one is testing using the correct binary. | * While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. Inserting an RTC_CHECK(false), can be useful for verifying that one is testing using the correct binary. | ||
== | ==Code Submission Process== | ||
==Opening An up-stream Bug== | ===Writing A Unit Test=== | ||
* libwebrtc uses [http://webrtc-review.googlesource.com/ this Gerrit instance] to track bugs. | It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | ||
===Opening An up-stream Bug=== | |||
* libwebrtc uses [http://webrtc-review.googlesource.com/ this Gerrit instance] to track bugs. One will need to file a bug for one's fix under the appropriate component. In the bug one may mention that there is a fix that has been shipped in Firefox. Note the ID of the bug that Gerrit generated as one will need to use that ID in the commit message of your proposed fix. | |||
===Submitting An up-stream Patch=== | ===Submitting An up-stream Patch=== | ||
===Requesting A Reviewer=== | ===Requesting A Reviewer=== | ||
===Asking For CI Runs=== | ===Asking For CI Runs=== | ||
===After The Code Is Landed Up-stream=== | |||
Now that the code is landed up-stream there are two more steps that one needs perform. Firstly, in the Mozilla repo one will create a backout patch for the code that was up-streamed. Secondly, one will create a cherry-pick patch from the upstream release. | |||
==Tracking Progress== | ==Tracking Progress== | ||
There is a [https://docs.google.com/spreadsheets/d/1C9lg12ZQrctDU89zHB_bsni9pYTD7Ojos_7tq64Bjqs/edit#gid=0 spreadsheet] to track the progress of our in progress up-stream patches. | There is a [https://docs.google.com/spreadsheets/d/1C9lg12ZQrctDU89zHB_bsni9pYTD7Ojos_7tq64Bjqs/edit#gid=0 spreadsheet] to track the progress of our in progress up-stream patches. | ||