Mozilla2:Image Encoding: Difference between revisions

 
(5 intermediate revisions by 2 users not shown)
Line 4: Line 4:
Something like:
Something like:


  interface imgIEncoder : nsISupports
  interface imgIEncoder : nsIInputStream
  {
  {
   /* input image data
   /* input image data
    * output stream
     * result width
     * result width
     * result height
     * result height
     */
     */
   void encode(in imgIContainer input, in nsIOutputStream output,
   void init(in imgIContainer input,
              in unsigned long width, in unsigned long height);
            in unsigned long width, in unsigned long height);
  /* type of scaling */
  const unsigned long SCALE_BAD = 0;
  const unsigned long SCALE_NORMAL = 1;
  const unsigned long SCALE_GOOD = 2;
  attribute unsigned long scaling;
  };
  };
=== encode() method ===
Should we put width/height on the encode method?


=== Scaling ===
=== Scaling ===
Do we want to support different types of scaling?  I'm thinking we may not and may just want a solid good scaling algorithm that all encoders can use.
Do we want to support different types of scaling?  I'd prefer to just do nice Bicubic resampling. [http://members.bellatlantic.net/~vze2vrva/design.html] [http://astronomy.swin.edu.au/~pbourke/colour/bicubic/]


== Brendan's comments ==
=== Brendan's comments ===
A reader should get the bytes requested, if not greater than length of encoded image, and it's up to the encoder to buffer more if it encodes more bytes, reading from the buffer on next read.
A reader should get the bytes requested, if not greater than length of encoded image, and it's up to the encoder to buffer more if it encodes more bytes, reading from the buffer on next read.


Pure functions are best, so make height and width parameters, please.  Sure, you may store them internally (or something derived from them), but that doesn't mean that one-shot callers of encode should have to set two attributes first!


/be
This expresses the idea that the encoder is something you read from.


== Use ==
== Use ==
You would create one by doing:
You would create one by doing:
  createInstance("@mozilla.org/image/encoder;2?type=image/png");
  createInstance("@mozilla.org/image/encoder;2?type=image/png");
569

edits