Mozilla2:Image Encoding: Difference between revisions

 
Line 4: Line 4:
Something like:
Something like:


  interface imgIEncoder : nsISupports
  interface imgIEncoder : nsIInputStream
  {
  {
   /* input image data
   /* input image data
Line 10: Line 10:
     * result height
     * result height
     */
     */
   nsIInputStream encode(in imgIContainer input, in unsigned long width, in unsigned long height);
   void init(in imgIContainer input,
            in unsigned long width, in unsigned long height);
  };
  };
=== encode() method ===
Should we put width/height on the encode method?


=== Scaling ===
=== Scaling ===
Line 22: Line 20:
A reader should get the bytes requested, if not greater than length of encoded image, and it's up to the encoder to buffer more if it encodes more bytes, reading from the buffer on next read.
A reader should get the bytes requested, if not greater than length of encoded image, and it's up to the encoder to buffer more if it encodes more bytes, reading from the buffer on next read.


=== Darin's comments ===
Since imgIEncoder is something users CreateInstance, how about changing the interface to be something like this:
interface imgIEncoder : nsIInputStream
{
  void init(in imgIContainer input, in unsigned long width, in unsigned long height);
};


This expresses the idea that the encoder is something you read from.
This expresses the idea that the encoder is something you read from.
569

edits