Jetpack/Contribution: Difference between revisions
< Jetpack
Jump to navigation
Jump to search
(→Overview: Added link to the So You're Implementing a JEP guide) |
m (Changed some absolute-URL links to wikimo internal links) |
||
Line 2: | Line 2: | ||
* If you're implementing a JEP, see the [[Labs/Jetpack/So You're Implementing a JEP|So You're Implementing a JEP]] guide | * If you're implementing a JEP, see the [[Labs/Jetpack/So You're Implementing a JEP|So You're Implementing a JEP]] guide | ||
* Changes should follow the [ | * Changes should follow the [[Labs/Jetpack/Design_Guidelines|design guidelines]] for Jetpack | ||
* Changes should follow the [ | * Changes should follow the [[Labs/Jetpack/Reboot/Style_Guide|code style guide]] for Jetpack | ||
* All changes must be accompanied by tests | * All changes must be accompanied by tests | ||
* In order to land, patches must have review from a core Jetpack developer | * In order to land, patches must have review from a core Jetpack developer |
Revision as of 16:50, 3 May 2010
Overview
- If you're implementing a JEP, see the So You're Implementing a JEP guide
- Changes should follow the design guidelines for Jetpack
- Changes should follow the code style guide for Jetpack
- All changes must be accompanied by tests
- In order to land, patches must have review from a core Jetpack developer
- Patches should have additional API review when needed
- Patches should have additional review from a Mozilla platform domain-expert when needed
If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.
How to Make Code Contributions
If you have code that you'd like to contribute the Jetpack project, follow these steps:
- Look for your issue in the bugs already filed
- If no bug exists, file one here
- Make your changes, per the Overview
- Write a test (intro, API)
- Attach your code changes and tests in a combined patch to the bug
- Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in Reviewers below)
Reviewers
- All changes must be reviewed by Atul (avarma@mozilla.com), until the platform settles
- On top of Atul's review:
- For review of Mozilla platform usage and best practices, ask review from Drew (adw@mozilla.com), Myk (myk@mozilla.org) or Dietrich (dietrich@mozilla.com), and they can find the domain expert
- For API and developer ergonomics review, ask Myk (myk@mozilla.org)