Confirmed users
3,816
edits
Line 26: | Line 26: | ||
** Take your commit URL (from the github UI) and put that in a comment in bugzilla on the bug you're working on. | ** Take your commit URL (from the github UI) and put that in a comment in bugzilla on the bug you're working on. | ||
* If the feature is large - major refactoring, changes several files etc then make a patch. You specify which other branch your diffing from. So if we want to make a patch on our branch for the changes that we've made against the 1.4.2 branch then we do: | * If the feature is large - major refactoring, changes several files etc then make a patch. You specify which other branch your diffing from. So if we want to make a patch on our branch for the changes that we've made against the 1.4.2 branch then we do: | ||
** git format-patch | ** git format-patch 1.4.2 -U8 --stdout > mypatch.diff | ||
** This gives you a file mypatch.diff which you can now attach to a bug and ask for review. | ** This gives you a file mypatch.diff which you can now attach to a bug and ask for review. | ||