Confirmed users
3,816
edits
No edit summary |
|||
Line 52: | Line 52: | ||
== Ready for a review == | == Ready for a review == | ||
We want to diff your feature branch against the master branch. So ensure your master is up to date, and then: | |||
<pre> | <pre> | ||
git diff -U8 -p > mypatch.diff | git checkout myfeature // Switch to myfeature branch | ||
git diff -U8 -p master > mypatch.diff // Create the patch | |||
</pre> | </pre> | ||
Now, attach that patch to a bug in [http://bugzilla.mozilla.org Bugzilla] for review. Don't forget to set the "Review" flag to "?" and add one of the Mozmill module owners in the text box to the right. When in doubt, put in :ctalbert. | Now, attach that patch to a bug in [http://bugzilla.mozilla.org Bugzilla] for review. Don't forget to set the "Review" flag to "?" and add one of the Mozmill module owners in the text box to the right. When in doubt, put in :ctalbert. |