Platform/JS Compartments Mochitest: Difference between revisions

Platform/JS Compartments Mochitest (view source)

Revision as of 02:22, 6 October 2010

3,842 bytes added , 6 October 2010

→‎Mochichrome

Jorend

638

edits

@@ Line 195: / Line 195: @@
   chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul
- -> enumeration?
-Looking at this one next.
+Lots of different issues:
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over XOWs walks the prototype chain - got "host,hostname,port", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search"
+Enumeration bug. "for (e in location)" doesn't walk the prototype chain.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | wrapper iterators are properly iterators - got "object", expected "function,function,function,number,string,string,string,string,string,string,string,string"
+Enumeration bug. "Iterator(new XPCNativeWrapper(location))" is busted. I will look into this further.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over SJOWs walks the prototype chain and works over XOWs - got "", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search"
+Enumeration bug. Same kind of problem but here we're trying to iterate over iwin.wrappedObject.location.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | cyclic proto value allowed
+We do iwin.__proto__ = iwin and expect it to fail, but this just creates a new ordinary data property called __proto__ on the holder.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | iwin.eval does not throw an exception
+iwin.eval("'PASS'") must not throw an exception. But it is throwing.
+iwin.eval is undefined.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | Unable to wrap a primitive, even without 'new'
+An old feature we didn't retain.  XPCNativeWrapper("") is expected to return
+"". Maybe we can just remove the test.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | XPCNativeWrappers allow expandos through
+    let iwin = $('ifr').contentWindow;
+    let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
+        w.foopybar = 5;
+        ok(!("foopybar" in iwin), "XPCNativeWrappers allow expandos through");
+        ...
+XPCNativeWrappers must not allow expandos through. But they do.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | delete doesn't delete underlying properties - got undefined, expected 5
+    let iwin = $('ifr').contentWindow;
+    let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
+        ...
+        iwin.foopy = 5;
+        ok(delete w.foopy, "delete returns true");
+        is(iwin.foopy, 5, "delete doesn't delete underlying properties");
+Again, an XPCNativeWrapper must not allow chrome to delete expando
+properties. I'm not sure why we don't want to allow that, but we're allowing
+it.
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | allowed to update iwin.__proto__ to null - got [], expected null
+Possibly just noise. If I comment out the cyclic-__proto__ test, this one
+passes.
+But I can't imagine why iwin.__proto__ appears to be [] here. I looked, and the
+value we eventually return is a cross-compartment XrayWrapper of an
+OuterWindowProxy. The value should be null.
 -jorendorff, 10/5/2010
+I am also getting these failures:
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/layout/base/test/chrome/test_printpreview.xul | Timers should have run! - didn't expect "0 timers", but got it
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/layout/base/test/chrome/test_printpreview.xul | Timers should have run! - didn't expect 0, but got it
 = Browserchrome =