Confirmed users
839
edits
Platform/JS Compartments Mochitest: Difference between revisions
Platform/JS Compartments Mochitest (view source)
Revision as of 02:10, 14 October 2010
, 14 October 2010→Mochitest
| (48 intermediate revisions by 4 users not shown) | |||
| Line 18: | Line 18: | ||
Started build for QA to test. | Started build for QA to test. | ||
Fixed: | |||
* Adblock doesn't seem to filter (tries to call a function on undefined). | |||
* Adblock crashes. | |||
= xpcshell = | = xpcshell = | ||
| Line 43: | Line 48: | ||
= Mochitest = | = Mochitest = | ||
Pass. | |||
== Remaining large-ish items == | == Remaining large-ish items == | ||
| Line 50: | Line 55: | ||
* document.domain (we currently don't revoke access to the document's original domain, we probably should do that). | * document.domain (we currently don't revoke access to the document's original domain, we probably should do that). | ||
* Error hacks? | * Error hacks? | ||
* Fix error messages for property access denied. Old message included two origins, new one doesn't, and it looks like we're not using any of the localization that the old message had. Error console should show both origins, exception message probably (?) shouldn't. | * Fix error messages for property access denied. Old message included two origins, new one doesn't, and it looks like we're not using any of the localization that the old message had. Error console should show both origins, exception message probably (?) shouldn't. | ||
* Confirm that the fix in docshell/test/chrome/test_bug454235.xul is appropriate. | * Confirm that the fix in docshell/test/chrome/test_bug454235.xul is appropriate. | ||
| Line 56: | Line 60: | ||
FIXED issues: | FIXED issues: | ||
* I allow named frames to be created on xray wrappers so parent[name] works. | |||
* Fix up XrayWrappers | * Fix up XrayWrappers | ||
* Make chrome wrappers expose nothing by default | * Make chrome wrappers expose nothing by default | ||
| Line 67: | Line 72: | ||
* XPCNW holder objects vs JS_ClearScope() | * XPCNW holder objects vs JS_ClearScope() | ||
== Remaining test failures == | |||
<pre> | <pre> | ||
</pre> | </pre> | ||
Asserts to death: | |||
<pre> | <pre> | ||
</pre> | </pre> | ||
== | = Mochichrome = | ||
<pre> | <pre> | ||
</pre> | </pre> | ||
chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | |||
Lots of different issues: | |||
7257 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over XOWs walks the prototype chain - got "host,hostname,port", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search" | |||
Enumeration bug. "for (e in location)" doesn't walk the prototype chain. | |||
7259 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | wrapper iterators are properly iterators - got "object", expected "function,function,function,number,string,string,string,string,string,string,string,string" | |||
Enumeration bug. "Iterator(new XPCNativeWrapper(location))" is busted. I will look into this further. | |||
7261 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over SJOWs walks the prototype chain and works over XOWs - got "", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search" | |||
Enumeration bug. Same kind of problem but here we're trying to iterate over iwin.wrappedObject.location. | |||
7268 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | cyclic proto value allowed | |||
= | We do iwin.__proto__ = iwin and expect it to fail, but this just creates a new ordinary data property called __proto__ on the holder. | ||
7269 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | iwin.eval does not throw an exception | |||
iwin.eval("'PASS'") is supposed to succeed, but iwin.eval is undefined. | |||
7271 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | Unable to wrap a primitive, even without 'new' | |||
An old feature we didn't retain. XPCNativeWrapper("") is expected to return | |||
"". Maybe we can just remove the test. | |||
7276 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | XPCNativeWrappers allow expandos through | |||
7284 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | delete doesn't delete underlying properties - got undefined, expected 5 | |||
let iwin = $('ifr').contentWindow; | |||
let (w = new XPCNativeWrapper($('ifr').contentWindow)) { | |||
w.foopybar = 5; | |||
ok(!("foopybar" in iwin), "XPCNativeWrappers allow expandos through"); | |||
... | |||
iwin.foopy = 5; | |||
ok(delete w.foopy, "delete returns true"); | |||
is(iwin.foopy, 5, "delete doesn't delete underlying properties"); | |||
We create an explicit XPCNativeWrapper ''w'' around ''iwin'', a wrapper of an outer window. Expandos of ''w'' must not affect ''iwin'' and vice versa. | |||
I think the basic story here is "there are no same-compartment X-ray wrappers". | |||
7288 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | allowed to update iwin.__proto__ to null - got [], expected null | |||
Possibly just noise. If I comment out the cyclic-__proto__ test, this one | |||
passes. | |||
But I can't imagine why iwin.__proto__ appears to be [] here. I looked, and the | |||
value we eventually return is a cross-compartment XrayWrapper of an | |||
OuterWindowProxy. The value should be null. | |||
-jorendorff, 10/5/2010 | |||
= Browserchrome = | |||
Pass. | |||
= | = make check = | ||
Pass. | |||
= | = make jstestbrowser (jsreftest) = | ||
Pass. | |||