Platform/JS Compartments Mochitest: Difference between revisions

← Older edit

Platform/JS Compartments Mochitest (view source)

Revision as of 02:10, 14 October 2010

1,231 bytes added , 14 October 2010

→‎Mochitest

Jst

Confirmed users

839

edits

@@ Line 18: / Line 18: @@
 Started build for QA to test.
+Fixed:
+* Adblock doesn't seem to filter (tries to call a function on undefined).
+* Adblock crashes.
 = xpcshell =
@@ Line 43: / Line 48: @@
 = Mochitest =
-Run with <code>python runtests.py --total-chunks=20 --this-chunk=n --autorun --debugger=gdb</code> where <code>n</code> is the chunk you want to examine.
+Pass.
 == Remaining large-ish items ==
@@ Line 50: / Line 55: @@
 * document.domain (we currently don't revoke access to the document's original domain, we probably should do that).
 * Error hacks?
-* XPCSafeJSObjectWrapper::WrapObject() fails<br>    -> remove XPCSafeJSObjectWrapper
 * Fix error messages for property access denied. Old message included two origins, new one doesn't, and it looks like we're not using any of the localization that the old message had. Error console should show both origins, exception message probably (?) shouldn't.
 * Confirm that the fix in docshell/test/chrome/test_bug454235.xul is appropriate.
@@ Line 56: / Line 60: @@
 FIXED issues:
+* I allow named frames to be created on xray wrappers so parent[name] works.
 * Fix up XrayWrappers
 * Make chrome wrappers expose nothing by default
@@ Line 70: / Line 75: @@
 <pre>
-http://mochi.test:8888/tests/dom/tests/mochitest/general/test_windowProperties.html
+</pre>
-http://mochi.test:8888/tests/dom/tests/mochitest/bugs/test_bug346659.html
-http://mochi.test:8888/tests/dom/tests/mochitest/bugs/test_bug440572.html
-http://mochi.test:8888/tests/dom/tests/mochitest/whatwg/test_postMessage_onOther.html
-http://mochi.test:8888/tests/js/src/xpconnect/tests/mochitest/test_bug504877.html
+Asserts to death:
-probably related, but odd looking failures:
+<pre>
-http://mochi.test:8888/tests/toolkit/components/microformats/tests/test_Microformats.html
-http://mochi.test:8888/tests/toolkit/components/microformats/tests/test_Microformats_hCard.html
 </pre>
-== Chunk 1 ==
+= Mochichrome =
-pass, 22848 tests
+<pre>
+</pre>
-== Chunk 2 ==
+ chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul
-pass, 11244 tests:
+Lots of different issues:
-== Chunk 3 ==
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over XOWs walks the prototype chain - got "host,hostname,port", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search"
-pass, 14532 tests
+Enumeration bug. "for (e in location)" doesn't walk the prototype chain.
-== Chunk 4 ==
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | wrapper iterators are properly iterators - got "object", expected "function,function,function,number,string,string,string,string,string,string,string,string"
-passed, 19311 tests
+Enumeration bug. "Iterator(new XPCNativeWrapper(location))" is busted. I will look into this further.
-* test_play_twice.html is notoriously rando-orange, see {{bug|558812}} and {{bug|573232}}
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over SJOWs walks the prototype chain and works over XOWs - got "", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search"
-== Chunk 5 ==
+Enumeration bug. Same kind of problem but here we're trying to iterate over iwin.wrappedObject.location.
-pass, 4977 tests
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | cyclic proto value allowed
-== Chunk 6 ==
+We do iwin.__proto__ = iwin and expect it to fail, but this just creates a new ordinary data property called __proto__ on the holder.
-pass, 4825 tests
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | iwin.eval does not throw an exception
-== Chunk 7 ==
+iwin.eval("'PASS'") is supposed to succeed, but iwin.eval is undefined.
-pass, 194 tests
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | Unable to wrap a primitive, even without 'new'
-== Chunk 8 ==
+An old feature we didn't retain.  XPCNativeWrapper("") is expected to return
+"". Maybe we can just remove the test.
-pass, 346 tests
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | XPCNativeWrappers allow expandos through
-== Chunk 9 ==
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | delete doesn't delete underlying properties - got undefined, expected 5
+    let iwin = $('ifr').contentWindow;
+    let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
+        w.foopybar = 5;
+        ok(!("foopybar" in iwin), "XPCNativeWrappers allow expandos through");
+        ...
+        iwin.foopy = 5;
+        ok(delete w.foopy, "delete returns true");
+        is(iwin.foopy, 5, "delete doesn't delete underlying properties");
-pass, 159 tests
+We create an explicit XPCNativeWrapper ''w'' around ''iwin'', a wrapper of an outer window. Expandos of ''w'' must not affect ''iwin'' and vice versa.
-== Chunk 10 ==
+I think the basic story here is "there are no same-compartment X-ray wrappers".
-pass, 396 tests
+ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | allowed to update iwin.__proto__ to null - got [], expected null
-== Chunk 11 ==
+Possibly just noise. If I comment out the cyclic-__proto__ test, this one
+passes.
-pass, 234 tests
+But I can't imagine why iwin.__proto__ appears to be [] here. I looked, and the
+value we eventually return is a cross-compartment XrayWrapper of an
+OuterWindowProxy. The value should be null.
-== Chunk 12 ==
+-jorendorff, 10/5/2010
-pass, 396 tests
+= Browserchrome =
-== Chunk 13 ==
+Pass.
-pass, 458 tests
+= make check =
-== Chunk 14 ==
-pass, 482 tests
-== Chunk 15 ==
-pass, 491 tests
-== Chunk 16 ==
-pass, 7163 tests
-== Chunk 17 ==
-failed, 573 tests (sloooooooooow to run)
+Pass.
-This test fails but it looks like a bad test. It enables UniversalXPConnect and then complains that it can do cross origin access.
+= make jstestbrowser (jsreftest) =
-<pre>
-http://mochi.test:8888/tests/js/src/xpconnect/tests/mochitest/test_bug504877.html
-</pre>
-== Chunk 18 ==
-pass, 5073 tests
-== Chunk 19 ==
-pass, 89415 tests
-* bent: I fixed test_pluginstream_newstream.html so that it will work, but the underlying cause is a change in our access denied exception messages, which needs to get fixed. Followup bug?
-== Chunk 20 ==
-pass, 17909 tests
-= Mochichrome =
-failing tests, in these files:
-<pre>
-chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_cows.xul
-chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_evalInSandbox.xul
- -> add a function that the sandbox can call which forwards to getClassName
-chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul
-  -> enumeration?
-chrome://mochikit/content/chrome/layout/base/test/chrome/test_printpreview.xul
-</pre>
-= Browserchrome =
-= make check =
-Passes
+Pass.