Confirmed users
14,525
edits
QA/Mozmill Test Automation/Test Modules Refactor: Difference between revisions
QA/Mozmill Test Automation/Test Modules Refactor (view source)
Revision as of 18:55, 8 November 2010
, 8 November 2010→Style Guidelines
No edit summary |
|||
| Line 52: | Line 52: | ||
** const SOME_CONSTANT = value; | ** const SOME_CONSTANT = value; | ||
* Geo: All ''unchanging'' variables as constants | * Geo: All ''unchanging'' variables as constants | ||
; Function Signatures | |||
* Proposed Guidelines: | |||
** var nameOfFunction = function() { | |||
* Geo: Agree on open-brace on same line but common in JS to have an next-line exception for named functions; could go either way. | |||
; ''module'' as a param for setupModule & teardownModule | |||
* Proposed Guidelines: | |||
** ??? | |||
* Geo: Strange to have a function not declare a parameter that’s actually being supplied, but maybe that’s more normal in JS. | |||
* Henrik: Removing module was probably a mistake; used for injecting global functions into the module scope. | |||