QA/Mozmill Test Automation/Test Modules Refactor: Difference between revisions

no edit summary
No edit summary
Line 29: Line 29:
== Summary ==
== Summary ==
The purpose of this project is to ensure all tests are implemented using an agreed style guideline.  The workflow of this project will mostly be parallel with the Shared Modules Refactor project.  This project will be rolled out in multiple phases.
The purpose of this project is to ensure all tests are implemented using an agreed style guideline.  The workflow of this project will mostly be parallel with the Shared Modules Refactor project.  This project will be rolled out in multiple phases.
== Phase I ==
Goal: Refactor "lowest-hanging-fruit" changes<br>
Dependencies: Agreed upon style guidelines
== Refactoring  ==
; Timeouts & Delays
* gDelay: replace with a discrete int value
* gTimeout: replace with TIMEOUT
; Constants
* const SOME_CONST = value;
; setupModule & teardownModule
* Remove ''module'' parameter
; Mozilla Components
* Ensure proper alignment of getService() on Cc[]
; Local Test Pages
* Replace any LOCAL_PAGE or LOCAL_TEST_PAGE with a LOCAL_TEST_PAGES array
* Each array element should have at least a URL and ID member
; Arrays
* Ensure proper alignment from style guidelines
; Assertions
* waitForEval: replace with waitFor()


== Style Guidelines ==
== Style Guidelines ==
Line 228: Line 200:
** things we lock down because alternatives are risky (array.forEach)
** things we lock down because alternatives are risky (array.forEach)
* Aaron: We should offer style guidelines on the license block
* Aaron: We should offer style guidelines on the license block
== Refactoring  ==
; Timeouts & Delays
* gDelay: replace with a discrete int value
* gTimeout: replace with TIMEOUT
; Constants
* const SOME_CONST = value;
; setupModule & teardownModule
* Remove ''module'' parameter
; Mozilla Components
* Ensure proper alignment of getService() on Cc[]
; Local Test Pages
* Replace any LOCAL_PAGE or LOCAL_TEST_PAGE with a LOCAL_TEST_PAGES array
* Each array element should have at least a URL and ID member
; Arrays
* Ensure proper alignment from style guidelines
; Assertions
* waitForEval: replace with waitFor()
Confirmed users
14,525

edits