canmove, Confirmed users, Bureaucrats and Sysops emeriti
4,714
edits
QA/Mozmill Test Automation/Test Modules Refactor: Difference between revisions
QA/Mozmill Test Automation/Test Modules Refactor (view source)
Revision as of 05:34, 9 November 2010
, 9 November 2010→Draft
(→Draft) |
(→Draft) |
||
| Line 80: | Line 80: | ||
} | } | ||
</pre> | </pre> | ||
* Henrik: We should completely avoid anonymous functions | |||
8. Function Usage | 8. Function Usage | ||
| Line 89: | Line 91: | ||
); | ); | ||
</pre> | </pre> | ||
* Henrik: Indent by 2 vs. aligned by opening bracket | |||
9. Function Parameter Concatenation | 9. Function Parameter Concatenation | ||
| Line 98: | Line 102: | ||
); | ); | ||
</pre> | </pre> | ||
* Henrik: Same here | |||
10. waitFor() block-style | 10. waitFor() block-style | ||
| Line 105: | Line 111: | ||
}, "Some error message", TIMEOUT); | }, "Some error message", TIMEOUT); | ||
</pre> | </pre> | ||
* Henrik: We should check how we want to handle long message strings | |||
11. XPath: split on '/' | 11. XPath: split on '/' | ||
| Line 120: | Line 128: | ||
</pre> | </pre> | ||
* Geo: This keeps it mostly aligned with the actual structure. When we pull it back to the 0-column, makes things that are variables decls look like flow control structures instead, and I really don’t like that. | * Geo: This keeps it mostly aligned with the actual structure. When we pull it back to the 0-column, makes things that are variables decls look like flow control structures instead, and I really don’t like that. | ||
* Henrik: Inside function calls we should probably align with the opening bracket. | |||
13. Component declarations should be indented in line with the parent | 13. Component declarations should be indented in line with the parent | ||
| Line 142: | Line 151: | ||
} "Some message", TIMEOUT); | } "Some message", TIMEOUT); | ||
</pre> | </pre> | ||
* Henrik: | * Henrik: A timeout like 5s doens't have be specified anymore - it's the default now. | ||
* Geo: Use default params where appropriate, wrapper functions where not | * Geo: Use default params where appropriate, wrapper functions where not | ||
| Line 220: | Line 229: | ||
29. License block | 29. License block | ||
* Aaron: We should define a style guideline for the license block | * Aaron: We should define a style guideline for the license block | ||
* Henrik: Style guideline for what? | |||
30. Things the style guide should cover | 30. Things the style guide should cover | ||