Confirmed users
14,525
edits
(8 intermediate revisions by the same user not shown) | |||
Line 14: | Line 14: | ||
|- valign="top" | |- valign="top" | ||
| '''Status:''' | | '''Status:''' | ||
| | | '''on hold''' | ||
|- valign="top" | |- valign="top" | ||
| '''Repository Location:''' | | '''Repository Location:''' | ||
Line 71: | Line 71: | ||
| {{bug|}} | | {{bug|}} | ||
| All error messages use format: | | All error messages use format: | ||
* | * message + " - got " + condition1 + ", expected " + condition2 | ||
* ''message'' uses positive wording | |||
|- | |- | ||
| {{bug|}} | | {{bug|}} | ||
Line 100: | Line 101: | ||
| {{bug|}} | | {{bug|}} | ||
| Adopt consistent conditional cuddling | | Adopt consistent conditional cuddling | ||
|- | |||
| {{bug|}} | |||
| All included modules should use variable names starting with capital | |||
|- | |||
| {{bug|}} | |||
| All conditionals use !== or === | |||
|} | |} | ||
Line 110: | Line 117: | ||
Discussion [http://mozqa.ietherpad.com/refactor-discussion here] | Discussion [http://mozqa.ietherpad.com/refactor-discussion here] | ||
; | ; Generally Agreed | ||
* | * We should always use the triple operator to not experience strange behavior | ||
** | ** ===/!== instead of ==/!= | ||
* Variables for imported modules have to start with a capital letter | |||
** i.e. var Tabs = require(".../tabs") | |||
* Class names have to start with a capital letter | |||
* setupModule(module) and teardownModule(module) have to specify the module parameter | |||
* If variable name contains an acronym, capitalize the acronym | |||
* Error messages should use the following format: | |||
** Boolean: "<element> is <state>." | |||
** Value: "<element> is <state>: got 'value', expected 'value'" | |||
** Example: "Password notification is visible" | |||
** Example: "mozilla.org is loaded: got '<loaded_domain>', expected 'mozilla.org'" | |||
* sleep() should be avoided and only used when... | |||
** element is not immediately available | |||
** state is not immediately available | |||
** waitFor() fails to capture event | |||
* | |||
* | |||
* | |||
* | |||
* | |||
< | |||
" | |||
" | |||
< | |||
* | |||
* | |||
* | |||
* | |||
* | |||
* | |||
* | |||
; | ; Needs Discussion | ||
* TestFilesAPI for loading of test files | |||
* | ** We should have a module specific to loading of test files | ||
* | ** We should also check how we can make sure those locations are easily replacable with other servers (apache, ...) | ||
* | * Parameters should be named using aParam format | ||
* | ** shows that a variable inside a long function is a parameter and hasn't been declared locally | ||
* | * Constant scope - should they be global and local? | ||
* |