Confirmed users, Bureaucrats and Sysops emeriti
722
edits
User:GavinSharp/Code Review: Difference between revisions
→Specifics
GavinSharp (talk | contribs) |
GavinSharp (talk | contribs) |
||
| Line 33: | Line 33: | ||
** consistent code style should be a means, not an end | ** consistent code style should be a means, not an end | ||
** rather than asking "does this match our coding style guidelines", ask "is this code hard to read" | ** rather than asking "does this match our coding style guidelines", ask "is this code hard to read" | ||
*** if you can't appreciate the distinction between those two questions, try harder :) | |||
* does the patch have performance implications? | * does the patch have performance implications? | ||
** hot paths (e.g. startup, pageload) | ** hot paths (e.g. startup, pageload) | ||