Jetpack/Contribution: Difference between revisions
< Jetpack
Jump to navigation
Jump to search
m (moved Labs/Jetpack/Contribution to Jetpack/Contribution) |
(make Alex a reviewer) |
||
Line 23: | Line 23: | ||
* All changes must be reviewed by someone on the Jetpack review crew: | * All changes must be reviewed by someone on the Jetpack review crew: | ||
** Alex (apoirot@mozilla.com, in bugzilla: poirot.alex@gmail.com) | |||
** Atul (avarma@mozilla.com) | ** Atul (avarma@mozilla.com) | ||
** Brian (warner@mozilla.com, in bugzilla: warner-bugzilla@lothar.com) | ** Brian (warner@mozilla.com, in bugzilla: warner-bugzilla@lothar.com) |
Revision as of 16:04, 15 July 2011
Overview
- Changes should follow the design guidelines for Jetpack
- All changes must be accompanied by tests
- In order to land, patches must have review from a core Jetpack developer
- Patches should have additional API review when needed
- Patches should have additional review from a Mozilla platform domain-expert when needed
If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.
How to Make Code Contributions
If you have code that you'd like to contribute the Jetpack project, follow these steps:
- Look for your issue in the bugs already filed
- If no bug exists, file one here
- Make your changes, per the Overview
- Write a test (intro, API)
- Attach your code changes and tests in a combined patch to the bug
- Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in Reviewers below)
Reviewers
- All changes must be reviewed by someone on the Jetpack review crew:
- Alex (apoirot@mozilla.com, in bugzilla: poirot.alex@gmail.com)
- Atul (avarma@mozilla.com)
- Brian (warner@mozilla.com, in bugzilla: warner-bugzilla@lothar.com)
- Dietrich (dietrich@mozilla.com)
- Drew (adw@mozilla.com)
- Irakli (gozala@mozilla.com, in bugzilla: rFobic@gmail.com)
- Myk (myk@mozilla.org)
- Will (wbamberg@mozilla.com)
- For review of Mozilla platform usage and best practices, ask Dietrich, Drew, or Myk to find the domain expert.
- For API and developer ergonomics review, ask Myk.