Confirmed users
586
edits
Fennec/NativeUI/PanZoom: Difference between revisions
no edit summary
No edit summary |
No edit summary |
||
| Line 7: | Line 7: | ||
* Page size is set by monkey patching content CSS. This is not only ugly but may fail if the page overrides it. The correct solution to this is non-e10s SetDisplayPort, coupled with SetCSSViewport (the latter of which works now, but is useless without a display port because it clips at the viewport). | * Page size is set by monkey patching content CSS. This is not only ugly but may fail if the page overrides it. The correct solution to this is non-e10s SetDisplayPort, coupled with SetCSSViewport (the latter of which works now, but is useless without a display port because it clips at the viewport). | ||
* Sometimes the scale gesture detection gets confused and the page ends up very tiny or very big. Cause unknown, possibly due to incorrect interaction between the scale gesture detector and the panning code. | * Sometimes the scale gesture detection gets confused and the page ends up very tiny or very big. Cause unknown, possibly due to incorrect interaction between the scale gesture detector and the panning code. | ||
* When zoomed in far, the physics doesn't feel smooth. This is due to integer truncation happening too early. | * <strike>When zoomed in far, the physics doesn't feel smooth. This is due to integer truncation happening too early.</strike> (http://hg.mozilla.org/users/pwalton_mozilla.com/birch-pan-zoom/rev/7c8a6e137ff8) | ||
* Pages like Fennec Start and Google are smaller than the screen. | * Pages like Fennec Start and Google are smaller than the screen. | ||
* We don't start zoomed out to the width of the device. | * We don't start zoomed out to the width of the device. | ||
| Line 14: | Line 14: | ||
* Zooming is broken; the page never rerenders. This is due to the lack of non-e10s SetResolution. It may be possible to work around this with CSS transforms, but they will create redraw lag. | * Zooming is broken; the page never rerenders. This is due to the lack of non-e10s SetResolution. It may be possible to work around this with CSS transforms, but they will create redraw lag. | ||
* Flicker when Gecko loads. | * Flicker when Gecko loads. | ||
* The saved screenshot doesn't always appear in the right part of the page. Page size is not saved. This is because we only save a screenshot, while we actually need to save some more info (page size, etc.) in order to pan and zoom during load. {{bug|700667}} | * <strike>The saved screenshot doesn't always appear in the right part of the page. Page size is not saved. This is because we only save a screenshot, while we actually need to save some more info (page size, etc.) in order to pan and zoom during load.</strike> {{bug|700667}} | ||
* Chews through battery because it's trying to consistently render at 60 fps regardless of whether work needs to be done. | * Chews through battery because it's trying to consistently render at 60 fps regardless of whether work needs to be done. | ||
* <strike>Physics are wrong when overscrolling, particularly diagonally (too long of a delay before bouncing back).</strike> (fixed with fastersnap patch) | * <strike>Physics are wrong when overscrolling, particularly diagonally (too long of a delay before bouncing back).</strike> (fixed with fastersnap patch) | ||
| Line 20: | Line 20: | ||
** <strike>Under some conditions when two fingers are on the page, removing one will cause the page to snap-pan</strike> (fixed in panzoomfixups patch) | ** <strike>Under some conditions when two fingers are on the page, removing one will cause the page to snap-pan</strike> (fixed in panzoomfixups patch) | ||
** Touch down on a link, pan the page, and then touch up will trigger that link (need to figure out which events should actually be delivered to non-java code) | ** Touch down on a link, pan the page, and then touch up will trigger that link (need to figure out which events should actually be delivered to non-java code) | ||
* Different tabs can't have different zoom states {{bug|700654}} | * <strike>Different tabs can't have different zoom states</strike> {{bug|700654}} | ||