Confirmed users
313
edits
Toolkit/Code Review: Difference between revisions
→Help, my patch isn't being reviewed
No edit summary |
|||
| (One intermediate revision by the same user not shown) | |||
| Line 4: | Line 4: | ||
* Patches that make behavioral or API changes to Toolkit should either be reviewed by the sub-module owner or at least get feedback from them in addition to review by a Toolkit reviewer. | * Patches that make behavioral or API changes to Toolkit should either be reviewed by the sub-module owner or at least get feedback from them in addition to review by a Toolkit reviewer. | ||
* Significant UI changes should flag ux-review@mozilla.com for UI review, as well as review from an appropriate code reviewer. There is [https://developer.mozilla.org/En/Developer_Guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes more information on UI reviews and feedback from the UX team | * Significant UI changes should flag ux-review@mozilla.com for UI review, as well as review from an appropriate code reviewer. There is [https://developer.mozilla.org/En/Developer_Guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes more information on UI reviews and feedback from the UX team on devmo]. | ||
* Super-review is required where required by the [http://www.mozilla.org/hacking/reviewers.html mozilla.org super-review policy]. | * Super-review is required where required by the [http://www.mozilla.org/hacking/reviewers.html mozilla.org super-review policy]. | ||
| Line 62: | Line 62: | ||
A poke in the bug can help, or direct email to the designated reviewer. If that doesn't work, please [mailto:dtownsend@oxymoronical.com mail Mossop] for assistance. | A poke in the bug can help, or direct email to the designated reviewer. If that doesn't work, please [mailto:dtownsend@oxymoronical.com mail Mossop] for assistance. | ||
Are you looking for UI review or feedback but not getting it? Make sure to flag ux-review@mozilla.com for your UI-review/feedback request and [https://developer.mozilla.org/En/Developer_Guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes it should be answered within 48 hours]. | |||