|
|
| (15 intermediate revisions by 7 users not shown) |
| Line 1: |
Line 1: |
| = Overview =
| | Moved over to https://github.com/mozilla/addon-sdk/wiki/contribute |
| | |
| * Changes should follow the [https://wiki.mozilla.org/Labs/Jetpack/Design_Guidelines design guidelines] for Jetpack
| |
| * Changes should follow the [https://wiki.mozilla.org/Labs/Jetpack/Reboot/Style_Guide code style guide] for Jetpack
| |
| * All changes must be accompanied by tests
| |
| * In order to land, patches must have review from a core Jetpack developer
| |
| * Patches should have additional API review when needed
| |
| * Patches should have additional review from a Mozilla platform domain-expert when needed
| |
| | |
| If you have questions, ask in [irc://irc.mozilla.org/#jetpack #jetpack on IRC] or on the [http://groups.google.com/group/mozilla-labs-jetpack Jetpack mailing list].
| |
| | |
| = How to Make Code Contributions =
| |
| | |
| If you have code that you'd like to contribute the Jetpack project, follow these steps:
| |
| | |
| # Look for your issue in the [https://bugzilla.mozilla.org/buglist.cgi?quicksearch=component%3Ajetpack bugs already filed]
| |
| # If no bug exists, [https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Labs&component=Jetpack%20SDK file one here]
| |
| # Make your changes, per the [[Labs/Jetpack/Contribution#Overview|Overview]]
| |
| # Write a test ([https://jetpack.mozillalabs.com/sdk/latest/docs/#guide/packaging intro], [https://jetpack.mozillalabs.com/sdk/latest/docs/#module/jetpack-core/unit-test API])
| |
| # Attach your code changes and tests in a combined patch to the bug
| |
| # Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in [[Labs/Jetpack/Contribution#Reviewers|Reviewers]] below)
| |
| | |
| = Reviewers =
| |
| | |
| * All changes must be reviewed by Atul, until the platform settles
| |
| * On top of Atul's review:
| |
| ** For review of Mozilla platform usage and best practices, ask review from Drew, Myk or Dietrich (and they can find the domain expert)
| |
| ** For API and developer ergonomics review, ask Myk
| |