272
edits
Thunderbird:CodeCleanup: Difference between revisions
no edit summary
No edit summary |
No edit summary |
||
| Line 29: | Line 29: | ||
Bad: | Bad: | ||
nsCOMPtr<nsISupportsArray> identityArray; | nsCOMPtr<nsISupportsArray> identityArray; | ||
nsCOMPtr<nsIMsgIdentity> identity; | nsCOMPtr<nsIMsgIdentity> identity; | ||
rv = identityArray->QueryElementAt(index, NS_GET_IID(nsIMsgIdentity), | rv = identityArray->QueryElementAt(index, NS_GET_IID(nsIMsgIdentity), | ||
(void **)getter_AddRefs(identity)); | (void **)getter_AddRefs(identity)); | ||
or | or | ||
nsCOMPtr<nsISupports> thisElement; | nsCOMPtr<nsISupports> thisElement; | ||
identityArray->GetElementAt(index, getter_AddRefs(thisElement)); | identityArray->GetElementAt(index, getter_AddRefs(thisElement)); | ||
nsCOMPtr<nsIMsgIdentity> identity = do_QueryInterface(thisElement, &rv); | nsCOMPtr<nsIMsgIdentity> identity = do_QueryInterface(thisElement, &rv); | ||
Good: | Good: | ||
nsCOMPtr<nsIMsgIdentity> identity( do_QueryElementAt(identityArray, i, &rv)); | nsCOMPtr<nsIMsgIdentity> identity( do_QueryElementAt(identityArray, i, &rv)); | ||