canmove, Confirmed users
1,220
edits
Security/Reviews/Gaia/system/code: Difference between revisions
→Relevant Source Code
Ptheriault (talk | contribs) |
Ptheriault (talk | contribs) |
||
| Line 45: | Line 45: | ||
*bluetooth_transfer.js: Handles an individual transfer, including displaying confirm prompt to the user | *bluetooth_transfer.js: Handles an individual transfer, including displaying confirm prompt to the user | ||
Note: Bluetooth file, and metadata (filename etc) could be malicious, but code uses CustomDialog (http://mxr.mozilla.org/gaia/source/shared/js/custom_dialog.js#5) which uses textContent and createTextNode to prevent injection. Also uses filename for notifications which is similarly protected. | |||
*bootstrap.js: Random startup tasks, including checking for updates. Not too much to review here. Sets the wallpaper for all home screens. | *bootstrap.js: Random startup tasks, including checking for updates. Not too much to review here. Sets the wallpaper for all home screens. | ||
| Line 68: | Line 68: | ||
*captive_portal.js: Code looks ok, but could do with some testing. | *captive_portal.js: Code looks ok, but could do with some testing. | ||
Todo: test this on to see what attack vector from a rogue wireless network. | Todo: test this on to see what attack vector from a rogue wireless network. | ||
*cards_view.js: Main app UI management. There have been lots of bugs in the past where background apps could interfere with the foreground app. | *cards_view.js: Main app UI management. There have been lots of bugs in the past where background apps could interfere with the foreground app. All closed now, but will be an area to keep an eye with future changes. | ||
*context_menu.js: Simple menu helper class. | *context_menu.js: Simple menu helper class. | ||
| Line 89: | Line 89: | ||
*icc_cache.js: Sim Toolkit message handler? | *icc_cache.js: Sim Toolkit message handler? | ||
*identity.js Persona implementation for the phone. See here for detailed review: [[Security/Reviews/Gaia/system/identity.js]] | *identity.js Persona implementation for the phone. See here for detailed review: [[Security/Reviews/Gaia/system/identity.js]] | ||
*init_logo_handler.js: loads animated logo at power on. | *init_logo_handler.js: loads animated logo at power on. | ||
*keyboard_manager.js: Manages the keyboard. Currently just embeds keyboard app, but in future will allow for changing of keyboard apps. | *keyboard_manager.js: Manages the keyboard. Currently just embeds keyboard app, but in future will allow for changing of keyboard apps. | ||
| Line 143: | Line 140: | ||
} | } | ||
</code> | </code> | ||
However currently selectone is not implemented. Raised bug just in case this changes in the future: https://bugzilla.mozilla.org/show_bug.cgi?id=850554 | |||
*mouse2touch.js: shim to support | *mouse2touch.js: shim to support | ||
| Line 149: | Line 148: | ||
UI to display notifications. Uses DOM methods not innerHTML - hooray! | UI to display notifications. Uses DOM methods not innerHTML - hooray! | ||
*payment.js | *payment.js: needs its own review probably: [[Security/Reviews/Gaia/system/payment.js]] | ||
*permission_manager.js:Handles prompting for permissions. Handles fullscreen requests as well. | *permission_manager.js:Handles prompting for permissions. Handles fullscreen requests as well. | ||
*popup_manager.js | *popup_manager.js | ||
| Line 168: | Line 165: | ||
*screenshot.js | *screenshot.js | ||
Takes a screen shot when user press both home and power buttons. | Takes a screen shot when user press both home and power buttons. | ||
*sim_lock.js | *sim_lock.js | ||
| Line 181: | Line 178: | ||
*source_view.js | *source_view.js | ||
Possibly should be removed. | |||
*statusbar.js | *statusbar.js | ||
| Line 206: | Line 204: | ||
*utility_tray.js | *utility_tray.js | ||
tray that gets dragged down from top of screen. | |||
*value_selector | *value_selector | ||
Code to create widgets for date selectors or select wheels etc. | |||
*voicemail.js | *voicemail.js | ||
| Line 214: | Line 214: | ||
*window.js | *window.js | ||
see bug 854849 | |||
*wrapper.js | *wrapper.js | ||