AwesomebarSearchProviderReset/TestPlan: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
 
(17 intermediate revisions by the same user not shown)
Line 1: Line 1:
= Awesomebar Search Provider Reset =
= Consolidate search preferences =


{| class="fullwidth-table"
{| class="fullwidth-table"
Line 10: Line 10:
| QA Status  
| QA Status  
|-
|-
| Awesomebar Search Provider Reset
| Consolidate search preferences
| {{StatusHealthy|status=Landed}}
| {{StatusHealthy|status=Landed}}
| Firefox 19
| Firefox 23
| Gavin Sharp
| Gavin Sharp
| Manuela Muntean
| Manuela Muntean
Line 20: Line 20:
== Summary ==
== Summary ==


Users falling victim to "search hijacking" (keyword.URL being taken over by an unwanted search engine) is a common problem.
* keyword.URL and originalDefaultEngine preferences have been removed
 
* When setting an engine in the Search bar, it is also set as the search engine for the URL bar, about:home (after reload) and in the contextual menu option
There are two cases we can detect:
*pref is changed, and the hostname is different (e.g. switched from the default of Google to SuperAwesomeWebDealsSearch.com)
*pref is changed, and only parameters are different (e.g. user customized to a specific type of Google search, or referral codes where added)
 
In either case, we could prompt the user and offer to reset the keyword.URL value to the default after they trigger a search from the location bar.
 
*[https://bug718088.bugzilla.mozilla.org/attachment.cgi?id=600146 Screenshot of notification]


== Reference ==
== Reference ==


*{{Bug|718088}} - offer to re-set keyword.URL if it has a non-default value - '''RESOLVED FIXED'''
*{{Bug|738818}} - consolidate Firefox search preferences - '''VERIFIED FIXED'''


== Use Cases to Test ==
== Use Cases to Test ==


Test that the notification which prompts the user is displayed when
*manually changing keyword.URL pref from "about:config", and then actually performing a keyword search
*installing an add-on that automatically changes the keyword.URL pref, and then actually performing a keyword search


== Test Cases  ==
* (1) after changing the engine from the search bar, make sure that the new engine is the one used for searches from: the URL bar, the about:home page (after reload or restart), the contextual menu option
* all changes from (1) are applied for one or multiple Firefox windows open
* all changes from (1) are applied for private browsing also
* all changes from (1) are applied with both the engines Firefox comes with and the engines installed by the user
* check that keyword.URL and originalDefaultEngine preferences have been removed


* Test cases and test results can be seen in the [http://bit.ly/1404VTE Google Spreadsheet]
* They are also present in MozTrap, in the Awesomebar Search Provider Reset test suite.


==Bugs ==
== Test Cases  ==


*{{Bug|732671}} - Prevent third party apps to change default search engine - '''RESOLVED DUPLICATE'''
* Test cases are available in MozTrap, under the "Consolidate search preferences" test suite: https://moztrap.mozilla.org/manage/cases/?filter-suite=329
*{{Bug|784189}} - Offer to re-set keyword.URL if it has a non-default value until a better solution can be found - '''RESOLVED DUPLICATE'''
*{{Bug|736878}} - keyword.URL reset prompt doesn't properly re-set prefs if default engine is modified - '''RESOLVED FIXED'''
*{{Bug|744957}} - Enhancements to help mitigate search hijacking - '''RESOLVED INCOMPLETE'''
*{{Bug|838864}} -


== Sign off ==
== Sign off ==


;Criteria
;Criteria
*All the test cases were executed.
*All the use cases were executed.
*All the blocker, critical, major bugs have been fixed.
*All the blocker, critical, major bugs have been fixed.


;Firefox 19 beta 5 - 2013-02-07
 
*Regarding the following add-ons installation:
;Firefox 23 Aurora (pre-beta sign off) - 06/21/2013
 
* On the next OSs:
** Windows 7 64bit
** Windows 8 32bit
** Ubuntu 12.10 32bit
** Mac OSX 10.8.3
 
*Concerns:
*{{Bug|885351}} - Google is always used in about:home and the URL bar when setting the default search engine to an invalid one - '''NEW'''
*{{Bug|880882}} - handle migration of search preferences on upgrade to Firefox 23  - '''NEW'''
** Note:
*** when choosing an engine different from Google in the search bar (for example Bing) in Aurora 22 and then updating to Aurora 23, only the search made from the search bar and from the contextual menu option is made with Bing; the search performed from the URL bar and about:home page are still made with Google (browser.search.defaultenginename is set to Google)

Latest revision as of 12:23, 27 June 2013

Consolidate search preferences

Feature Status Release Target Lead engineer QA Lead QA Status
Consolidate search preferences Landed Firefox 23 Gavin Sharp Manuela Muntean Signed Off

Summary

  • keyword.URL and originalDefaultEngine preferences have been removed
  • When setting an engine in the Search bar, it is also set as the search engine for the URL bar, about:home (after reload) and in the contextual menu option

Reference

  • bug 738818 - consolidate Firefox search preferences - VERIFIED FIXED

Use Cases to Test

  • (1) after changing the engine from the search bar, make sure that the new engine is the one used for searches from: the URL bar, the about:home page (after reload or restart), the contextual menu option
  • all changes from (1) are applied for one or multiple Firefox windows open
  • all changes from (1) are applied for private browsing also
  • all changes from (1) are applied with both the engines Firefox comes with and the engines installed by the user
  • check that keyword.URL and originalDefaultEngine preferences have been removed


Test Cases

Sign off

Criteria
  • All the use cases were executed.
  • All the blocker, critical, major bugs have been fixed.


Firefox 23 Aurora (pre-beta sign off) - 06/21/2013
  • On the next OSs:
    • Windows 7 64bit
    • Windows 8 32bit
    • Ubuntu 12.10 32bit
    • Mac OSX 10.8.3
  • Concerns:
  • bug 885351 - Google is always used in about:home and the URL bar when setting the default search engine to an invalid one - NEW
  • bug 880882 - handle migration of search preferences on upgrade to Firefox 23 - NEW
    • Note:
      • when choosing an engine different from Google in the search bar (for example Bing) in Aurora 22 and then updating to Aurora 23, only the search made from the search bar and from the contextual menu option is made with Bing; the search performed from the URL bar and about:home page are still made with Google (browser.search.defaultenginename is set to Google)
Retrieved from "https://wiki.allizom.org/index.php?title=AwesomebarSearchProviderReset/TestPlan&oldid=671003"