Gaia/SMS/Scrum/3

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1022706)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
925404	Oleg Zasypkin [:azasypkin]	[B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known	---	No cf_feature-b2g	burirun2, burirun3, [lang=js][lang=css][p=2][not-part-of-initial-sprint]	FIXED
994553	Steve Chung [:steveck]	[Sora][Message][Contacts]Contacts's head portrait do not display in Message	1.4+	No cf_feature-b2g	[p=2]	FIXED
1008127	Pavel Ivanov [:ivanovpavel][:pivanov] UX	[Messages][Refresh] Subject handling in the Composer	---	No cf_feature-b2g	[sprint2 p=3][sprint3 p=2][not-part-of-initial-sprint]	FIXED
1012663	Oleg Zasypkin [:azasypkin]	[SMS] Remove inline style for CSP compliance	---	No cf_feature-b2g	[sms-most-wanted][p=1]	FIXED
1013296	Arnau March [:arnau] ( not working in Firefox OS anymore :( )	Compose. Change send button to an paper plane icon	---	No cf_feature-b2g	[p=1][not-part-of-initial-sprint]	FIXED
1015867	Julien Wajsberg [:julienw]	[Messages] The editable composer should take more space	2.0+	No cf_feature-b2g	[sprint2 p=2][sprint3 p=1]	FIXED
1016897	Steve Chung [:steveck]	[Flame][v1.4][Message]Tap new message icon, it will automatically return SMS which is just saved as draft. .And if then tap Back key, this contact will have 2 SMS items in main message view.	1.4+	No cf_feature-b2g	bamboo[p=1]	FIXED
1018035	Julien Wajsberg [:julienw]	[Flame][v1.4][SMS]No cursor display when tap the message edit box.	1.4+	No cf_feature-b2g	torch, [not-part-of-initial-sprint]	FIXED
1022096	Julien Wajsberg [:julienw]	[Messages] sms text truncated in delete messages mode	2.0+	No cf_feature-b2g	[2.0-FL-bug-bash][not-part-of-initial-sprint]	FIXED
1024978	Julien Wajsberg [:julienw]	[Messages] Activity Handler tests are failing with newer mocha	---	No cf_feature-b2g	[not-part-of-initial-sprint]	FIXED
1025552	Oleg Zasypkin [:azasypkin]	[Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module	---	No cf_feature-b2g	[p=1]	FIXED
1026528	Oleg Zasypkin [:azasypkin]	[Messages] Corrupted attachments do not display correctly	2.0+	No cf_feature-b2g	[not-part-of-initial-sprint]	FIXED

12 Total; 12 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Remaining points and burndown chart

Burndown chart

	Remaining points
Start	8
Day 2	8
Day 3	7
Day 4	6
Day 5	4
Day 6	4
Day 7
Day 8
Day 9
Day 10
End

All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Resolution
925404	Oleg Zasypkin [:azasypkin]	[B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known	---	---	FIXED
974867	Naoya Matsumoto	[MMS]Auto suggestion for email address	---	---	FIXED
994553	Steve Chung [:steveck]	[Sora][Message][Contacts]Contacts's head portrait do not display in Message	1.4+	---	FIXED
1005866	Fernando Campo (:fcampo)	[Messages] Confirmation button when deleting messages and threads should be in Red and say "Delete"	-	---	FIXED
1012663	Oleg Zasypkin [:azasypkin]	[SMS] Remove inline style for CSP compliance	---	---	FIXED
1015867	Julien Wajsberg [:julienw]	[Messages] The editable composer should take more space	2.0+	---	FIXED
1016897	Steve Chung [:steveck]	[Flame][v1.4][Message]Tap new message icon, it will automatically return SMS which is just saved as draft. .And if then tap Back key, this contact will have 2 SMS items in main message view.	1.4+	---	FIXED
1018035	Julien Wajsberg [:julienw]	[Flame][v1.4][SMS]No cursor display when tap the message edit box.	1.4+	---	FIXED
1019359	Paco Rampas [:paco]	[Sora][Message] The "slecet all/deselect all"still can use when it display as grey.	1.4+	---	FIXED
1021788	Steve Chung [:steveck]	[Messages] Can't click on the suggestion list when there are a lot of recipients in the recipients panel	2.0+	---	FIXED
1021844	Julien Wajsberg [:julienw]	[Messages] Can't load the application in Firefox	---	---	FIXED
1022096	Julien Wajsberg [:julienw]	[Messages] sms text truncated in delete messages mode	2.0+	---	FIXED
1022706		[meta] SMS subteam sprint 3	---	---	INCOMPLETE
1024978	Julien Wajsberg [:julienw]	[Messages] Activity Handler tests are failing with newer mocha	---	---	FIXED
1026528	Oleg Zasypkin [:azasypkin]	[Messages] Corrupted attachments do not display correctly	2.0+	---	FIXED
1026671	Guillaume Marty [:gmarty]	Header Font in Messages App Does Not Center Align	---	---	WORKSFORME

16 Total; 16 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Sprint planning

Minutes will be on a separate page.

Daily meetings

Day 2: 11th June

Steve

• bug 1016897 - [Flame][v1.4][Message]Tap new message icon, it will automatically return SMS which is just saved as draft .And if then tap Back key, this contact will have 2 SMS items in main message view.
  • Patch given. just clear the draft while leaving the unchanged draft and seems work without regression.
• bug 994553 - [Sora][Message][Contacts]Contacts's head portrait do not display in Message
  • Will try to store the url in dataset and revoke while deletion as agreed in the sprint planing
• bug reviewing:
  • bug 1013296: Send button VR. Got dependency with subject VR and DSDS VR. No progress, wait for other blocker
  • bug 963043: partner's multiple contacts patch. Still r- because lack of unit test
  • bug 1015867: The dynamic height of composer might cause subject field unable to click(some issue in subheader, need to verify whether we should also fix it in the same bug).

Today:

• Wait for bug 1016897 and start bug 994553
• Clean up the review queue

Julien

• no code work on bugs yesterday (for comms)
• some reviews (accessibility patch notably)
• bug triage and testing (we had a lot of them lately, I try to triage them as soon as they arrive :) ) Thanks to Steve for spotting my wrong comments ;)

Today:

• some more left reviews
• will resume working on my bug on the composer max height

Oleg

• bug 1008127 - [Messages][Refresh] Subject handling in the Composer
  • Reviewed Pavel's patch once again, asked to fix issues that still arise; Current PR is still not ready for code review;
  • Pavel ni?'ed Vicky to confirm subject handling spec.
• bug 1012663 - [SMS] Remove inline style for CSP compliance
  • Discussed the issue with Julien and possible refactoring of "render" method in attachment.js;
  • Have quick&dirty patch to see how removed inline styles improves CSP compliance in SMS app. Today will make it cleaner, probably using Julien's suggestion on "AttachmentRenderer".

Still have problems with very slow internet, waiting technician to come today. Will miss today's comms meeting because of that.

Today: will work with Pavel on subject handling and CSP compliance bug.

Day 3: 12th June

Steve

• bug 1016897 - [Flame][v1.4][Message]Tap new message icon, it will automatically return SMS which is just saved as draft .And if then tap Back key, this contact will have 2 SMS items in main message view.
  • Patch landed
• bug 994553 - [Sora][Message][Contacts]Contacts's head portrait do not display in Message
  • Patch given, it revoke the url when element deleted. Hope it works
• bug 1021788 - [Messages] Can't click on the suggestion list when there are a lot of recipients in the recipients panel
  • Patch given
• bug reviewing:
  • bug 1013296: Send button VR. Got dependency with subject VR and DSDS VR. No progress, wait for other blocker
  • bug 963043: No update
  • bug 1015867: Since we know the root cause and bug 1021788 is tracking it, we can keep the review moving forward and land it today.

Today:

• Wait for review
• Take other blocker or triage other bugs if nothing really blocked
• Review bug 1015867
• Take a look for haida plaining

Julien

• mostly reviews:
  • bug 974867 for email suggestion and bug 997547 for send mms by email activity; I requested to put this behind a flag while it's not finished, because landing one of these patches only will break things
  • other minor things
• add a look on my remaining bug for the sprint bug 1015867 for the composer length
  • we agreed with Steve that the remaining issue was actually already filed in a separate bug and unrelated
• so should land today and unblock other work \o/
• add a look to some other blockers, requested information:
  • bug 1020653: no vibration when receiving a message in some situation. The regression window doesn't help much, so I'll investigate more today
  • bug 1022755 reported by Etienne, navigation issue and I saw it myself, but it's not really 100% reproducible for me yet, I'll ask Etienne today
• still some bug triage

Other:

• updated the Gaia/SMS page: https://wiki.mozilla.org/Gaia/SMS

Today:

• some more left reviews (my goal is to have one less review left when I leave work :) )
• want to at last look to the datastore etherpad

Oleg

• bug 1008127 - [Messages][Refresh] Subject handling in the Composer
  • Pinged Pavel once again as it looks like PR is rebased incorrectly + still waiting ni? from Vicky.
• bug 1012663 - [SMS] Remove inline style for CSP compliance
  • Refactoring of attachment.js render method took a bit more time than I expected :) Still working on it + updating related unit tests. Should finish with it today and send for review.
• Other: My internet is finally fixed! :)

Today: will be finishing with patch for bug 1012663 and, yes, will take a look at haida etherpad, that sounds quite interesting. Also was planning to look at regression as my commits are in regression window push log bug 1018035 - [Flame][v1.4][SMS]No cursor display when tap the message edit box.

Julien have you already looked into it?

(Julien) yep, couldn't reproduce yet but I didn't use the correct STR. I can continue investigating on my side today and if you're free tomorrow you can possibly steal it :)

(Oleg) Ok!

Day 4: 13th June

Steve

• bug 994553 - [Sora][Message][Contacts]Contacts's head portrait do not display in Message
  • Reviewing, will reply the concern of using the mutation observer
  • (Julien) it's only a suggestion so tell me what you prefer
• bug 1021788 - [Messages] Can't click on the suggestion list when there are a lot of recipients in the recipients panel
  • Reviewing, I could agree that set height to 0
• bug reviewing:
  • bug 1013296: Send button VR. Got dependency with subject VR and DSDS VR. No progress, wait for other blocker
  • bug 963043: No update
  • bug 1015867: Suggestion given and it should be landed today. (Julien) it is ;)
  • bug 1005866: Just saw a failed test. So it need another review...
• Give some idea for haida plaining

Today:

• Take other blocker or triage other bugs if nothing really blocked
• Take a look for haida plaining

Julien

• some reviews, nothing much to say here
  • bug 1004973: rewrite mock_l10n by the l10n team, I gave my advice there. They want to be very strict and I don't think it's useful here.
• landed bug 1015867 for the composer length!
• bug 1020653: no vibration when receiving a message in some situation
  • the vibration+sound is done by System when we send a notification, so I redirected this to the System team
• bug 1018035: the cursor is not shown when we use an activity to launch messages
  • I found the issue but I think there is also a Gecko bug
  • need to update unit tests for the work around, and I'l ltry to reproduce the Gecko bug in Firefox to file another bug for Gecko
• found an issue in the tests for activity_handler when testing with the new mocha, I think it's related to our use of Promise, will have a look in the subway :) \o/
• investigated bug 1019359: when the "select/deselect" buttons in the edit mode are disabled, sometimes we can touch what's around.
  • I found it's an issue in building blocks that's been fixed by the refresh
  • so I did a small patch for v1.4 for SMS only, but I requested 1.4? to see if we can't do a building blocks patch instead.

Other:

• updated the Gaia/SMS page: https://wiki.mozilla.org/Gaia/SMS again :)

Today:

• bug 1018035: unit tests and do a testcase for a gecko bug
• moar reviews

Oleg

• bug 1012663 - [SMS] Remove inline style for CSP compliance
  • Refactored attachment.js and asked for review. I've divided PR into two separate commits: one deals with CSP issue and the second one the refactoring itself, but it looks it'd be better to split it into two separate PR\bugs.
• bug 925404 - [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known.
  • Rebased it on the latest master and started to test.
• bug 1008127 - [Messages][Refresh] Subject handling in the Composer
  • Played with the latest PR from Pavel, still need to get ni? from Vicky, will ping her additionally today.

Other:

• Navigated through haida related info\bugs for other teams too, to better understand haida in general, what goals it has, what benefits it's going to provide.

Today: will work on bug 925404 + handle review comments for bug 1012663 patch.

Day 5: 16th June

Steve

• bug 994553 - [Sora][Message][Contacts]Contacts's head portrait do not display in Message
  • Landed with some small experiment about mutation observer
• bug 1021788 - [Messages] Can't click on the suggestion list when there are a lot of recipients in the recipients panel
  • Landed
• bug 1022644 - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
  • Taken and start investigate today(since it's easy to reproduce and break the multi-line recipient mode). Gesture detection works fine. Seems like some problem in recipient module that didn't initialize properly(view.dims).
• bug reviewing:
  • bug 1013296: Send button VR. Got dependency with subject VR and DSDS VR. No progress, wait for other blocker
  • bug 963043: No update
  • bug 1015867: Landed
  • bug 1005866: Deletion dialog issue. Landed

Today:

• Fix bug 1022644
• Take other blocker or triage other bugs if nothing really blocked
• Clean the review queue

Julien

• bug 1018035: the cursor is not shown when we use an activity to launch messages
  • couldn't find a reduced testcase to file a Gecko bug :(
  • in review
  • found bug 1025169 while testing, but may be already fixed by alive
• bug 1024978: issue in the tests for activity_handler:
  • in review
  • because of the use of Promise we did not wait in setup that the promise is resolved
• investigated bug 1019359: when the "select/deselect" buttons in the edit mode are disabled, sometimes we can touch what's around.
  • waiting for v1.4 triage decision
• reviewed the "send mms by email" patch again
  • will be behind a flag

Today:

• wait for review ;)
• pick new blockers
• work on haida + datastore etherpads

Oleg

• bug 1012663 - [SMS] Remove inline style for CSP compliance
  • Finished and sent for review (in review). The only open question is how to escape\sanitize\protect from malicious content in dataURL. Left my thoughts at GitHub.

• • (Julien) you forgot to put the r? flag
  • (Oleg) no, waiting for reply at github on dataUrl escaping question
  • (Julien) ok, will look at it soon then :)
  • (Oleg) Thanks!

• bug 1025552 - [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module
  • As agreed, divided PR for bug 1012663 into two separate bugs, so this one is for refactoring only (in review).
  • Open questions after review round#1: dataURL escaping and how suggested AttachmentRenderer.for is supposed to be implemented :)
  • Messed up commit hash, so review discussion is not visible in the latest PR, but left link to the original discussion with my answers, sorry Julien :(
• bug 925404 - [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known.
  • Finished, tested and asked for review (in review).
• bug 1008127 - [Messages][Refresh] Subject handling in the Composer
  • Pavel is going to rewrite current patch as master has changed significantly, hopefully it will be done today.
  • Will adapt my JS patch according to his needs. Now just extracted Pavel's old commit from PR.

Today: will make reviews + handle review comments, no more new bugs :) I'm set up :)

Day 6: 17th June

Steve was absent today.

Julien

• Landing frenzy:
  • bug 1022096 - [Messages] sms text truncated in delete messages mode: fixed and landed; only remaining question is: why isn't this in the building blocks?
  • bug 1018035 - No caret when starting a message from Contacts: still weird issue in how contenteditable elements behave
  • bug 1024978 - [Messages] Activity Handler tests are failing with newer mocha: unit test fix, that should be intermittent with current mocha but is permafail with the newer mocha
• investigated bug 1019359: when the "select/deselect" buttons in the edit mode are disabled, sometimes we can touch what's around.
  • still waiting for v1.4 triage decision
• reviewed the "send mms by email" patch again
  • latest patch was monstruous (lots of copy/paste)
  • I've seen there is a newer patch, will look at it today
  • other "send by email" patches will probably need Oleg or Steve next week

Other:

• worked on unit tests in other apps so that we can finally upgrade mocha (Bug
• I had only "5" requests left !

Today:

• review the CSP patches from Oleg
• work on haida + datastore etherpads
  • when I come back from holiday, we need to have a "release planning" or something, to decide which bugs we'll do in which sprints.
• I want 1 or 2 requests left less.
• demos :)
• possibly new blockers?

Oleg

• bug 1012663 - [SMS] Remove inline style for CSP compliance
  • Wrapped URLs that directly assigned to the DOM properties into encodeURI + added appropriate unit tests (in review).
• bug 1025552 - [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module
  • Rebased on the latest patch from bug 1012663 + added AttachmentRenderer.for factory method + updates in the unit tests (in review).
• bug 1008127 - [Messages][Refresh] Subject handling in the Composer
  • Worked with Pavel to test his new patch, still needs work (in progress).
• bug 1018035 - [Flame][v1.4][SMS]No cursor display when tap the message edit box.
  • Reviewed (landed). We need Demo here :)
• bug 1024978 - [Messages] Activity Handler tests are failing with newer mocha.
  • Reviewed (landed).

-> Julien, why do not you add these bugs to the current sprint with label [not-part-of-the-sprint]? -> (Julien) I'm still not sure about this ;) but I'll do it.

• bug 1022096 - [Messages] sms text truncated in delete messages mode.
  • Reviewed (landed). We need Demo here as well :)

Today:

• • handle review comments;
  • collaborate more tightly with Pavel on subject handling bug;
  • haida etherpad.