TPE-Layout/2017-04-18

Weekly Announcement

• Quantum Layout Labeling.
  • Resolved - bug 1339343 - Label runnables in layout modules
• Quantum Flow
  • Bug Tagging & Triage Process
  • P1 bugs
  • P3 bugs
  • P5 bugs

Weekly Sharing

Astley Chen

• Gecko Profiler
  • Gecko Profiler Introduction By Ehsan Akhgari.
  • Profiler front-end: perf-html.io
    1. Install profiler add-on and it's ready to go.
    2. Capture & visualize perf profile and then save or share to others.

Weekly Status

Astley Chen

• Stylo Work Week Meetings[4/10~4/14]
• Quantum flow bugs engagement and planning.
• Reading
  • EdgeHTML 15 Release
• bug 1355862 - Unable to load https://www.dgbas.gov.tw/point.asp?index=4
  • Filed.
• bug 1356523 - Malfunction in perf-html.io whenever you switch to Marker tab
  • Filed.
• bug 1355752 - Remove B2G code from layout modules
  • r+(7/7). Ready to land.

Boris Chiou

stylo animations

• bug 1343753 - stylo: Update CSS transitions with servo's computed values instead of nsStyleContext
  • land
• bug 1341372 - stylo: Detect new transitions and let it run
  • r+ | land
• bug 1353628 - stylo: Cannot parse shorthand properties for transition-property
  • r+ | wip
• bug 1332525 - stylo: Style sharing cache not working
  • review
• bug 1357357 - stylo: Need to start a transition even if one of the property is non-animatable or unrecognized property
  • file
• bug 1355761 - stylo: AnimatedProperty::does_animate() needs also check interpolable.
  • file
• bug 1355758 - stylo: Element.getAnimations() returns transitions with incorrect order
  • file

Cameron McCormack

Stylo

• Lots of discussions during the work week
• bug 1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden
  • r+ | land
• bug 1356085 - stylo: disallow CSS-wide keywords in animation shorthand and counter-increment/counter-reset
  • r+ | land
• bug 1356125 - stylo: support all shorthand
  • r+ | land
• bug 1356510 - stylo: support the sideways-{lr,rl} and deprecated SVG 1.1 writing-mode values
  • r+ | land
• bug 1355762 - stylo: enable stylo in non-HTML documents
  • file | investigate

Other

• bug 1356601 - Crash with ::first-line, CSS variables and CSS animations
  • r+ | land

Stylo reviews

• bug 1354772 - stylo: we're doing Gecko URI stuff on background threads, which is bad
• bug 1341721 - stylo: add support for alternate ServoStyleSheets and disabling author styles
• bug 1355001 - stylo: Implement glue for initial-letter property
• bug 1354876 - stylo: implement font-variant
• bug 1341667 - stylo: Figure out why all the W3C masking reftests fail
• bug 1353994 - stylo: Support new color format of hsla() and rgba() defined in CSS Color Module Level 4
• bug 1355707 - stylo: relative font-size applied to defaults should cascade too
• bug 1341372 - stylo: Detect new transitions and let it run
• bug 1354487 - stylo: StoredRestyleHint::propagate behaves incorrectly during animation only restyle
• bug 1356060 - URLValueData.mString should just be a nsString
• bug 1356111 - Update bloom microbenchmark to use a real color
• bug 1324700 - stylo: several tests non-fatally assert with "stylo: cannot resolve style for canvas from a ServoStyleSet yet"
• bug 1355734 - Consider removing -moz-anchor-decoration magic keyword
• bug 1356074 - stylo: More media query stuff.
• bug 1341703 - stylo: border-image support with url() seems to be broken
• bug 1347409 - SVG paint server without fallback value should be treated as no fallback
• bug 1348173 - stylo: Implement the -moz-border-*-colors property
• bug 1357350 - stylo: setting border shorthands should reset longhands of border-image to their initial value

CJ Ku

• bug 1357432 - SVGUseElement::LookupHref does not handle local reference well
  • r?
• bug 1341703 - stylo: border-image support with url() seems to be broken
  • r?
• bug 1351440 - PaintSVG should not be returning DrawResult
  • WIP
• bug 1346618 - When applying an mask-image which is an svg, opacity does not work
  • land
• bug 1357060 - stylo: border-image-width-large.html hits MOZ_ASSERT(value >= 0)
  • file

Eric Tsai

• Issues triage and diagnosis
  • Media decode error cause lots type-media issues https://bugzilla.mozilla.org/show_bug.cgi?id=1357209 won't fix by webcompat team but aggregate to bugzilla in the future.
• Prepare talk for NCKU 4/28.

Farmer Tseng

Mortar Printing

• bug 1345710 - [Mortar] [Windows] Implement Emf, PDFEngineExports and PdfPrintHelperWin
  • r+|r?

Label Printing

• bug 1351190 - Label printing IPC actor
  • land

Jeremy Chen

Quantum CSS (stylo)

• bug 1341758 - stylo: need image-orientation support
  • land
• bug 1355001 - stylo: Implement glue for initial-letter property
  • r+ | land
• bug 1348173 - stylo: Implement the -moz-border-*-colors property
  • r?
• bug 1357350 - stylo: setting border shorthand should reset longhands of border-image to their initial value
  • file
• bug 1355380 - stylo: re-enable reftests for image-orientation property with -45deg and 315 deg
  • file

other

• bug 276079 - Implement text-justify property (with values: auto | none | inter-word | inter-character)
  • technical-review MDN page
  • update Firefox support status on caniuse

Louis Chang

Mortar

• bug 1347440 - Integrate building rpc.cc into mozbuild instead of checking it into m-c
  • r? | r-
• bug 1341166 - Handle printing all pages of PDF file on Mac
  • discuss & ni reviewer

Shing Lyu

Stylo

• Bug 1344991 - Fix the autophone failures on reftest resuming bug
• Bug 1351548 - Finished annotating stylo reftest expectations
• Bug 1344132 - Fixing review comments in
• Run Alexa Top 200 reftest on Stylo

Evangelism

• Support VoiceJam event

Ting-Yu Lin

stylo

• bug 1356971 - stylo: Use StyleSetHandle::BackendType in PresShell::Init()
  • file | land
• bug 1290276 - stylo: XBL <stylesheet> support
  • OOAD

Tommy Kuo

Stylo

• bug 1355017 - stylo: background-position should generate valid three-value form when from longhands
  • land
• bug 1353994 - stylo: Support new color format of hsla() and rgba() defined in CSS Color Module Level 4
  • land
• bug 1354000 - stylo: stylo doesn't understand moz-prefixed -moz-crisp-edges
  • land
• bug 1355005 - stylo: Support -moz-box-orient: {block,inline}-axis
  • WIP

Ya-Chieh Wu

Pdfium

• bug 1340995 - Pressing copy combination key under form text input causes character typed unexpectedly.
  • land
• bug 1345328 - Way to build and pack JSPlugin to an XPI file.
  • r+
• bug 1356089 - Figure out PDF form input's quality.
  • file

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics