TPE-Layout/2017-09-26

Weekly Status

Astley Chen

• bug 1350780 NEW:: [css-grid] Crash on null pointer [@ InvalidArrayIndex_CRASH | nsComputedDOMStyle::GetGridTemplateColumnsRows]
  • Bug 1350780 - investigation

Boris Chiou

• bug 1289049 RESOLVED::FIXED Add animation support for shape-outside
  • Reviewed bug 1289049 - Add animation support for shape-outside
• bug 1399799 RESOLVED::FIXED stylo: Values of amount over 100% are allowed but UAs must clamp the values to 1 for some filter fuctions
  • Landed bug 1399799 - stylo: Values of amount over 100% are allowed but UAs must clamp the values to 1 for some filter fuctions
• bug 1390026 RESOLVED::FIXED stylo: make shape-outside animatable on <basic-shape>
  • Landed bug 1390026 - stylo: make shape-outside animatable on <basic-shape>
• bug 1340005 ASSIGNED:: stylo: Switch to Servo style backend for compositor animations
  • Wrote patches for bug 1340005 - stylo: Switch to Servo style backend for compositor animations
• bug 1388601 RESOLVED::FIXED stylo: Implement test cases for ComputeSquaredDistance on BasicShape and FilterList
  • Landed bug 1388601 - stylo: Implement test cases for ComputeSquaredDistance on BasicShape and FilterList

Cameron McCormack

• Reviewed https://bugzilla.mozilla.org/show_bug.cgi?id=1400438
• Reviewed https://github.com/servo/rust-cssparser/pull/198
• bug 1399834 ASSIGNED:: stylo: Add support for -moz-font-smoothing-background-color
  • Uploaded patch for bug 1399834
• bug 1368922 RESOLVED::FIXED stylo: Figure out a way to set the dirty bit for DeclarationBlock thread-safety during parallel traversal
  • Uploaded patch for bug 1368922
• bug 1401256 RESOLVED::FIXED stylo: thread '<unnamed>' panicked at 'should check whether we're a non-inherited property'
  • Reviewed bug 1401256

CJ Ku

• bug 1401888 RESOLVED::FIXED Make EMFViaExtDLLHelper inherit from PDFViaEMFPrintHelper
  • Bug 1401888 landed
  • Bug 1401888 upload patches and r+ granted
• bug 1281101 RESOLVED::FIXED Remove MOZ_ENABLE_MASK_AS_SHORTHAND
  • Bug 1281101 reviewed
• bug 1401069 RESOLVED::FIXED Fine tune WindowsEMF and PDFViaEMFPrintHelper
  • Bug 1401069 file and upload patch
  • Bug 1401069 update commit message

Eric Tsai

• Issue triage and diagnosis
• Mozilla Developer Conference Taipei

Jeremy Chen

• Studied Firefox Developer Tools - Docs and Guides (http://firefox-dev.tools/)
• bug 1291647 NEW:: Crash in gfxFontFamily::FindAllFontsForStyle
  • Triaged Bug 1291647
• bug 1253648 RESOLVED::INVALID @supports (clip-path: [foo]) doesn't work in Nightly, even though clip-path does
  • Resolved Bug 1253648
• bug 1394284 RESOLVED::FIXED stylo: animate transform with singular matrix as discrete
  • Landed Bug 1394284
  • Updated patchset and request review from hiro [Bug 1394284]
• bug 1370750 RESOLVED::WORKSFORME Crash in UnhookTextRunFromFrames
  • Triaged/Resolved Bug 1370750

Louis Chang

• bug 1400050 - Distorted checkbox + radio when descendant of display:flex wrapper and associated label line-wraps
  • WIP
• bug 1399776 - background-color: transparent makes the checkbox disappear on Firefox Android
  • r+ | land
• bug 1399723 - Checkbox has 3 states – empty / full (white background) / with check-mark.
  • r+ | land

Ting-Yu Lin

• bug 1400877 RESOLVED::DUPLICATE Overlapped highlight when selecting large text
  • Triage bug 1400877.
• bug 1341009 RESOLVED::FIXED Eliminate unneeded nsReflowStatus::Reset() calls
  • Landed bug 1341009.
• bug 1289049 RESOLVED::FIXED Add animation support for shape-outside
  • Landed bug 1289049.
  • Uploaded patches for bug 1289049.
• bug 1399006 RESOLVED::FIXED stylo: Fatal Assertion dropping CachedBorderImageData during servo traversal
  • Reviewed a patch in bug 1399006.
• bug 1281101 RESOLVED::FIXED Remove MOZ_ENABLE_MASK_AS_SHORTHAND
  • Landed bug 1281101.
  • Uploaded patches for bug 1281101 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND.
• bug 1402246 RESOLVED::FIXED Remove unused declarations in nsStyleStruct.h
  • Filed and uploaded patches for bug 1402246.
  • Landed bug 1402246.

Tommy Kuo

• bug 1399310 NEW:: Decorations get drawn multiple times with selections
  • Figure out the root cause (bug 1399310)
  • Trace code and debug (bug 1399310)
  • Upload a patch to ask feedback (bug 1399310)

Ya-Chieh Wu

• bug 1381153 Calling GetEffectSet during display list building is not very cache friendly
  • r? Bug 1381153

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics