TPE-Layout/2017-10-03

Weekly Announcement

• Refresh your 2017Q3 goals on Wiki & Workday - Due: 10/6 Friday.
• Submit your Q4 golas on Wiki & WD by 10/13.
• 2018 layout福委選舉
  • Winner is: Boris Chiou

Weekly Sharing

• Astley Chen
  • The way to verify your bug with latest fuzz m-c debug build.
    • `pip install fuzzfetch==0.5.5`
    • GitHub - https://github.com/MozillaSecurity/fuzzfetch

Weekly Status

Astley Chen

• bug 1336208 NEW:: Bundle and whitelist fonts when privacy.resistFingerprinting = true
  • Bug 1336208 - reference to do stylo whitelist control.

Boris Chiou

• bug 1340005 stylo: Switch to Servo style backend for compositor animations
  • wrote a patch for webrender (but still debugging)

Cameron McCormack

• bug 1403078 RESOLVED::FIXED Lazily tweak the traversal root to account for sibling invalidations.
  • Reviewed bug 1403078
• bug 1404178 RESOLVED::FIXED Fix some reftest conditions for Stylo on Android
  • Reviewed bug 1404178
• bug 1403024 RESOLVED::FIXED stylo: Add some diagnosis information to crash report when crash for adopting element across style backend
  • Reviewed a patch in bug 1403024
• bug 1402942 RESOLVED::FIXED Window.devicePixelRatio should use double math
  • Reviewed bug 1402942
• bug 1403073 RESOLVED::FIXED stylo: some bindgen object layout issues
  • Uploaded patch for bug 1403073
• bug 1404180 RESOLVED::FIXED stylo: Assertion failure: !mInStyleRefresh [@ mozilla::ServoRestyleManager::ContentStateChanged]
  • Uploaded patch for bug 1404180
• bug 1403028 RESOLVED::FIXED stylo: Assertion failure: aElement->IsInComposedDoc() [@ NoteDirtyElement]
  • Reviewed bug 1403028
• bug 1404243 RESOLVED::FIXED Refactor for StyleShapeSource to support shape-outside: <image>
  • Reviewed bug 1404243
• bug 1397626 ASSIGNED:: stylo: Consider creating refcounted wrapper object for FontFamilyList and store it in specified value so that it can be shared between style structs
  • Uploaded new patches for bug 1397626
  • Uploaded patches for bug 1397626

CJ Ku

• bug 1402798 Invalid bug or security bug
  • Bug 1402798 sec-approval?
  • Bug 1402798 uplift to beta
  • Bug 1402798 upload patches
• bug 1373750 RESOLVED::FIXED Assertion failure: aClipState->IsValid()
  • Bug 1373750 landed
• bug 1403057 NEW:: Assertion failure: invertible, at layout/svg/nsFilterInstance.cpp:80
  • Bug 1403057 upload a patch
• bug 1404077 RESOLVED::FIXED ###!!! ASSERTION: The context of the current AzureState is not altered after Save() been called when using certificate viewer
  • Bug 1404077 landed
  • Bug 1404077 upload a patch
• bug 1393840 Invalid bug or security bug
  • Bug 1393840 investigating

Eric Tsai

• Issue triage
• WebCompat-to-Bugzilla extension features:
  • Fix title error
  • Fix default product/component mappings

Jeremy Chen

• Studied kinto: https://kinto.readthedocs.org/
• bug 1336208 NEW:: Bundle and whitelist fonts when privacy.resistFingerprinting = true
  • Studied patchset of Bug 1336208 for stylo-blocklist reference
• bug 1381232 RESOLVED::WORKSFORME Stylo serialize computed <number-percentage> values to <number> values for filter property, Gecko doesn't
  • Commented on Bug 1381232
• bug 1403077 NEW:: stylo-blocklist: add support for a list of domains that should use the old Gecko style system instead of Stylo
  • Updated WIPs [Bug 1403077]
  • Updated patchset and ask for first round of review/feedback [Bug 1403077]
  • Uploaded wip patchset [Bug 1403077 ]

Louis Chang

• bug 1400050 - Distorted checkbox + radio when descendant of display:flex wrapper and associated label line-wraps
  • r+ | land
• bug 1404770 - Minimum widget size of checkbox/radio on Android is wrong
  • open | WIP

Ting-Yu Lin

• bug 1401807 RESOLVED::FIXED Assertion failure: aStatus.IsEmpty() (Caller should pass a fresh reflow status!), at /builds/worker/workspace/build/src/layout/generic/nsBlockFrame.cpp:1091
  • Landed bug 1401807.
  • Uploaded a patch for bug 1401807.
• bug 1403115 VERIFIED::FIXED Stylo: Black dots displayed in video's seekbar at the right and left side
  • Debug bug 1403115 for visual defect on videocontrols on stylo.
  • Reviewed bug 1403115.
• bug 1404222 ASSIGNED:: Support shape-outside: <image>
  • Filed bug 1404243 and bug 1404222.
• bug 1404243 RESOLVED::FIXED Refactor for StyleShapeSource to support shape-outside: <image>
  • Filed bug 1404243 and bug 1404222.
  • Landed bug 1404243.
  • Uploaded patches for bug 1404243.

Tommy Kuo

• bug 1399310 NEW:: Decorations get drawn multiple times with selections
  • Coding (bug 1399310)
  • Upload a patch and ask to review (bug 1399310)

Ya-Chieh Wu

• bug 332740 NEW:: [BC] rowspan and border-collapse: collapse breaks border rendering
  • Investigate Bug 332740

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics