TestEngineering/Performance/Onboarding: Difference between revisions
(→Getting Started: Fix link typo.) |
(Redirected page to Performance/Tools/Onboarding) |
||
| (27 intermediate revisions by 3 users not shown) | |||
| Line 1: | Line 1: | ||
#REDIRECT [[Performance/Tools/Onboarding]] | |||
= Getting Started = | = Getting Started = | ||
If you're looking for a guide to help you get going, the [https://wiki.mozilla.org/TestEngineering/Performance/NewContributors new contributor page] should have all the information you need. | If you're looking for a guide to help you get going, the [https://wiki.mozilla.org/TestEngineering/Performance/NewContributors new contributor page] should have all the information you need. | ||
| Line 13: | Line 15: | ||
* GitHub identity | * GitHub identity | ||
* [[#Bugzilla]] identity | * [[#Bugzilla]] identity | ||
* | * Matrix nick | ||
* Slack nick | * Slack nick | ||
| Line 26: | Line 28: | ||
== Groups == | == Groups == | ||
Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask. | Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask. | ||
* [https://groups.google.com/a/mozilla.com/forum/#!forum/perftest perftest] is | * [https://groups.google.com/a/mozilla.com/forum/#!forum/perftest perftest] is for team communications and setting up test accounts | ||
* [https://groups.google.com/a/mozilla.com/forum/#!forum/performance performance] is for general discussion and announcements | * [https://groups.google.com/a/mozilla.com/forum/#!forum/performance performance] is for general discussion and announcements | ||
* [https://groups.google.com/a/mozilla.com/forum/#!forum/perfteam perfteam | * [https://groups.google.com/a/mozilla.com/forum/#!forum/perfteam perfteam] is for the broader performance team | ||
* [https://groups.google.com/a/mozilla.com/forum/#!forum/perf-sheriffs perf-sheriffs] is for discussions related to performance sheriffing | * [https://groups.google.com/a/mozilla.com/forum/#!forum/perf-sheriffs perf-sheriffs] is for discussions related to performance sheriffing | ||
* [https://groups.google.com/a/mozilla.com/forum/#!forum/perftest-alerts perftest-alerts] is for alerts related to performance tests | * [https://groups.google.com/a/mozilla.com/forum/#!forum/perftest-alerts perftest-alerts] is for alerts related to performance tests | ||
== [[Matrix]] == | == [[Matrix]] == | ||
| Line 38: | Line 39: | ||
* {{matrix|perftest|Public team channel}} | * {{matrix|perftest|Public team channel}} | ||
* {{matrix|perfteam|Public performance team channel}} | * {{matrix|perfteam|Public performance team channel}} | ||
* {{matrix|perfsheriffs|Performance sheriffs channel}} | |||
== Slack == | == Slack == | ||
| Line 48: | Line 50: | ||
= Credentials = | = Credentials = | ||
There's a shared [https://1password.com/ 1Password] vault for credentials that you may need to access. Please submit a request for 1Password from [https://mozilla. | There's a shared [https://1password.com/ 1Password] vault for credentials that you may need to access. Please submit a request for 1Password from [https://mozilla-hub.atlassian.net/servicedesk/customer/portal/6 ServiceDesk]. Once you have an account and the software set up (available on iOS, Android, Windows, macOS) you can be added to the team vault. | ||
= Hardware = | = Hardware = | ||
| Line 54: | Line 56: | ||
= Bugzilla = | = Bugzilla = | ||
You will need to create an account in Mozilla's instance of Bugzilla. See [[BMO/UserGuide]] for how to get started. It's helpful to include your | You will need to create an account in Mozilla's instance of Bugzilla. See [[BMO/UserGuide]] for how to get started. It's helpful to include your Matrix/Slack handle in your name field prefixed by <code>:</code> so you can quickly be identified by other users of Bugzilla. Other details that can be helpful are your preferred pronouns, current timezone, and if you're currently on PTO. For example: | ||
Dave Hunt [:davehunt] [he/him] ⌚BST (away until 1st January 2021) | Dave Hunt [:davehunt] [he/him] ⌚BST (away until 1st January 2021) | ||
== Products/Components == | |||
The relevant components for the team are: | |||
* [https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing&component=AWSY#AWSY Testing::AWSY] | |||
* [https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing&component=mozperftest#mozperftest Testing::mozperftest] | |||
* [https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing&component=Performance#Performance Testing::Performance] | |||
* [https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing&component=Raptor#Raptor Testing::Raptor] | |||
* [https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing&component=Talos#Talos Testing::Talos] | |||
== Whiteboard Entries == | |||
The following whiteboard entries are used by the team: | |||
* [https://bugzilla.mozilla.org/buglist.cgi?status_whiteboard=%5Bperftest%3Atriage%5D&resolution=---&status_whiteboard_type=allwordssubstr <nowiki>[perftest:triage]</nowiki>] - discussion required in [[TestEngineering/Performance/Triage_Process|triage]]. | |||
* [https://bugzilla.mozilla.org/buglist.cgi?status_whiteboard=%5Bperf:responsiveness%5D&resolution=---&status_whiteboard_type=allwordssubstr <nowiki>[perf:responsiveness]</nowiki>] - related to responsiveness. | |||
* [https://bugzilla.mozilla.org/buglist.cgi?status_whiteboard=%5Bperf%3Aworkflow%5D&resolution=---&status_whiteboard_type=allwordssubstr <nowiki>[perf:workflow]</nowiki>] - related to the performance workflow. | |||
== Keywords == | |||
See [[Performance/Bugzilla#Keywords]] | |||
== Resources == | == Resources == | ||
| Line 63: | Line 82: | ||
= GitHub = | = GitHub = | ||
We have a [https://github.com/orgs/mozilla/teams/ | If you don't already have one, you will need to [https://docs.github.com/en/get-started/onboarding/getting-started-with-your-github-account create a GitHub account] and enable [https://help.github.com/articles/about-two-factor-authentication/ two-factor authentication]. | ||
We have a [https://github.com/orgs/mozilla/teams/perftest GitHub team] for simplifying access to repositories. All team members that belong to the [https://github.com/orgs/mozilla Mozilla organisation] should be added to this team as members. Team maintainers can add new members following the process [[GitHub#Team_Maintainers_.26_Project_Leads|documented here]]. Other contributors will need to be manually granted access to individual repositories as needed. | |||
= Shared folder = | = Shared folder = | ||
| Line 86: | Line 107: | ||
For most patches, a single r+ from one reviewer is required to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example: | For most patches, a single r+ from one reviewer is required to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example: | ||
Bug 1546611 - Fix "None" checks when validating test manifests; r=perftest, | Bug 1546611 - Fix "None" checks when validating test manifests; r=perftest,dhunt | ||
[https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/ See the section "Write Sensible Commit Messages" here for how to form good commit titles and summaries]. | |||
When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname: | When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname: | ||
r=#perftest, | r=#perftest,dhunt! | ||
This will add the patch to the shared review queue, but also block the review from landing pending Dave's approval. Requested changes by other reviewers will also block the review. | |||
Note that a [https://phabricator.services.mozilla.com/H216 Herald rule] exists that will set this group as a blocking reviewer for certain paths in the tree. This was configured via {{bug|1618249}}. | |||
== Module | == Module ownership policy == | ||
If a patch touches code in a module owned by someone outside of the team, you must follow the [https://www.mozilla.org/en-US/about/governance/policies/module-ownership/ module ownership policy] and request review from the module owner or a peer listed in [[Modules]]. | If a patch touches code in a module owned by someone outside of the team, you must follow the [https://www.mozilla.org/en-US/about/governance/policies/module-ownership/ module ownership policy] and request review from the module owner or a peer listed in [[Modules]]. | ||
| Line 102: | Line 127: | ||
== Code reviews == | == Code reviews == | ||
Visit [https://phabricator.services.mozilla.com/differential/ active revisions] in Phabricator every day to: | Visit [https://phabricator.services.mozilla.com/differential/ active revisions] in Phabricator every day to: | ||
* Review any '''Must Review''' and '''Ready to Review''' patches. Pay particular attention to any patches that have yourself as the sole reviewer. Consider adding the <code>#perftest</code> review group for a wider audience of reviewers. All review requests should receive a response (not necessarily a complete review) within | * Review any '''Must Review''' and '''Ready to Review''' patches. Pay particular attention to any patches that have yourself as the sole reviewer. Consider adding the <code>#perftest</code> review group for a wider audience of reviewers. All review requests should receive a response (not necessarily a complete review) within 1 working day. | ||
* Follow up on any '''Waiting on Review''' patches by prompting appropriate team members for a review. | * Follow up on any '''Waiting on Review''' patches by prompting appropriate team members for a review. | ||
* Review any '''Waiting on Authors''' patches and prompt the authors if there is an action they need to take. | * Review any '''Waiting on Authors''' patches and prompt the authors if there is an action they need to take. | ||
== Bugzilla requests == | == Bugzilla requests == | ||
Visit the [https://bugzilla.mozilla.org/request.cgi request queue] in Bugzilla every day and filter by your account to see all requests that have been submitted for you. All requests should receive a response within 5 days. | Visit the [https://bugzilla.mozilla.org/request.cgi request queue] in Bugzilla every day and filter by your account to see all requests that have been submitted for you. Requests for P1/P2 bugs should recieve a response within 1 working day. All other requests should receive a response within 5 working days. | ||
Latest revision as of 17:58, 24 July 2023
Redirect to:
Getting Started
If you're looking for a guide to help you get going, the new contributor page should have all the information you need.
Meetings
- When: Weekly on Wednesdays at 15:00 UTC (08:00 PST, 11:00 EST, 18:00 EET)
- Where: Zoom ID 110-819-485
- Notes: Google Docs
Phonebook
The people directory is a secure place to quickly find your team members and easily discover new ones.
Please ensure your profile has:
- photo (of you!)
- username (this is included in your profile URL)
- GitHub identity
- #Bugzilla identity
- Matrix nick
- Slack nick
Calendar
There's a Performance shared calendar (iCal), which is primarily used for PTO. Add this calendar to your google calendar by taking the iCal link and using it in the "Add Calendar -> From URL" section.
PTO
Add any PTO to the shared calendar (see above) and team meeting notes so the team are aware. During PTO please also update your name in Bugzilla's user preferences to indicate that you are away, and when you will return.
Communication
Groups
Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask.
- perftest is for team communications and setting up test accounts
- performance is for general discussion and announcements
- perfteam is for the broader performance team
- perf-sheriffs is for discussions related to performance sheriffing
- perftest-alerts is for alerts related to performance tests
Matrix
Feel free to browse through the full list at your leisure and find things that interest you. Here are some to start with:
- #perf- General performance chat
- #perftest- Public team channel
- #perfteam- Public performance team channel
- #perfsheriffs- Performance sheriffs channel
Slack
Here are some useful Slack channels to start with:
- #announcements - Global communication and announcements
- #moco - Used for questions during internal meetings
- #newsroom - Firefox and relevant tech news
- #servicedesk - Internal IT support for employees
- #peopleteam - People support
Credentials
There's a shared 1Password vault for credentials that you may need to access. Please submit a request for 1Password from ServiceDesk. Once you have an account and the software set up (available on iOS, Android, Windows, macOS) you can be added to the team vault.
Hardware
List any hardware devices that you have assigned to you in this document. This can be valuable if we need to identify somebody on the team that has a specific device or platform for running tests, reproducing issues, etc. You may need additional hardware such as mobile devices, laptops, etc. You can request this equipment from The Hub.
Bugzilla
You will need to create an account in Mozilla's instance of Bugzilla. See BMO/UserGuide for how to get started. It's helpful to include your Matrix/Slack handle in your name field prefixed by : so you can quickly be identified by other users of Bugzilla. Other details that can be helpful are your preferred pronouns, current timezone, and if you're currently on PTO. For example:
Dave Hunt [:davehunt] [he/him] ⌚BST (away until 1st January 2021)
Products/Components
The relevant components for the team are:
Whiteboard Entries
The following whiteboard entries are used by the team:
- [perftest:triage] - discussion required in triage.
- [perf:responsiveness] - related to responsiveness.
- [perf:workflow] - related to the performance workflow.
Keywords
See Performance/Bugzilla#Keywords
Resources
GitHub
If you don't already have one, you will need to create a GitHub account and enable two-factor authentication.
We have a GitHub team for simplifying access to repositories. All team members that belong to the Mozilla organisation should be added to this team as members. Team maintainers can add new members following the process documented here. Other contributors will need to be manually granted access to individual repositories as needed.
We have a shared folder in Google Drive.
Sheriffing
Performance sheriffs will need to complete the following:
- Request an LDAP account
- Request commit access:
- Level 1: bug 1398609
- Level 3: bug 1509284
- Request access to Treeherder sheriff group: bug 1506882
- Training (ranked)
- Join the perf-sheriffs Google Group
Review policy
When you push a commit up for review, you should use the following syntax to request review from the perftest review group:
r=#perftest
For most patches, a single r+ from one reviewer is required to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example:
Bug 1546611 - Fix "None" checks when validating test manifests; r=perftest,dhunt
When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname:
r=#perftest,dhunt!
This will add the patch to the shared review queue, but also block the review from landing pending Dave's approval. Requested changes by other reviewers will also block the review.
Note that a Herald rule exists that will set this group as a blocking reviewer for certain paths in the tree. This was configured via bug 1618249.
Module ownership policy
If a patch touches code in a module owned by someone outside of the team, you must follow the module ownership policy and request review from the module owner or a peer listed in Modules.
Duties
Everyone on the team will be expected to carry out the following duties to ensure effective collaboration both within the team, and with other teams.
Code reviews
Visit active revisions in Phabricator every day to:
- Review any Must Review and Ready to Review patches. Pay particular attention to any patches that have yourself as the sole reviewer. Consider adding the
#perftestreview group for a wider audience of reviewers. All review requests should receive a response (not necessarily a complete review) within 1 working day. - Follow up on any Waiting on Review patches by prompting appropriate team members for a review.
- Review any Waiting on Authors patches and prompt the authors if there is an action they need to take.
Bugzilla requests
Visit the request queue in Bugzilla every day and filter by your account to see all requests that have been submitted for you. Requests for P1/P2 bugs should recieve a response within 1 working day. All other requests should receive a response within 5 working days.