MozPhab/Changelog

Changelog

1.5.1

• bug 1876257 AttributeError: 'Config' object has no attribute 'name' when auto-submitting after updating moz-phab to 1.5.0

1.5.0

Highlights

• "Depends On" is no longer added to commit messages.
• `--check-in-needed` flag is removed.
• The update checker logic has been fixed.

Bugs

• bug 1529766 stop adding "Depends on" messages to Phabricator revision summaries
• bug 1700164 Removed the "check-in-needed" option
• bug 1706667 moz-phab stops me from updating the patch if the reviewer set their state to away
• bug 1826125 Add a mozphab setting to change the default bookmark/branch name format for patch
• bug 1833395 Automatic self-update appears to be broken as of 1.3.0rc0
• bug 1833884 Add Python version and OS info to the `--version` command
• bug 1864678 disable Windows CI for moz-phab
• bug 1864680 drop support for Python 3.7 in `moz-phab`
• bug 1865709 remove `importlib-metadata` from moz-phab requirements
• bug 1868464 `moz-phab uplift` doesn't warn nor error if the expected head doesn't exist
• bug 1870284 Add type hints to moz-phab
• bug 1870291 use `ruff` instead of `flake8` in moz-phab
• bug 1873754 `moz-phab uplift` uses an incorrect identifier for base commit during rebase

1.4.3

• bug 1818383 add a link to Release Management Wiki to `moz-phab uplift --help`

1.4.2

• bug 1822104 Leak of token when using moz-phab for external project without bug tracker

1.4.1

• bug 1819042 Unexpected file type change (normal file -> symlink) causes `moz-phab submit` to fail with Python raise error

1.4.0

Highlights

• Eliminate many calls to the Phabricator API from moz-phab reorg.
• Fixes several bugs around updates to revision statuses during moz-phab reorg.
• Adds a --no-abandon flag to moz-phab reorg to avoid abandoning revisions during reorg.

Bugs

• bug 1626028 Can't use moz-phab reorg to drop a revision from a stack that was abandoned already
• bug 1654837 Add an option to not abandon revisions on reorg
• bug 1773145 When reorganizing a stack with already-accepted commits, moz-phab errors
• bug 1806479 use proper punctuation in `moz-phab help` strings
• bug 1809187 add type hints to `moz-phab` command files
• bug 1809214 `moz-phab uplift --train` should take a shortname instead of callsign
• bug 1809559 stop caching Conduit calls for repo information
• bug 1809946 make `moz-phab reorg` use `stackGraph` instead of calls to `edge.search`
• bug 1811019 use `all` and `any` Python builtins instead of checking for `None in list` etc

1.3.0

Highlights

• Experimental `moz-phab uplift` command is released.
• `moz-phab patch` now takes `--diff-id` to patch an older version of a revision.
• Self updating mechanism is disabled on Windows as it has been broken for some time.

Bugs

• bug 1534707 `moz-phab patch` can't download specific diff id
• bug 1754059 add moz-phab release script to repo
• bug 1774074 moz-phab self-update always fails with incorrect target path
• bug 1801696 Running `install-certificate` prompts user twice if there is no existing token
• bug 1804348 `moz-phab submit` displays escape codes instead of colors on the Windows/MSYS console
• bug 1804764 `moz-phab self-update` should log something indicating success
• bug 1805312 refactor `git cherry` arguments into `_cherry` function for git
• bug 1805530 Many source code files in moz-phab are missing license headers
• bug 1805937 un-hide `uplift` command from `moz-phab` help
• bug 1805962 `moz-phab` self-update doesn't work on Windows
• bug 1806160 Remove "Known Issues" comment
• bug 1806440 fix some linting errors in the readme
• bug 1806479 use proper punctuation in `moz-phab help` strings
• bug 1806859 cleanup fallback flag logic
• bug 1808378 Add type hints to `conduit.py`
• bug 1808584 patch command has `--diff-id` and `--apply-to` as mutually exclusive
• bug 1808778 add type hints to `config.py`
• bug 1808779 explicitly set `should_access_file` in `Config` since it is a kwarg
• bug 1808781 add type hints to `detect_repository.py`

1.2.2

• bug 1799685 - add a warning when `submit` fails in fallback mode
• bug 1799685 - remove "falling back to submit" messaging
• bug 1799674 - migrate from `setup.py` to `pyproject.toml`
• bug 1798751 - rework update checking to make self-update display some information
• bug 1799556 - update Windows dev requirements and environment
• bug 1798522 - consider Mozilla Foundation and Pocket emails as Mozilla-employees
• bug 1798406 - fix BMO API requests by using a deepcopy when sanitizing headers

1.2.1

• bug 1798406 - raise a `BMOAPIError` after maximum retries hitting bmo

1.2.0

• bug 1797367 - enable ANSI colour codes on Windows
• bug 1797864 - Fix a minor grammatical typo in moz-phab warning message
• bug 1788719 - telemetry: make new and existing UUIDs conform to expected Glean schema
• bug 1636343 - add retries to bmo whoami request
• bug 1691636 - validate user's hg/git email during setup and before submit
• bug 1784701 - Add option to create a topic rather than a bookmark
• bug 1782619 - add retries for invalid api token inputs
• bug 1649378 - cache frequently used cat_file method
• bug 1649376 - cache frequently used file_size method
• bug 1649382 - cache frequently used git2hg method
• bug 1601023 - automatically install new api token when not present
• bug 1740228 - provide clearer messaging when falling back to submit
• bug 1598560 - provide clearer messaging when config is invalid
• bug 1703872 - self upgrade with --quiet when not in DEBUG mode
• bug 1734864 - Add command to check if API token is valid
• bug 1779081 - don't generate hunks on empty files (hg)

1.1.0

• bug 1754057 cut a new release for `moz-phab uplift`
• bug 1766123 remove unused function in moz-phab submit
• bug 1769773 stop using `distutils` in moz-phab
• bug 1771099 Bump glean minimum version to bug 1770791 fix

1.1.0rc2

• bug 1613328 Add a warning when moz-phab is used without hg/evolve
• bug 1617906 Display useful advice when CERTIFICATE_VERIFY_FAILED is encountered
• bug 1651898 MozPhab is failing to continue if user has empty primaryEmail field
• bug 1676574 Glean initialisation should be explicit, not during module import
• bug 1731811 `moz-phab reorg` seems to reset the "changes planned" attribute
• bug 1753068 Failed landing due to incorrect diff for empty files/lines.
• bug 1762396 move to next gen CircleCI docker images
• bug 1762403 drop support for Python 3.6 in moz-phab
• bug 1762438 add CI for Python 3.10

1.1.0rc1

• bug 1689162 Help Glean products migrate to new versions of metrics.yaml/pings.yaml schemas
• bug 1737838 Add a `moz-phab uplift` command
• bug 1741686 Relax moz-phab dependency on python-hglib
• bug 1748906 Upgrade black to remedy failing test
• bug 1754057 cut a new release for `moz-phab uplift`
• bug 1757076 `moz-phab uplift` should avoid rebase if commits are already a descendant of the destination

1.0.0

• bug 1471687 Remove local dependency on Arcanist from new Phabricator command-line app
• bug 1688201 `FileNotFoundError` when upgrading moz-phab on Windows
• bug 1714646 moz-phab submits to the wrong branch if you switch between branches in the same local repository
• bug 1718540 moz-phab submit crashes when updating a differential without commit author information
• bug 1720931 moz-phab 1.0.0rc1 is leaking changes between revisions in stack

1.0.0rc2

• bug 1714646 moz-phab submits to the wrong branch if you switch between branches in the same local repository
• bug 1720931 moz-phab 1.0.0rc1 is leaking changes between revisions in stack

1.0.0rc1

• bug 1471687 Remove local dependency on Arcanist from new Phabricator command-line app
• bug 1688201 `FileNotFoundError` when upgrading moz-phab on Windows
• bug 1718540 moz-phab submit crashes when updating a differential without commit author information

0.1.99

• bug 1703882 Support opt-in pre-release functionality
• bug 1709704 Phabricator fails to create a diff if one of the files in the list of changes is empty

0.1.98

• bug 1701353 moz-phab incorrectly displays 'It will be submitted as "Changes Planned"
• bug 1701722 Don't explicitly request review on new revisions

0.1.97

• bug 1700485 Don't request plan-changes on accepted revisions
• bug 1700179 Add --no-wip to prevent reviewerless commits being tagged as WIP

0.1.96

• bug 1610403 Allow to submit a part of a stack as "wip"
• bug 1685308 update glean dependency to fix moz-phab installation on !tier1
• bug 1695847 Files containing lines with just `^L` on a line result in incorrect diffs when deleted
• bug 1696346 Explicitly set `zip_safe` to `False` to prevent unpredictable behaviour when installing
• bug 1696357 Upgrade glean-sdk version

0.1.95

• bug 1543963 moz-phab doesn't accept . (period) in reviewer's name
• bug 1675648 moz-phab incorrectly handles commits with CARRIAGE RETURNs and creates unlandable diffs
• bug 1675793 Make it clear when an error is generated by Phabricator vs. locally
• bug 1681005 mozphab no longer works through HTTP proxy when communicating with BMO
• bug 1681604 Add python 3.9 to the testing matrix in CircleCI
• bug 1686291 Add missing packages to dev-requirements
• bug 1686297 Add support for pip-compile to generate dev-requirements.txt
• bug 1686998 Windows tests are failing due to hard-coded line separators in test
• bug 1690649 Fix `colorama` requirement hash in requirements file for windows builds
• bug 1691818 Fix CircleCI requirements

0.1.94

• bug 1678134 verify api token
• bug 1676220 calls to hg() should always show output
• bug 1679431 use urllib's urlopen to regain http proxy support
• bug 1674049 don't send hg errors to sentry
• bug 1680836 don't send hunks for empty files

0.1.93

• bug 1673394 Don't fail when run from a subdir under mercurial
• bug 1676220 pin glean version to 33.0.4
• bug 1671360 improve diff upload
• bug 1674310 Write commit metadata to diffs straight after creation
• bug 1639564 fix processing of hunks

0.1.92

• bug 1673303 All commands broken with "ValueError: Didn't find any metrics [...]" in latest release 0.1.91

0.1.91

Highlights

• Operations on Mercurial repositories should now be significantly faster
• Submissions with unchanged commits should now be faster
• moz-phab patch --raw now includes metadata (author, subject)

All Changes

• bug 1671351 remove all calls to hg via subprocess
• bug 1672111 mention Circle CI in documentation
• bug 1649090 HG - caching retrieving commit metadata
• bug 1481543 Do not update if commit isn't changed
• bug 1651970 Save metadata after commit description is amended
• bug 1558389 Add --check-in_needed flag
• bug 1653429 moz-phab patch --raw should include patch metadata
• bug 1656254 Force integration tests to use clean config
• bug 1655385 Measure rejected submit stack size
• bug 1658817 bump black version
• bug 1666897 Allow execution via "python -m mozphab"
• bug 1641199 Various fixes for Windows development
• bug 1649353 Close open logs before spawning updated script
• bug 1649353 don't log output of `git rev-list`
• bug 1647993 Show a hint that on the default --help page that submit is the default command and more help is available
• bug 1618192 Refine sentry logging to only include actionable exceptions
• bug 1619855 Require Python 3.6

0.1.90

• bug 1619855 Warn about Python version < 3.6
• bug 1645300 Do not search for parent-child relationship if single
• bug 1641199 Reduce the number of failed tests in Windows

0.1.89

• bug 1646060 Ability to upload large (>8MiB) binary files.
• bug 1565502 Bring back the Spinner.
• bug 1621025 Measuring MozPhab usage.

0.1.88

• bug 1646831 Do not create hunks for empty files.

0.1.87

• bug 1623403 Add a warning about closed revisions.
• bug 1625594 Add phab- prefix to patched revision number.
• bug 1637177 Fix "no cinnabar" error message

0.1.86

• bug 1627405 Fix deletion of the source when copying to multiple targets.

0.1.85

• bug 1630504 Timestamp fix.

0.1.84

• bug 1627767 Submit commit date info.

0.1.83

• bug 1625551 Fix --trace and other logging issues
• bug 1602573 Fix debug log file encoding on Windows
• bug 1624354 bug 1624354 CI - Install and sanity check package

0.1.82

• bug 1624332 Added `commands` module to the package

0.1.81

• bug 1623370 Fixed restarting on Windows after an automated update
• bug 1621731 Improve performance on large HG repos

0.1.80

• bug 1617903 Fixed updates on Windows
• bug 1619310 Checked the stage before submitting

0.1.79

• bug 1619589 Fixed commands

0.1.78

• bug 1580734 Configurable Hg and Git commands
• bug 1617687 --version and --help allowed

0.1.77

• bug 1616467 MozPhab directory issue solved

0.1.76

• bug 1532433 --single added to submit one commit only
• bug 1616023 libphutil installed from the stable branch
• bug 1471687 self-update doesn't require Git

0.1.75

• bug 1607517 Patching with non-ASCII author name fixed
• bug 1603530 Auto update fixed on Windows
• bug 1608293 Sending errors to Sentry

0.1.74

• bug 1610583 Fix handling of files without trailing newlines on hg

0.1.73

• bug 1606175 Detecting if installed with --user option fixed.
• bug 1609207 Show the right error when trying to reorganize a split stack

0.1.71

• bug 1605465 Resolved "patching revision" exception

0.1.70

• bug 1605124 "unable to apply patch" for Python < 3.6 fixed

0.1.69

• bug 1604097 bug 1604458 Recognizing file copy fixed.

0.1.68

• Back to Arcanist by default due to bug 1603447

0.1.67

• bug 1481539 The long awaited reorganize the stack in Phabricator
• bug 1602533 Support for truly empty files

0.1.66

• bug 1602545 MozPhab is able to submit to vanilla Phabricator instances

0.1.65

• bug 1600930 Fixed "Work in progress"
• bug 1600137 Check if revision id is unique across commits
• bug 1600696 Do not use Arcanist by default (use --arc as a backup).

0.1.64

• bug 1599596 Fix --no-bug for updating existing revisions using --no-arc

0.1.63

• bug 1599184 Fix --no-bug for submitting new revisions using --no-arc

0.1.62

• bug 1481537 --no-bug for bugless commits support
• bug 1597894 Cinnabar detection improved
• bug 1597264 Binary files upload fixed

0.1.61

• bug 1596549 Fix checking for cinnabar.

0.1.60

• bug 1592130 patch command fixed
• bug 1593712 Fail early if cinnabar required, but not installed
• bug 1595104 Display full branches in submit command

0.1.59

• Windows users can again submit patches with the --no-arc option
• bug 1591015 CRLF fix
• bug 1591248 Fix the ~/.arcrc file mode if needed
• bug 1593981 Do not check if Arcanist is configured when --no-arc is used.

0.1.58

• bug 1590953 Improved self-upgrade
• bug 1591048 Fixed restarting after self-upgrade.

0.1.57

• bug 1589994 In-memory rebasing (speed improvement).
• bug 1591092 Fixed 3-digit file mode.
• bug 1592451 Fixed sending wrong metadata when renaming a file.

0.1.56

• bug 1591015 Switched off the ability to submit without Arcanist.