DOM/WebIDL Review Checklist: Difference between revisions

One more outdated link
(Update outdated URLs)
(One more outdated link)
 
Line 34: Line 34:
** Audit the API implementation to make sure it doesn't assume the existence of a Window or a Document
** Audit the API implementation to make sure it doesn't assume the existence of a Window or a Document
** Require basic test coverage for each of the contexts in which the API is exposed.
** Require basic test coverage for each of the contexts in which the API is exposed.
* Implementation should use the argument types described in [https://developer.mozilla.org/en/Mozilla/WebIDL_bindings our binding layer documentation], not whatever internal types bindings are using (e.g. no types in the <code>binding::detail</code> namespace, no <code>NonNull<T></code> arguments where <code>T&</code> would work, etc).
* Implementation should use the argument types described in [https://firefox-source-docs.mozilla.org/dom/webIdlBindings/index.html our binding layer documentation], not whatever internal types bindings are using (e.g. no types in the <code>binding::detail</code> namespace, no <code>NonNull<T></code> arguments where <code>T&</code> would work, etc).
* Check that the <code>GetParentObject()</code> methods of various objects, combined with how those objects get constructed, associate them with the correct global.
* Check that the <code>GetParentObject()</code> methods of various objects, combined with how those objects get constructed, associate them with the correct global.
* Any <code>JSContext</code>s being used by the implementation come from the right places (passed in, <code>AutoJSAPI</code>, <code>AutoEntryScript</code>, depending on the desired semantics).
* Any <code>JSContext</code>s being used by the implementation come from the right places (passed in, <code>AutoJSAPI</code>, <code>AutoEntryScript</code>, depending on the desired semantics).
4

edits