Tree Rules: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
No edit summary
(→‎mozilla-beta: remove obsolete info about xpidl and uuids)
 
(87 intermediate revisions by 28 users not shown)
Line 1: Line 1:
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox mozilla-central] - Trunk (Firefox 3.2, Gecko 1.9.2 work) ==
For comm-central tree rules, [[Tree_Rules/comm-central|see this page]].


'''When open: <font color="orange">RESTRICTED</font>''' to [https://bugzilla.mozilla.org/buglist.cgi?quicksearch=flag%3Ablocking-firefox3.5%2B%2Cblocking1.9.1%2B Gecko 1.9.1 / Firefox 3.5] blocker bugs only
Not sure which Firefox version is on which branch today?  See [[RapidRelease/Calendar|Rapid Release Calendar]].


=== Rules ===
Looking to add a new platform/job type to Treeherder? See our [[Sheriffing/Job_Visibility_Policy|Job Visibility Policy]].
* Do not check in until you have appropriate review, including super-review and approval if needed.
* Do not check in when any box is orange or red, unless the failure has been starred with a bug number or a fix.  (You should be pretty sure the next cycle will be green and all recent intermittent failures are understood.)
* You should be available for the next hour or two in case something goes wrong with your checkin.  (This is roughly the time it takes to get unit test results from all platforms.)
* Automated unit tests must pass and not leak.
* Automated speed tests must not regress (performance regression policy).


Please see #developers or today's Sheriff if you have questions.
== Integration Branches, or the "Normal" workflow ==


== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.1 mozilla-1.9.1] - 1.9.1 Branch (Firefox 3.1, Gecko 1.9.1 work) ==
[[File:Land patch - go home.jpg|300px|right]]


'''When open: <font color="orange">RESTRICTED</font>''' [https://bugzilla.mozilla.org/buglist.cgi?quicksearch=flag%3Ablocking-firefox3.5%2B%2Cblocking1.9.1%2B Gecko 1.9.1 / Firefox 3.5] blocker bugs only
The following rules apply to integration branch managed by the [[Sheriffing|Sheriffs]], namely [https://treeherder.mozilla.org/#/jobs?repo=autoland autoland].


=== Rules ===
=== [https://treeherder.mozilla.org/#/jobs?repo=autoland autoland]/Lando ===
* patches must have been checked in and "baked" on mozilla-central,
If you are using [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html Phabricator] to post and review patches, you can also use the tool to automatically land those patch to the autoland repository. This is the preferred method of landing Mozilla code because, in almost all cases, it involves the least work for humans, including you.
* patches must fix a [https://bugzilla.mozilla.org/buglist.cgi?resolution=---&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=blocking1.9.1%2B&field0-0-1=flagtypes.name&type0-0-1=equals&value0-0-1=blocking-firefox3.1%2B blocker], be marked approval1.9.1+, or not affect Firefox build  (tests, NPOTB changes)
* any string changes must be marked with the "late-l10n" keyword and have approval1.9.1+,
* any add-on or theme compatibility changes must be marked with the "late-compat" keyword and have approval1.9.1+
* add the fixed1.9.1 keyword to the bug when it has been checked into the branch
** <i>fixed1.9.1 was also mass-added to blocking1.9.1+ and blocking-firefox3.1+ bugs which were fixed before (2008-12-01) branching, to ease bugzilla querying.</i>


Patches nominated for approval1.9.1 should:
Please see the documentation on [https://moz-conduit.readthedocs.io/en/latest/lando-user.html Landing Commits with Lando] for details on how to use Lando.
* have tests, or a strong statement of what can be done in the absence of tests
* have landed on trunk and baked for a few days (at least)
* have an assessment of performance impact
* have an assessment of risk


Please see #developers or today's Sheriff if you have questions.
Sheriffs will merge autoland into mozilla-central a few times a day.


== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.0 Firefox3.0] - Branch (Firefox 3.0.x only) ==
== [https://treeherder.mozilla.org/#/jobs?repo=mozilla-central mozilla-central] (Nightly channel) ==


'''When open: <font color="yellow">RESTRICTED</font> to branch-approved checkins only'''
'''<font color="orange">APPROVAL REQUIRED</font>'''


=== Rules ===
In order to increase the reliability of our primary repository, direct pushes to mozilla-central [https://groups.google.com/d/topic/mozilla.dev.tree-management/V1zZ3JlFpzI/discussion must now] only be for one of the following reasons:
* patches must have '''approval1.9.0.x+''' (for whatever version of x we are currently approving), or not affect the Firefox build (tests, NPOTB changes)
* Merging from an integration/team/project repository (there is no restriction on who may make these merges) [''a=merge''].  
* add the fixed1.9.0.x keyword to the bug when it has been checked into the branch
* Automated blocklist / HSTS preload list updates [''a={blocklist-update,hsts-update}''].
* For the resolution (ie: backout or follow-up fix) of critical regressions (eg: top-crashers or other major functional regression) that will result in a Nightly respin or must make the imminent scheduled Nightly at all costs [''a={backout,topcrasher,respin,...}''].
** Anything else for which common sense (or asking in #developers) says is an appropriate reason for a direct landing on mozilla-central [''a=something_descriptive''].  


Patches nominated for approval-1.9.0.x should:
If your patch is eligible for direct-landing on mozilla-central:
* Use the ''a=reason'' examples given above, to bypass the Mercurial hook used to prevent accidental pushes. Note: That whilst we are using the "a=" syntax (since that's all the hook supports for now), this is unrelated to the "release-driver approval request" process - so please do not request approval from them in Bugzilla.
** Note if merging into mozilla-central, and your push didn't generate a merge commit (and so you have nowhere to put the "a=merge" to get past the hook), then either temporarily set the tree state to OPEN, try merging a different integration repo first (which may need a merge commit), or add an empty mq commit on top with an appropriate commit message.
* Changes must meet the [https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities general checkin rules].
* You must check the tree is green before pushing, notify the sheriffs in #developers and then watch mozilla-central for failures.
* Set the ''Target Milestone'' field in Bugzilla to the current Nightly version after landing a bug fix on mozilla-central.


* have tests, or a strong statement of what can be done in the absence of tests
All other changes must instead land via one of the [[Tree_Rules#Integration_Branches.2C_or_the_.22Normal.22_workflow|integration branches]] and will then be merged into mozilla-central once green (these merges occur typically 1-2 times a day on the last complete green push).
* have landed on trunk and baked for a few days (at least)
* have an assessment of performance impact
* have an assessment of risk


'''This tree is not sheriff'd.''' Please be sure to monitor for any bustage or performance regressions on the tree and take the appropriate back out actions.
Please ask in #developers on [[IRC]] if you have questions.


=== Patch Approval & Release Driving ===
== [https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta mozilla-beta] ==
The branch approval queue is being monitored by [[Releases/Drivers/Branch|branch drivers]], all of whom are usually available on IRC.
 
'''<font color="orange">APPROVAL REQUIRED</font>'''
 
* '''All changes''' must meet the [https://developer.mozilla.org/En/Developer_Guide/Committing_Rules_and_Responsibilities general checkin rules]. You must check the tree before pushing, and watch the tree for failures after pushing.
* Patches must have the '''approval-mozilla-beta+''' flag in Bugzilla. To request approval, set the approval-mozilla-beta? flag on the patch you wish to check in. Exception: If patches only make changes to tests, test harnesses or anything else that does not affect the shipped builds, they may land with self approval (use a=testonly, a=npotb etc).
* Patches nominated for beta should:
** not change any localizable strings.
** have tests, or a strong statement of what can be done in the absence of tests.
** have landed in mozilla-central to bake on the nightly channel for a few days.
** have a comment in Bugzilla assessing performance impact, risk, and reasons the patch is needed on beta.
* Approval requests will be processed by by the [[Release_Management|release manager]] team.
* Set the appropriate ''status-firefoxN'' flag to "fixed" after landing a fix on the Beta branch.
 
== [https://treeherder.mozilla.org/#/jobs?repo=mozilla-release mozilla-release] ==
 
'''<font color="orange">APPROVAL REQUIRED</font>'''
 
* Patches must have the '''approval-mozilla-release+''' flag in Bugzilla. To request approval, set the approval-mozilla-release? flag on the patch you wish to check in. Exception: If patches only make changes to tests, test harnesses or anything else that does not affect the shipped builds, they may land with self approval (use a=testonly, a=npotb etc).
* In the normal development process, no changes will land on mozilla-release except [[RapidRelease/Calendar|regular merges from mozilla-beta]] every six weeks.
* Changes to the release branch are limited to urgent "chemspills" like zero-day security vulnerabilities and other unplanned emergencies.  Any changes to this branch will be directly overseen by the [[Release_Management|release manager]] team.  They are also subject to the same restrictions as [[#mozilla-beta]], including string freeze and UUID freeze.
 
== [https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr60 mozilla-esr60] (Firefox 60.x.y ESR) ==
 
'''<font color="orange">APPROVAL REQUIRED</font>'''
 
* See [[Release Management/ESR Landing Process]].

Latest revision as of 09:50, 14 May 2020

For comm-central tree rules, see this page.

Not sure which Firefox version is on which branch today? See Rapid Release Calendar.

Looking to add a new platform/job type to Treeherder? See our Job Visibility Policy.

Integration Branches, or the "Normal" workflow

Land patch - go home.jpg

The following rules apply to integration branch managed by the Sheriffs, namely autoland.

autoland/Lando

If you are using Phabricator to post and review patches, you can also use the tool to automatically land those patch to the autoland repository. This is the preferred method of landing Mozilla code because, in almost all cases, it involves the least work for humans, including you.

Please see the documentation on Landing Commits with Lando for details on how to use Lando.

Sheriffs will merge autoland into mozilla-central a few times a day.

mozilla-central (Nightly channel)

APPROVAL REQUIRED

In order to increase the reliability of our primary repository, direct pushes to mozilla-central must now only be for one of the following reasons:

  • Merging from an integration/team/project repository (there is no restriction on who may make these merges) [a=merge].
  • Automated blocklist / HSTS preload list updates [a={blocklist-update,hsts-update}].
  • For the resolution (ie: backout or follow-up fix) of critical regressions (eg: top-crashers or other major functional regression) that will result in a Nightly respin or must make the imminent scheduled Nightly at all costs [a={backout,topcrasher,respin,...}].
    • Anything else for which common sense (or asking in #developers) says is an appropriate reason for a direct landing on mozilla-central [a=something_descriptive].

If your patch is eligible for direct-landing on mozilla-central:

  • Use the a=reason examples given above, to bypass the Mercurial hook used to prevent accidental pushes. Note: That whilst we are using the "a=" syntax (since that's all the hook supports for now), this is unrelated to the "release-driver approval request" process - so please do not request approval from them in Bugzilla.
    • Note if merging into mozilla-central, and your push didn't generate a merge commit (and so you have nowhere to put the "a=merge" to get past the hook), then either temporarily set the tree state to OPEN, try merging a different integration repo first (which may need a merge commit), or add an empty mq commit on top with an appropriate commit message.
  • Changes must meet the general checkin rules.
  • You must check the tree is green before pushing, notify the sheriffs in #developers and then watch mozilla-central for failures.
  • Set the Target Milestone field in Bugzilla to the current Nightly version after landing a bug fix on mozilla-central.

All other changes must instead land via one of the integration branches and will then be merged into mozilla-central once green (these merges occur typically 1-2 times a day on the last complete green push).

Please ask in #developers on IRC if you have questions.

mozilla-beta

APPROVAL REQUIRED

  • All changes must meet the general checkin rules. You must check the tree before pushing, and watch the tree for failures after pushing.
  • Patches must have the approval-mozilla-beta+ flag in Bugzilla. To request approval, set the approval-mozilla-beta? flag on the patch you wish to check in. Exception: If patches only make changes to tests, test harnesses or anything else that does not affect the shipped builds, they may land with self approval (use a=testonly, a=npotb etc).
  • Patches nominated for beta should:
    • not change any localizable strings.
    • have tests, or a strong statement of what can be done in the absence of tests.
    • have landed in mozilla-central to bake on the nightly channel for a few days.
    • have a comment in Bugzilla assessing performance impact, risk, and reasons the patch is needed on beta.
  • Approval requests will be processed by by the release manager team.
  • Set the appropriate status-firefoxN flag to "fixed" after landing a fix on the Beta branch.

mozilla-release

APPROVAL REQUIRED

  • Patches must have the approval-mozilla-release+ flag in Bugzilla. To request approval, set the approval-mozilla-release? flag on the patch you wish to check in. Exception: If patches only make changes to tests, test harnesses or anything else that does not affect the shipped builds, they may land with self approval (use a=testonly, a=npotb etc).
  • In the normal development process, no changes will land on mozilla-release except regular merges from mozilla-beta every six weeks.
  • Changes to the release branch are limited to urgent "chemspills" like zero-day security vulnerabilities and other unplanned emergencies. Any changes to this branch will be directly overseen by the release manager team. They are also subject to the same restrictions as #mozilla-beta, including string freeze and UUID freeze.

mozilla-esr60 (Firefox 60.x.y ESR)

APPROVAL REQUIRED