Calendar:Module Ownership: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Add link to current calendar module page.)
 
(35 intermediate revisions by 10 users not shown)
Line 1: Line 1:
This is a proposal of owners and peers of the calendar modules. '''It is not official yet!'''
<small>[[Calendar:Home_Page|<< Back to Calendar Home Page]]</small>
 
This is a non-current list of owners and peers of the calendar modules. A more current list is [[Modules/Calendar|here]].  '''Don't edit this file. Just don't.'''


Items without any owners at all are generally handled by those under "Default." However, in general, they could benefit from being their own strongly-owned modules at some point.
Items without any owners at all are generally handled by those under "Default." However, in general, they could benefit from being their own strongly-owned modules at some point.


{| border="1" cellpadding="4"
{| border="1" cellpadding="4"
Line 10: Line 11:
|-
|-
|Default<br>(stuff under /mozilla/calendar not otherwise listed here)
|Default<br>(stuff under /mozilla/calendar not otherwise listed here)
|mvl
|philipp
|jminta, lilmatt, daniel, mickey
|daniel, ctalbert, mvl<sup>*</sup>, lilmatt<sup>*</sup>
|-
|-
|colspan="3"|'''Applications/Extensions'''
|colspan="3"|'''Applications/Extensions'''
|-
|-
|Sunbird (calendar/sunbird)
|Sunbird (calendar/sunbird)
|mvl
|mvl<sup>*</sup>
|jminta, daniel
|ssitter, ctalbert, lilmatt<sup>*</sup>, daniel<sup>*</sup>
|-
|-
|Lightning (calendar/lightning)
|Lightning (calendar/lightning)
|mvl
|philipp
|jminta, daniel
|daniel, ctalbert, mvl<sup>*</sup>, lilmatt<sup>*</sup>
|-
|-
|colspan="3"|'''Components'''
|colspan="3"|'''Components'''
|-
|-
|Accessibility
|Accessibility
|?
|philipp
|?
|
|-
|-
|Alarms
|Alarms
|jminta
|philipp
|mvl, daniel
|daniel
|-
|-
|Art & Branding
|Art & Branding
|lilmatt
|MarkCarson
|MarkCarson
|lilmatt<sup>*</sup>
|-
|-
|Calendar Manager
|Calendar Manager
|mvl
|philipp
|jminta, daniel
|daniel, ctalbert, mvl<sup>*</sup>
|-
|-
|Import/Export (calendar/import-export)
|Import/Export (calendar/import-export)
|mvl
|mvl<sup>*</sup>
|mickey
|
|-
|-
|Installer (calendar/installer)
|Installer (calendar/installer)
|lilmatt
|
|rob_strong
|mschroeder, ctalbert, rob_strong, lilmatt<sup>*</sup>
|-
|-
|i18n/l10n (calendar/locales)
|i18n/l10n (calendar/locales)
|lilmatt
|sipaq
|?
|lilmatt<sup>*</sup>
|-
|-
|libical (calendar/libical)
|libical (calendar/libical)
|mvl
|daniel
|daniel, mickey
|philipp, mvl<sup>*</sup>
|-
|-
|Recurrence  
|Recurrence  
|daniel
|daniel
|mvl, mickey
|philipp, ctalbert, mvl<sup>*</sup>
|-
|-
|Timezones
|Timezones
|ctalbert
|daniel
|mvl, lilmatt, daniel
|ctalbert, mvl<sup>*</sup>, lilmatt<sup>*</sup>
|-
|-
|Views & Dialogs (calendar/{sunbird/}base/content)
|Views & Dialogs (calendar/{sunbird/}base/content)
|mickey
|philipp
|jminta, mvl
|berend, mschroeder
|-
|-
|iTIP
|iTIP
|ctalbert
|daniel
|lilmatt
|philipp, ctalbert, lilmatt<sup>*</sup>
|-
|-
|Printing
|Printing
|lilmatt
|
|daniel
|daniel, lilmatt<sup>*</sup>
|-
|-
|Website
|Website
|sipaq
|tobbi
|lilmatt
|TMZ, lilmatt<sup>*</sup>
|-
|User Interface (UI)
|clarkbw
|christian<sup>*</sup>
|-
|-
|colspan="3"|'''Providers'''
|colspan="3"|'''Providers'''
Line 85: Line 90:
|CalDAV
|CalDAV
|bbrowning
|bbrowning
|jminta
|philipp, daniel, lilmatt<sup>*</sup>
|-
|-
|Composite
|Composite
|mvl
|philipp
|daniel, mickey
|daniel, mvl<sup>*</sup>
|-
|-
|ICS
|ICS
|mvl
|daniel
|daniel, mickey
|philipp, mvl<sup>*</sup>, sebo
|-
|-
|Memory
|Memory
|mvl
|daniel
|jminta, daniel
|philipp, mvl<sup>*</sup>, sebo
|-
|-
|Storage
|Storage
|mvl
|daniel
|jminta, daniel
|philipp, mvl<sup>*</sup>, sebo
|-
|-
|WCAP
|WCAP
|daniel
|daniel
|?
|philipp
|-
|GDATA
|philipp
|daniel
|-
|-
|colspan="3"|'''Tier-1 platform-specific stuff'''
|colspan="3"|'''Tier-1 platform-specific stuff'''
|-
|-
|Linux
|Linux
|mvl
|philipp
|jminta, daniel
|daniel
|-
|-
|Mac OS X
|Mac OS X
|lilmatt
|daniel
|jminta
|ctalbert, lilmatt<sup>*</sup>
|-
|-
|Windows
|Windows
|ctalbert
|ctalbert
|ssitter, daniel
|
|}
|}


=== Review Process ===
<sup>*</sup> Backup reviewer.  Assign to them rarely.
 
If the bugzilla id is ":<name>", then bugzilla will expand it automatically. Just enter it into the reviewer field.
 
{| border="0"
! colspan="2" align="center" | Legend
|-
|
{| border="1"
!Reviewer
!Bugzilla ID
|-
|bbrowning
|browning at uwalumni dot com
|-
|berend
|<var>:berend</var>
|-
|christian
|chris.j.bugzilla at googlemail dot com
|-
|ctalbert
|<var>:ctalbert</var>
|-
|daniel
|<var>:dbo</var>
|-
|lilmatt
|lilmatt at flock dot com
|-
|MarkCarson
|mark at markcarson dot com
|-
|clarkbw
|clarkbw at gnome dot org
|}
|
{| border="1"
!Reviewer
!Bugzilla ID
|-
|mschroeder
|<var>:mschroeder</var>
|-
|mvl
|mvl at exedo dot nl
|-
|philipp
|<var>:Fallen</var>
|-
|rob_strong
|robert.bugzilla at gmail dot com
|-
|sebo
|sebo dot moz at googlemail dot com
|-
|sipaq
|<var>:sipaq</var>
|-
|ssitter
|<var>ssitter</var>
|-
|TMZ
|<var>:TMZ</var>
|-
|Tobbi
|<var>:Tobbi</var>
|}
|}


This is also '''not official'''!
=== Request Queue ===
When multiple reviewers come in question, you should check the [https://bugzilla.mozilla.org/request.cgi?action=queue&requester=&product=Calendar&type=review&requestee=&component=&group=requestee Calendar Request Queue] to see which reviewer has the smallest queue.


=== Review Process ===
Calendar does not require super-review. The only review is needed is the review of a module owner or peer of the involved module. (If a patch spans multiple modules, you need review from an owner or peer from each module. That sounds problematic, but due to the huge overlap in owners and peers, in most cases it can be done by one person.)
Calendar does not require super-review. The only review is needed is the review of a module owner or peer of the involved module. (If a patch spans multiple modules, you need review from an owner or peer from each module. That sounds problematic, but due to the huge overlap in owners and peers, in most cases it can be done by one person.)


If the module owner and their peers are all busy and don't have time to do a complete review, you can ask someone else to review the code. This must be 'known hacker', somebody who has done calendar work himself, but does not need to be a module owner or peer. If you have code review, you can ask a owner or peer of the module your code touches to give module-owner-approval. Giving this approval only means that the code is good from a high level point of view. Because this is a lot less work, it should be easier to get this approval.
If the module owner and their peers are all busy and don't have time to do a complete review, you can ask someone else to review the code. This must be 'known hacker', somebody who has done calendar work himself, but does not need to be a module owner or peer. If you have code review, you can ask a owner or peer of the module your code touches to give module-owner-approval. Giving this approval only means that the code is good from a high level point of view. Because this is a lot less work, it should be easier to get this approval.
Use the Bugzilla ID to identify the reviewer in the Requestee field of the Attachment form.
[[category:calendar|Module Ownership]]

Latest revision as of 18:17, 20 April 2020

<< Back to Calendar Home Page

This is a non-current list of owners and peers of the calendar modules. A more current list is here. Don't edit this file. Just don't.

Items without any owners at all are generally handled by those under "Default." However, in general, they could benefit from being their own strongly-owned modules at some point.

Module Owner Peers (alpha order)
Default
(stuff under /mozilla/calendar not otherwise listed here)
philipp daniel, ctalbert, mvl*, lilmatt*
Applications/Extensions
Sunbird (calendar/sunbird) mvl* ssitter, ctalbert, lilmatt*, daniel*
Lightning (calendar/lightning) philipp daniel, ctalbert, mvl*, lilmatt*
Components
Accessibility philipp
Alarms philipp daniel
Art & Branding MarkCarson lilmatt*
Calendar Manager philipp daniel, ctalbert, mvl*
Import/Export (calendar/import-export) mvl*
Installer (calendar/installer) mschroeder, ctalbert, rob_strong, lilmatt*
i18n/l10n (calendar/locales) sipaq lilmatt*
libical (calendar/libical) daniel philipp, mvl*
Recurrence daniel philipp, ctalbert, mvl*
Timezones daniel ctalbert, mvl*, lilmatt*
Views & Dialogs (calendar/{sunbird/}base/content) philipp berend, mschroeder
iTIP daniel philipp, ctalbert, lilmatt*
Printing daniel, lilmatt*
Website tobbi TMZ, lilmatt*
User Interface (UI) clarkbw christian*
Providers
CalDAV bbrowning philipp, daniel, lilmatt*
Composite philipp daniel, mvl*
ICS daniel philipp, mvl*, sebo
Memory daniel philipp, mvl*, sebo
Storage daniel philipp, mvl*, sebo
WCAP daniel philipp
GDATA philipp daniel
Tier-1 platform-specific stuff
Linux philipp daniel
Mac OS X daniel ctalbert, lilmatt*
Windows ctalbert

* Backup reviewer. Assign to them rarely.

If the bugzilla id is ":<name>", then bugzilla will expand it automatically. Just enter it into the reviewer field.

Legend
Reviewer Bugzilla ID
bbrowning browning at uwalumni dot com
berend :berend
christian chris.j.bugzilla at googlemail dot com
ctalbert :ctalbert
daniel :dbo
lilmatt lilmatt at flock dot com
MarkCarson mark at markcarson dot com
clarkbw clarkbw at gnome dot org
Reviewer Bugzilla ID
mschroeder :mschroeder
mvl mvl at exedo dot nl
philipp :Fallen
rob_strong robert.bugzilla at gmail dot com
sebo sebo dot moz at googlemail dot com
sipaq :sipaq
ssitter ssitter
TMZ :TMZ
Tobbi :Tobbi

Request Queue

When multiple reviewers come in question, you should check the Calendar Request Queue to see which reviewer has the smallest queue.

Review Process

Calendar does not require super-review. The only review is needed is the review of a module owner or peer of the involved module. (If a patch spans multiple modules, you need review from an owner or peer from each module. That sounds problematic, but due to the huge overlap in owners and peers, in most cases it can be done by one person.)

If the module owner and their peers are all busy and don't have time to do a complete review, you can ask someone else to review the code. This must be 'known hacker', somebody who has done calendar work himself, but does not need to be a module owner or peer. If you have code review, you can ask a owner or peer of the module your code touches to give module-owner-approval. Giving this approval only means that the code is good from a high level point of view. Because this is a lot less work, it should be easier to get this approval.

Use the Bugzilla ID to identify the reviewer in the Requestee field of the Attachment form.