Confirmed users
400
edits
Mobile/Fennec/Android: Difference between revisions
→Creating commits and submitting patches
| Line 66: | Line 66: | ||
=== Creating commits and submitting patches === | === Creating commits and submitting patches === | ||
Mercurial (hg) is the the main version control system that Mozilla uses, and to submit code for review, you should be able to generate patches or commits. Be sure to run mach mercurial-setup when cloning the source code repository -- this will ensure you have good default settings and extensions. | Mercurial (hg) is the the main version control system that Mozilla uses, and to submit code for review, you should be able to generate patches or commits. Be sure to run mach <tt>mercurial-setup</tt> when cloning the source code repository -- this will ensure you have good default settings and extensions. | ||
Historically, Mozilla has used Mercurial patch queues to submit code changes for review. However, Mozilla developers are now encouraged to use a Mercurial bookmark-based workflow. | Historically, Mozilla has used Mercurial patch queues to submit code changes for review. However, Mozilla developers are now encouraged to use a Mercurial bookmark-based workflow. | ||
| Line 84: | Line 84: | ||
Once the patch gets an r+ on review, if you don't have tree privileges, ask someone to land it for you; or, set checkin-needed in the keywords field AND ask someone to push it to the try server. | Once the patch gets an r+ on review, if you don't have tree privileges, ask someone to land it for you; or, set checkin-needed in the keywords field AND ask someone to push it to the try server. | ||
(If you want more information about bookmarks-based workflow, gps | (If you want more information about bookmarks-based workflow, take a look at gps's [https://people.mozilla.org/~gszorc/mastering-vcs/#1 slides]; [http://gregoryszorc.com/blog/category/mercurial/3/ gps's blog] is another good place to get information about version control at Mozilla.) | ||
=== Android NDK and SDK version notes === | === Android NDK and SDK version notes === | ||