Mobile/Fennec/Android: Difference between revisions

Mobile/Fennec/Android (view source)

Revision as of 00:19, 19 May 2015

1,124 bytes removed , 19 May 2015

→‎Creating commits and submitting patches

Liuche

Confirmed users

400

edits

@@ Line 66: / Line 66: @@
 === Creating commits and submitting patches ===
 Mercurial (hg) is the the main version control system that Mozilla uses, and to submit code for review, you should be able to generate patches or commits. Be sure to run <tt>mach mercurial-setup</tt> when cloning the source code repository -- this will ensure you have good default settings and extensions.
-Historically, Mozilla has used Mercurial patch queues to submit code changes for review. However, Mozilla developers are now encouraged to use a Mercurial bookmark-based workflow.
+Instructions for submitting a patch can be found [https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Committing_the_patch here].
-If you're a contributor and new to Mercurial, patch queues are conceptually simple and fine for getting your first few patches up; see the instructions on [https://developer.mozilla.org/en-US/docs/Mercurial_Queues Mercurial patch queues].
-If you're interested in using bookmarks, take a look at [http://mozilla-version-control-tools.readthedocs.org/en/latest/hgmozilla/bookmarks.html bookmarks-based development].
 After writing the patch, make sure the commit message is of the correct format:<br />
@@ Line 79: / Line 75: @@
 So for example, for [https://bugzilla.mozilla.org/show_bug.cgi?id=1128431 bug 1128431], the commit message should be:<br />
 Bug 1128431 -  'Start browsing' link from onboarding v1.5 is not visible on small screen devices. r=liuche
-After uploading a patch, set the r? flag on the bug (to the mentor or a relevant reviewer) to get review on the patch. If the patch isn't quite ready, the f? flag can be set to request feedback from someone.
-Once the patch gets an r+ on review, if you don't have tree privileges, ask someone to land it for you; or, set checkin-needed in the keywords field AND ask someone to push it to the try server.
-(If you want more information about bookmarks-based workflow, take a look at gps's [https://people.mozilla.org/~gszorc/mastering-vcs/#1 slides]; [http://gregoryszorc.com/blog/category/mercurial/3/ gps's blog] is another good place to get information about version control at Mozilla.)
 === Android NDK and SDK version notes ===