Gaia/SMS/Scrum/2.2S14

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1169255)

Bugzilla link

Bugzilla query error

Bugzilla API returned an error: 1

Remaining points and burndown chart

google chart api url for Sprint 2.2S14

Burndown chart

	Remaining points
Start	15
Day 2	14
Day 3	14
Day 4	13
Day 5	13
Day 6	13
Day 7
Day 8
Day 9
Day 10
Day 11
Day 12
Day 13
Day 14
End

SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-2.2S14")

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
1146393	Julien Wajsberg [:julienw]	[Shinano][Aries] No attachment preview visible for pictures over 5MB	---	No cf_feature-b2g	[sms-most-wanted][Spark][sms-sprint-2.2S14]	FIXED
1162030	Julien Wajsberg [:julienw]	[Messages][NG] Figure out how navigation works	---	No cf_feature-b2g	[p(FxOS-S4)=2][p(FxOS-S3=3][p(2.2S13)=2][sms-sprint-2.2S14]	FIXED
1168941	Oleg Zasypkin [:azasypkin]	[Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view	---	No cf_feature-b2g	[sms-sprint-2.2S14]	FIXED

3 Total; 3 Open (100%); 0 Resolved (0%); 0 Verified (0%);

All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Resolution
1168060	Julien Wajsberg [:julienw]	[Flame][DSDS][Message]"Dial 12345 via" is displayed as heading at "Select SIM" view.	---	---	FIXED
1168441	Oleg Zasypkin [:azasypkin]	[Messages][NG] Implement ActivityShim	---	---	FIXED
1168941	Oleg Zasypkin [:azasypkin]	[Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view	---	---	FIXED
1169150	Steve Chung [:steveck]	[Messages][NGA] Add threads.js to our codebase with script could fetch/rename the lib easily	---	---	FIXED
1169255		SMS sprint 2.2S14	---	---	INCOMPLETE
1169543	Julien Wajsberg [:julienw]	[Messages][NG] Create draft spec for the main services we need	---	---	FIXED
1169558	Julien Wajsberg [:julienw]	[Messages][NG] Lay out Conversation service structure	---	---	FIXED
1169573	Steve Chung [:steveck]	[Messages][NG] Lay out Messaging service structure	---	---	FIXED
1171865	Steve Chung [:steveck]	[Messages][NG] Layout mozMobileMessageShim structure	---	---	FIXED

9 Total; 9 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 28th May

Steve

• bug 1167495 [Messages][l10n] Fix file path changes in l10n xfail.list
  • I changed my mind to fix some l10n.get using in activity handler since it looks easy. Got some feedback from Oleg.
• bug 1169150 - [Messages][NGA] Add threads.js to our codebase with script could fetch/rename the lib easily.
  • Add a script to download the lib and wrap up.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads.currentId in conversation view
  • Found we have 2 parts(exclude the before enter) that might need to access the Threads(conversationService), will raise some question within the patch.

Today:

• Create bug for loading threads/drafts together within conversationService, I might create another one for moving mozMobileMesage api into another service first.
• Clean up the use of threads.active in conversation view
• Some tasks for background if I have time
  • Fix the attachment menu for closing the option menu manually
  • gaia-component stuff
  • file loading in Template.js

Julien

Note: today I'm leaving the office around 4pm, and I'll be at a conference tomorrow.

• had the planning meeting -- still haven't created the wiki, will do it this morning.
• reviewed the contributor bug 1153885; simple bug but I had to test thoroughly all cases
• reviewed oleg's patch in bug 1127398 to make some code simpler and easier to refactor later
• had a meeting with vivien (will be weekly) to explain him what we're doing and what are our issues

Today: I want to:

• put everything in the wiki and create bugs in bugzilla
• create a PR with initial spec
• finish the bug 1168060 about the sim picker translation issue

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

Yesterday was hack-day, so not much done for SMS, excited by TypeScript :)

(Julien) the first time I saw TypeScript I was excited already ;)

(Oleg) Heh, I was excited more when I actually tried it :)

• bug 1162027 - [Messages][New Gaia Architecture] extract inbox/index.html
  • Got r+, landed, it should also fix some issues that we had while running app in browser (landed).
• bug 1162028 - [Messages][New Gaia Architecture] extract conversation/index.html
  • Moved activity service to a separate bug as was planned (no progress).
• bug 1168441 - [Messages][NG] Implement ActivityService
  • Rebased and will rebase on Steve threads.js patch as well, will polish and add some spec related info (in progress).
• bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
  • Prepared PR, got review, extracted new part of PR to the bug below (in progress).
• bug 1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view
  • The bug we'll have once bug 1127398 is landed (no progress).

Other:

• Left some feedback on Steve's l10n patch, really wondering if we should use

mozSetMessageHandlerPromise in our promisified system message handlers, but maybe not in this bug. Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 3: 29th May

Steve

• bug 1167495 [Messages][l10n] Fix file path changes in l10n xfail.list
  • Landed in master

bug 1169150 - [Messages][NGA] Add threads.js to our codebase with script could fetch/rename the lib easily.

• • Get some feedback and updated
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads.currentId in conversation view
  • No new progress yet
• bug 1169541 - [Messages] [NGA] Refine the thread query and move draft query/getThreads API into conversation service / messaging service
  • Create a bug for refine the interface for thread query. Not sure if we need messaging service/conversation service bug ready first.

Today:

• Start to investigate the first version of the api for query thread
• Clean up the use of threads.active in conversation view
• Review Oleg's patch for conversation markup splitting
• Some tasks for background if I have time
  • Fix the attachment menu for closing the option menu manually
  • gaia-component stuff
  • file loading in Template.js

Julien

• Absent/no report

Oleg

• bug 1162028 - [Messages][New Gaia Architecture] extract conversation/index.html
  • Proposed monkey patch that IMO can save us some time until we know for sure how navigation will be changed/refactored (awaiting feedback).
• bug 1168441 - [Messages][NG] Implement ActivityService
  • Rebased and the latest master and resolved conflicts. Waiting for bridge.js before asking for review (ready for review, waiting for dependency).
• bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
  • Fixed review comments and got r+, landed (landed).
• bug 1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view
  • Rebased on the latest master, ready for review (ready for review, will ask later).

Other:

• Reviewed Steve's l10n patch;
• Reviewed Steve's bridge.js patch;
• Spent some time to understand why I couldn't run integration tests locally for some time already - turned out its problem in my new Ubuntu Gnome 15 installation (b2g wasn't run) - xhost +local: solved the problem.

Today:

• Will create bugs for the sprint;
• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 4: 1st June

Steve

• bug 1169150 - [Messages][NGA] Add threads.js to our codebase with script could fetch/rename the lib easily.
  • R+ and need to move out the script from tool to sms root for bower component
• bug 1169541 - [Messages] [NGA] Refine the thread query and move draft query/getThreads API into conversation service / messaging service
  • Ongoing, but will land the messaging service layout first for getThreads(or necessity of this api in messaging or conversation service)
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Will give a patch for simply layout today. Basically the API is almost the same with getThreads/getMessages kept inside. We can discuss if we really need this in the bug
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads.currentId in conversation view
  • No new progress yet

Today:

• Land bridge lib today
• Give a patch for messaging service and start to investigate the first version of the api for query thread
• Clean up the use of threads.active in conversation view
• Review Oleg's patch for conversation markup splitting
• Some tasks for background if I have time
  • Fix the attachment menu for closing the option menu manually
  • gaia-component stuff
  • file loading in Template.js

Julien

• received my Aries so I learnt how to flash it - now I need to decide if I want master for dogfood ;)
• I had a look at how exiftran rotates jpeg images losslessly for bug 1169055 (I left links there if you want to have a look)
• thought a little in bug 1146393: we should put the limit higher now that we use moz-sample-size - maybe 10MB is good? That would be really not risky (unless the limit is too high).
• quickly reviewed bug 1127398 that refactors how forward/activity work
• finished bug 1168060 - latest patch is really simple ;)
• quickly reviewed bug 1169150 from Steve about the shell script to add threads.js - sorry to be picky ;)
• added some information in bug 1040874 for a contributor to pick it up
• in the train, rebased the db experiment with latest master to make it easier to look at: https://github.com/mozilla-b2g/gaia/pull/28681 (even if it's not in the sprint, I think it's good to at least keep it current); I think i'll work on it little more during transports.

Today: I want to:

• look at bugs Oleg created for the sprint, make sure everything is in order (I'm sure it is ! ;) )
• create a PR with initial spec so that we can discuss on it
• do asked reviews/needinfo
• I'll maybe do a simple patch for bug 1146393 for spark now that people dogfood.
• pick a bug for the sprint

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1162028 - [Messages][New Gaia Architecture] extract conversation/index.html
  • No progress, just rebased on the top of updated dependency patch (awaiting feedback).
• bug 1168441 - [Messages][NG] Implement ActivityService
  • Rebased on Steve's bridge PR and made necessary changes + simplified patch. Waiting for bridge.js before asking for review (ready for review, waiting for dependency).
• bug 1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view
  • Rebased on the latest master, ready for review (ready for review, will ask later).

Other:

• Discussed with Steve services we'd like to implement and filed necessary bugs.

  (Julien) do you have the result somewhere?

  (Oleg) On IRC history only :) I can copy and paste it somewhere if you can't recover history

  (Julien) OK I think I'll be able to look at it then - the result will be in the README anyway :)

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 5: 2nd June

Steve

bug 1169150 - [Messages][NGA] Add threads.js to our codebase with script could fetch/rename the lib easily.

• • Landed in master, hope it could do some help if you worked on threads already. Yep!
• bug 1169541 - [Messages] [NGA] Refine the thread query and move draft query/getThreads API into conversation service / messaging service
  • waiting for the clear picture about service draft spec
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Create a patch for wrapping the current message manager. But we definitely need conclusion in bug 1169543 first.
• Gave some idea about the spec draft, and explain why I prefer only one wrapper for APIs
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads.currentId in conversation view
  • No new progress yet

Today:

• Give some early feedback about Oleg's patch for splitting part(Sorry for the late, I think I could simply give some feedback in extracting part first before we reach any confirm answer about the spec and activity service)
• Maybe start to give some early thought about loading threads.
• Clean up the use of threads.active in conversation view
• Some tasks for background if I have time
  • Fix the attachment menu for closing the option menu manually
  • gaia-component stuff
  • file loading in Template.js

Julien

• had a quick look at bugs created for the sprint.
• created a PR for the spec proposal in bug 1169543
• reviewed bug 1168941 to fix a regression introduced by the activity/forward refactoring
• reviewed bug 1168441 about ActivityService -- especially asked a question about future architecture
• had a first look to the MessagingService Layout (bug 1169573) but this depends a lot of the spec first...

Others:

• Discussed with Oleg about future architecture around system messages
• Discussed with Vivien about navigation transitions and also system messages, to know the approximate timeline. (My view here is that we should focus on our problems first, even if that means the app won't be 100% functional yet. If we can overcome easily current issues, then let's do it, but otherwise we can leave other teams...)

Today: I want to:

• do asked reviews/needinfo
• I'll maybe do a simple patch for bug 1146393 for spark now that people dogfood.
• pick a bug for the sprint

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1162028 - [Messages][New Gaia Architecture] extract conversation/index.html
  • While waiting for feedback playing with real links to navigate between views, works but slow, will experiment more :) (awaiting feedback).

  (Julien) I presume you're working with HTTP and especially the httpd plugin (or another development based httpd server) ?

  (Oleg) I mean it feels slow because it loads all js/css files once again (shouldn't it be cached?). Will check what makes me to feel like this.

  (Julien) I'm asking if you use HTTP because our HTTP development servers disable cache by design :) for example when I use the python "SimpleHTTPServer" requests themselves are really slow, and it feels slow, but it won't be the same on device :)

  (Oleg) I just use firefox -p profile-debug

  (Julien) ok, so this one is less slow but it still disables cache (I did the code to disable cache :p), it has "Expires: -1" headers on all responses.

  (Oleg) :) No worries, it doesn't make development hard for me :)

  (Julien) yeah, I just wanted to relativize :D Maybe you can start implementing a caching serviceworker using Francisco's lib :)

  (Oleg) Yep, had this thought :) Would like to try

• bug 1168441 - [Messages][NG] Implement ActivityService
  • Rebased on master, retested that everything works as before, got first review comments and replied with my vision on the future of this (in review).

    (Julien) OK, will read soon then ;)

    (Oleg) Thanks! Replied with what I had in my head right after sleep :)

• bug 1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view
  • Asked for review, got r+, rebased and wasn't able to land yesterday due to closed tree, retried again today (almost landed).

Other:

• Left some feedback on Julien's spec PR;
• Some discussion with Johan about mock storage.

Today:

• Will experiment further to see if we can make startup js more modular (to not lazily load files we don't need for separate views) and will try more with real links to navigate.

  (Julien) I had a first not-working WIP using "async" scripts --- I wonder if it would be easier now that we have less JS files in each HTML file. (just a thought)

  (Oleg) Can I read/see your idea just to better understand it?

  (Julien) nothing more than adding "async" in the "script" elements: https://github.com/mozilla-b2g/gaia/compare/master...julienw:experiment-async-scripts#diff-56289627d91906a9c3b0f834ef19f514R55

  (Oleg) Ah, I see, ok thanks!

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 6: 3rd June

Steve

• bug 1169541 - [Messages] [NGA] Refine the thread query and move draft query/getThreads API into conversation service / messaging service
  • waiting for the clear picture about service draft spec
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Create a patch for wrapping the current message manager. But we definitely need conclusion in bug 1169543 first.
• Reviewed markup extract part.
• Reading the comment from spec drafts.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads.currentId in conversation view
  • No new progress yet

Today:

• Reviewing the activity service, just have one question for the overall structure, will look deeper then.
• Give some early thought about loading threads.
• Clean up the use of threads.active in conversation view
• Some tasks for background if I have time
  • Fix the attachment menu for closing the option menu manually
  • gaia-component stuff
  • file loading in Template.js

Julien

• discussed about bug 1168441 about ActivityService
• spent time on bug 818000 to have a good proposal about system messages (not in SW)
• spent time to write a mail about activities in a URL and Service Worker world: https://groups.google.com/d/msg/mozilla.dev.webapi/JUlLSCD4fRo/5NjKEaWzwKYJ

(Oleg) Sounds interesting! Looks like we need Cross Origin SW for this?

(Julien) I don't think so, because Gecko would have a role of proxy here.

(Steve) It's a really interesting thought :)

(Julien) Thanks ! there are perf implications though, as Andrew said ;) will see if this gives something...

Others:

• tried b2gdroid on my old Android phone (that I had to update)

(Oleg) I was actually able to run from the second try, sms crashes it :) Submitted bug. I'm also wondering if we tried to add "native" support for FxOS into MultiRom app as Ubuntu Touch did.

(Julien) yeah I think it uses directly mozMobileMessaging Android implementation -- and I think this is mostly untested these days

• tried also WebIDE with Firefox Nightly on Android and Chrome on Android -- but couldn't make it work with iOS

Today: I want to:

• do asked reviews/needinfo
• I'll maybe do a simple patch for bug 1146393 for spark now that people dogfood.
• pick a bug for the sprint

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

Not really productive day, but it's ok assuming how much things we have to discuss and sort out :)

• bug 1162028 - [Messages][New Gaia Architecture] extract conversation/index.html
  • Got feedback from Steve (awaiting feedback);
  • Moved forward with "modular startup" so that we not lazy load files in separated views that we don't need, it's in WIP stage, bug you can check https://github.com/mozilla-b2g/gaia/pull/30381 to see what's happening (in progress).
• bug 1168441 - [Messages][NG] Implement ActivityService
  • Intensive discussion about activity service and its future with Julien (in review).
  • Let's continue discussion today on IRC.
• bug 1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view
  • Added checkin-needed for the sheriffs to land (almost landed).

Other:

• More discussion around service spec.

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 7: 4th June

Steve

• bug 1169541 - [Messages] [NGA] Refine the thread query and move draft query/getThreads API into conversation service / messaging service
  • waiting for the clear picture about service draft spec
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Ongoing with the original message manager/drafts/threads module version
• Reviewed markup extract part.
• Reply some though about spec drafts.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads.currentId in conversation view
  • No new progress yet

Today:

• Reviewing the activity service, just have one question for the overall structure, will look deeper then.
• Give some early thought about loading threads.
• Clean up the use of threads.active in conversation view
• Some tasks for background if I have time
  • Fix the attachment menu for closing the option menu manually
  • gaia-component stuff
  • file loading in Template.js

Julien

Note: I'll be at the Best Of Web conference tomorrow. I plan to work during that day (between breaks) but I won't be able to attend the standup.

• continued discussion about bug 1168441 about ActivityService
• spent some time during transport to have a working navigation with several-views-in-one-panel working (like we'll have for some time). I'm not taking transitions into account to keep this simple. Not pushed yet.

Today: I want to:

• do asked reviews/needinfo
• update and finish the spec
• I'll maybe do a simple patch for bug 1146393 for spark now that people dogfood.
• pick another bug for the sprint

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1162028 - [Messages][New Gaia Architecture] extract conversation/index.html
  • Prepared one more PR with another option to solve this bug so that you can compare (awaiting feedback).
• bug 1168441 - [Messages][NG] Implement ActivityService
  • More discussion on that. Julien confirmed with Etienne that we'll eventually have to support multiple Messages inline activities at the same time. So we decided to add support for this in activity service (the simplest option to just suffix service name with "app-id" so that every inline activity instance has its unique service-client pair). Will handle this today (in progress, awaiting feedback).

(Steve) hmm, maybe we can handle multiple activity in another follow up? Since it's not supported yet.

(Julien) yeah, I don't want to fully support it now but I don't want things to break badly once they start implementing it. Well I don't know, I don't want to block progress just for this either.

(Oleg) As you guys wish, change should be really simple.

• bug 1168941 - [Messages] Conversation view is rendered incorrectly when user tries to send message from Participants view
  • Landed (landed).

Other:

• Provided small patch/gist to help Johan with his integration test for recipients input (our contacts mock doesn't support "contains" filter operation yet) - https://gist.github.com/azasypkin/e9f890e0f5728a707d5d
• More discussion around service spec.

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.