DocShell: Difference between revisions
(remove spam, restore content) |
m (completed work) |
||
| Line 55: | Line 55: | ||
== Current plans for docshell == | == Current plans for docshell == | ||
nsIWebShell and nsIWebShellContainer will be eliminated ([https://bugzilla.mozilla.org/show_bug.cgi?id=273319 bug 273319]) | nsIWebShell and nsIWebShellContainer will be eliminated ([https://bugzilla.mozilla.org/show_bug.cgi?id=273319 bug 273319]) | ||
| Line 69: | Line 67: | ||
nsIWebShell removed. Thanks to bz! -- [http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-01-03+14%3A49&maxdate=2005-01-03+14%3A51&cvsroot=%2Fcvsroot Bonsai] | nsIWebShell removed. Thanks to bz! -- [http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-01-03+14%3A49&maxdate=2005-01-03+14%3A51&cvsroot=%2Fcvsroot Bonsai] | ||
nsDocLoaderImpl ([http://lxr.mozilla.org/mozilla/source/uriloader/base/nsDocLoader.cpp nsDocLoader.cpp]) will be merged into nsDocShell; or rather, nsDocShell will become a subclass of nsDocLoaderImpl ([https://bugzilla.mozilla.org/show_bug.cgi?id=272471 bug 272471]) | |||
Revision as of 14:55, 5 August 2005
Docshell Documentation
The goal of this page is to serve as a dumping/organization ground for docshell docs. When someone finds out something, it should be added here in a reasonable way. By the time this gets unwieldy, hopefully we will have enough material for several actual docs on what docshell does and why.
Some of these sections need writing, and we may need other sections... Feel free to rearrange as needed
- About (What actually is docshell?)
Interfaces Implemented by Docshell
Docshell + webshell implement the following interfaces
Webshell:
- nsIWebShell LXR
- nsIWebShellContainer LXR
- nsIWebShellServices LXR
- nsILinkHandler LXR
- nsIClipboardCommands (why?) LXR
Docshell:
- nsIDocShell LXR
- nsIDocShellTreeItem LXR
- nsIDocShellTreeNode LXR
- nsIDocShellHistory LXR
- nsIWebNavigation LXR
- nsIBaseWindow LXR
- nsIScrollable LXR
- nsITextScroll LXR
- nsIDocCharset LXR
- nsIContentViewerContainer LXR
- nsIInterfaceRequestor LXR
- nsIScriptGlobalObjectOwner LXR
- nsIRefreshURI LXR
- nsIWebProgressListener LXR
- nsIEditorDocShell LXR
- nsIWebPageDescriptor LXR
In my view, nsIDocShellTree* and nsIWebShellContainer should all be merged into a single "tree node" interface. nsIWebShell should merge into nsIDocShell. nsILinkHandler, not sure. nsIContentViewerContainer and nsIScriptGlobalObjectOwner, do we really need those? nsIRefreshURI is probably something to merge into nsIDocShell (or even nsIWebNavigation?). nsIEditorDocshell also doesn't really need to be a separate interface.
Then again, do we want to just dump all sorts of stuff onto nsIDocShell? Not sure about that. Maybe we should look at who uses nsIDocShell and these other interfaces and why?
Session history (needs work)
URI loading (needs work)
Progress notifications (needs work)
Bugs that could need some Docshell cleanup (needs work)
- bug 249751 Links whose onclick closes the window fail to trigger link
- bug 84833 Calling self.close() right after calling submit() cancels submission
Current plans for docshell
nsIWebShell and nsIWebShellContainer will be eliminated (bug 273319)
nsWebShell should be merged into nsDocShell
bug 261086 - docshell does not need quite as many things in its GetInterface implementation
DocShell:IRC_Logs has some IRC discussions concerning the future direction of docshell and docloader
Completed Work
nsIWebShell removed. Thanks to bz! -- Bonsai
nsDocLoaderImpl (nsDocLoader.cpp) will be merged into nsDocShell; or rather, nsDocShell will become a subclass of nsDocLoaderImpl (bug 272471)